From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 45FD31B96D for ; Tue, 10 Apr 2018 09:55:58 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B81F04075A9C; Tue, 10 Apr 2018 07:55:57 +0000 (UTC) Received: from [10.36.112.60] (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FCDA2166BAD; Tue, 10 Apr 2018 07:55:56 +0000 (UTC) To: "Wodkowski, PawelX" , "Zhang, Roy Fan" , "dev@dpdk.org" Cc: "jianjay.zhou@huawei.com" , "Tan, Jianfeng" References: <20180409153429.20123-1-roy.fan.zhang@intel.com> <4ccaebf4-89f3-74ba-32cc-f75f174fd331@redhat.com> From: Maxime Coquelin Message-ID: Date: Tue, 10 Apr 2018 09:55:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 10 Apr 2018 07:55:57 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 10 Apr 2018 07:55:57 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 07:55:58 -0000 On 04/10/2018 09:47 AM, Wodkowski, PawelX wrote: >> -----Original Message----- >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >> Sent: Tuesday, April 10, 2018 9:44 AM >> To: Wodkowski, PawelX ; Zhang, Roy Fan >> ; dev@dpdk.org >> Cc: jianjay.zhou@huawei.com; Tan, Jianfeng >> Subject: Re: [PATCH] lib/librte_vhost: fix bugs >> >> Hi Pawel, >> >> On 04/10/2018 09:32 AM, Wodkowski, PawelX wrote: >>>> # all source are stored in SRCS-y >>>> SRCS-$(CONFIG_RTE_LIBRTE_VHOST) := fd_man.c iotlb.c socket.c vhost.c >> \ >>>> diff --git a/lib/librte_vhost/vhost_crypto.c >> b/lib/librte_vhost/vhost_crypto.c >>>> index d84513e7f..2acfc908c 100644 >>>> --- a/lib/librte_vhost/vhost_crypto.c >>>> +++ b/lib/librte_vhost/vhost_crypto.c >>>> @@ -381,7 +381,7 @@ vhost_crypto_create_sess(struct vhost_crypto >>>> *vcrypto, >>>> return; >>>> } >>>> >>>> - VC_LOG_DBG("Session (key %lu, session %p) created.", >>>> + VC_LOG_DBG("Session (key %llu, session %p) created.", >>> >>> Why 'llu' instead of PRIu64 (here and there)? >> >> You are right, but Fan actually fixed it in updated version (the initial >> patch has been split in 3): >> [PATCH] vhost/crypto: fix session id printf >> > > Ohh, sorry. I need more coffee before starting review :) No problem, that wans't obvious that these 3 patches superseded this one. Your reviews are welcome! Maxime > >> Cheers, >> Maxime >>> Pawel >>> > > Pawel >