From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B931EA04BC; Fri, 9 Oct 2020 14:01:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 957B91D563; Fri, 9 Oct 2020 14:01:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 9CC671D562 for ; Fri, 9 Oct 2020 14:01:17 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 099C0ebj021090; Fri, 9 Oct 2020 05:01:00 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=mX1aQNcdfRlOPzqm1Np1psZnjBxy3HK8Mqbco7NR/ks=; b=j+ZeO5Fap2aDMc95Ece3lHDMTgPeuS4ZHs175hIlR4pzBUGsWSeU3xnTICXERZ1X00z9 E4FQhuhlQlc3+io3mPzJqO7NM972gzKZsFz8N7dzPgs7/cYfsoxIbkKUSYJmsHggirWk 0GBuBgVzTiQZQNtwBeInQSpQgm6AP/VIom6RY7MmLq3K8ReSTjWGmaFExb77OxJZaqI0 S069hxCBBcu648HRkrwJH6FZxYIKXVKdMRy2SP5dxrKD4rQ9yfBg9qgdwxfWeqBKdopS rGboMuiQkvmnjZyvB3L+mUz/zskqtOLbtPHZvNDfprPAz0BwPChtszCqW7WpvIC7+9qG TQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 3429hh2fhp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 09 Oct 2020 05:01:00 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 9 Oct 2020 05:00:58 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 9 Oct 2020 05:00:57 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 9 Oct 2020 05:00:57 -0700 Received: from [10.193.39.7] (NN-LT0019.marvell.com [10.193.39.7]) by maili.marvell.com (Postfix) with ESMTP id DDF3D3F7040; Fri, 9 Oct 2020 05:00:42 -0700 (PDT) To: Ciara Power , CC: Bruce Richardson , Shepard Siegel , Ed Czeck , "John Miller" , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Rasesh Mody , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , "Evgeny Schemeilin" , Igor Chauskin , "Gagandeep Singh" , John Daley , Hyong Youb Kim , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Wei Hu (Xavier)" , "Min Hu (Connor)" , "Yisen Zhuang" , Beilei Xing , "Jeff Guo" , Qiming Yang , Haiyue Wang , Alfredo Cardigliano , Rosen Xu , Ferruh Yigit , Shijith Thotton , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Martin Spinler , Heinrich Kuhn , Harman Kalra , "Jerin Jacob Kollanukkaran" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Maxime Coquelin , Chenbo Xia , Zhihong Wang References: <20200807123009.21266-1-ciara.power@intel.com> <20201009102140.20730-1-ciara.power@intel.com> <20201009102140.20730-4-ciara.power@intel.com> From: Igor Russkikh Message-ID: Date: Fri, 9 Oct 2020 15:00:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201009102140.20730-4-ciara.power@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-09_06:2020-10-09, 2020-10-09 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v6 03/14] doc: remove references to make from NICs guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ciara, Thanks for the patch, > --- a/doc/guides/nics/atlantic.rst > +++ b/doc/guides/nics/atlantic.rst > @@ -26,10 +26,6 @@ Experimental API features > > - MACSEC PMD API is considered as experimental and is subject to > change/removal in next DPDK releases. > > -Configuration Information > -^^^^^^^^^^^^^^^^^^^^^^^^^ > - > -- ``CONFIG_RTE_LIBRTE_ATLANTIC_PMD`` (default ``y``) > > Application Programming Interface > --------------------------------- For atlantic, Reviewed-by: Igor Russkikh > diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst > index e874915c2f..32eede5da4 100644 > --- a/doc/guides/nics/qede.rst > +++ b/doc/guides/nics/qede.rst > @@ -106,22 +106,9 @@ Performance note > Config File Options > ~~~~~~~~~~~~~~~~~~~ > > -The following options can be modified in the ``.config`` file. Please note > that > -enabling debugging options may affect system performance. > +The following option can be modified in the ``config/rte_config.h`` file. > > -- ``CONFIG_RTE_LIBRTE_QEDE_PMD`` (default **y**) > - > - Toggle compilation of QEDE PMD driver. This one is correctly removed, but the below defines, > -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX`` (default **n**) > - > - Toggle display of transmit fast path run-time messages. > - > -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX`` (default **n**) > - > - Toggle display of receive fast path run-time messages. > - > -- ``CONFIG_RTE_LIBRTE_QEDE_FW`` (default **""**) > +- ``RTE_LIBRTE_QEDE_FW`` (default **""**) > > Gives absolute path of firmware file. > ``Eg: "/lib/firmware/qed/qed_init_values-8.40.33.0.bin"`` These all still exist. I believe "CONFIG_" prefix should be removed here, but the defines and code behind them should stay. Regards, Igor