From: "Kinsella, Ray" <mdr@ashroe.eu>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: jerinj@marvell.com, David Marchand <david.marchand@redhat.com>,
Neil Horman <nhorman@tuxdriver.com>,
Timothy McDaniel <timothy.mcdaniel@intel.com>
Subject: Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
Date: Tue, 13 Apr 2021 17:09:25 +0100 [thread overview]
Message-ID: <e8a2750f-afa8-f35e-8f2b-aef2023c0551@ashroe.eu> (raw)
In-Reply-To: <20210413084525.3057669-1-thomas@monjalon.net>
On 13/04/2021 09:45, Thomas Monjalon wrote:
> The eventdev driver DLB was removed in DPDK 21.05,
> breaking the ABI check.
> The exception was agreed so we just need to skip this check.
>
> Note: complete removal of a driver cannot be ignored
> in devtools/libabigail.abignore, so the script must be patched.
>
> Fixes: 698fa829415d ("event/dlb: remove driver")
>
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> This should have been done as part of removing the driver.
> The CI is currently broken, so it should be merged today.
> ---
> devtools/check-abi.sh | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
> index 9835e346da..ca523eb94c 100755
> --- a/devtools/check-abi.sh
> +++ b/devtools/check-abi.sh
> @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
> echo "Skipped glue library $name."
> continue
> fi
> + if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
> + echo "Skipped removed driver $name."
> + continue
> + fi
So this is brute force fix - we can anticipate this problem happening again.
Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?
next prev parent reply other threads:[~2021-04-13 16:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 13:20 [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob Kollanukkaran
2021-04-12 13:27 ` McDaniel, Timothy
2021-04-12 13:40 ` Jerin Jacob
2021-04-12 22:12 ` Thomas Monjalon
2021-04-13 7:15 ` David Marchand
2021-04-13 7:31 ` Thomas Monjalon
2021-04-13 8:45 ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
2021-04-13 9:15 ` David Marchand
2021-04-13 9:32 ` Thomas Monjalon
2021-04-13 16:09 ` Kinsella, Ray [this message]
2021-04-13 16:44 ` Thomas Monjalon
2021-04-13 16:45 ` Kinsella, Ray
2021-04-13 8:54 ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
2021-04-13 9:01 ` Thomas Monjalon
2021-04-13 9:07 ` David Marchand
2021-04-13 9:12 ` Thomas Monjalon
2021-04-13 9:14 ` David Marchand
2021-04-13 12:58 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a2750f-afa8-f35e-8f2b-aef2023c0551@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).