From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15772A0524; Tue, 13 Apr 2021 18:09:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2AD5161163; Tue, 13 Apr 2021 18:09:34 +0200 (CEST) Received: from dal1relay225.mxroute.com (dal1relay225.mxroute.com [199.181.239.225]) by mails.dpdk.org (Postfix) with ESMTP id D43A2161163 for ; Tue, 13 Apr 2021 18:09:32 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by dal1relay225.mxroute.com (ZoneMTA) with ESMTPSA id 178cbfeac2b000770d.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 13 Apr 2021 16:09:28 +0000 X-Zone-Loop: 459284b99cff48305ff3d9116d99e3095ed3d40b790d X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ba8/o6ZNUAvUoUEWWiSmhI9ZATPyxE1miEZIEr0F86E=; b=YLh7BAB0DdXhslLPJSvBU6fmOm zjIkO03eloWXf5ZPc348J8Ncdtu50KlBlJY/yRK3O8E6ALenGIBLo9RwQblich/LUiz/LMS+e0MSL 0nQ8ySA5p5VIea4YHXAnJdgrqEy1n2r23q9naDExH8hmgw5Zd5GAUAvSPoCbuzb8C2pq58yV2m3LL IV4QFazntqZFJP97X4yaiDzyEES+CaWVxrpnZUxzRNp4Q5y5mPbA9dmDeWwDYuBbBa7fCXXZ2c4y2 Otkayrcqd5k68d2+rsTZrBsjKd6S0zr9atyEaZB53/DmULykS/ruB5od0d/EC8lwwIs9I5wQtf9LZ H5PwwuIQ==; To: Thomas Monjalon , dev@dpdk.org Cc: jerinj@marvell.com, David Marchand , Neil Horman , Timothy McDaniel References: <20210413084525.3057669-1-thomas@monjalon.net> From: "Kinsella, Ray" Message-ID: Date: Tue, 13 Apr 2021 17:09:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210413084525.3057669-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/04/2021 09:45, Thomas Monjalon wrote: > The eventdev driver DLB was removed in DPDK 21.05, > breaking the ABI check. > The exception was agreed so we just need to skip this check. > > Note: complete removal of a driver cannot be ignored > in devtools/libabigail.abignore, so the script must be patched. > > Fixes: 698fa829415d ("event/dlb: remove driver") > > Reported-by: David Marchand > Signed-off-by: Thomas Monjalon > --- > This should have been done as part of removing the driver. > The CI is currently broken, so it should be merged today. > --- > devtools/check-abi.sh | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh > index 9835e346da..ca523eb94c 100755 > --- a/devtools/check-abi.sh > +++ b/devtools/check-abi.sh > @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do > echo "Skipped glue library $name." > continue > fi > + if grep -qE "\ + echo "Skipped removed driver $name." > + continue > + fi So this is brute force fix - we can anticipate this problem happening again. Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?