From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14270A0547; Wed, 1 Jun 2022 20:51:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABCF240689; Wed, 1 Jun 2022 20:51:37 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2056.outbound.protection.outlook.com [40.107.93.56]) by mails.dpdk.org (Postfix) with ESMTP id 7611D4003F for ; Wed, 1 Jun 2022 20:51:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fc7rfyOSAgIdjQMlEt4EWisfT6HdLPtY4dZsnaMp8DbuALKlbu8AGJ7cab+7CEaIyFDlopNYmFtFESM3cyp+fzFrhV+gKYXa3Vko4qY3liOYA2DkU1VgRPVwlmt/ia8ygwA96gOF8dwFRQR2nMmaz/P6/z79GP+4qrOVUAP1UFDoxhvVKQZURxUdAejJFbqu6yd3hK1euRlNzKwCV0qJWcJ44+iPe3V8A0/mrhaUSsQFO3L+bKMc6wHzD4LMJLb7JYS8t063d5fE3iafglZT32lMh9MaRIgf+iPlwXUMk2fIlg1jilLvXZtH42ZuY/BZu3+p0QJzOxxpT2SF/TpBjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1vEgOeqdtIwSFAN9cR0jpH1ztnAOFLGsI0i8iHm3nZk=; b=gabpC1EXQS7o/Yke9YeUj818noli6GV8SrHkn1hvY36ClZQqwHgtBnzTet32fpxNoIFSADtDk2SkkDXoKU0ngiu9vBhcsjecUNjgX1hy0rwIBUeHYf6ZnbfezqZkPV7PqTjESMQIhgQ1o3kr8cpG6knqsG2S+Y8Mzv7eZi00cN4C26BWogHZBh6/EE/YP45mu6jFD9FlweWUl4lG7IL5yhITKnxkYpPzWdCmfISMjCgYIf3polAQBuZ5RwH13neGAikos/eENvuIPDEkzQfkOP5me53VHwEHdUZV3WhPdXGrOg2cXNw8CvriRmLLu2O3p70Kf/0FJ/bgDLBBzB65Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=nvidia.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1vEgOeqdtIwSFAN9cR0jpH1ztnAOFLGsI0i8iHm3nZk=; b=BOjzhhggPG/uMbMCBhRfoScLb+J2I7kQnhRaeY5OFlczGjrrnqf0nlIfe4R/XXhPJLNACrWEFASGCLyLQLX0MAte5CjnIE8V5YMQVn9BC272P6r1ZMNfuQ4wjvigMIN/Ni3hRQNt0ClBFeUVjhyy1TiyeJGmeVR3bFT4HKWNqPE= Received: from SN4PR0501CA0035.namprd05.prod.outlook.com (2603:10b6:803:40::48) by BN8PR02MB5956.namprd02.prod.outlook.com (2603:10b6:408:bc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Wed, 1 Jun 2022 18:51:33 +0000 Received: from SN1NAM02FT0051.eop-nam02.prod.protection.outlook.com (2603:10b6:803:40:cafe::a1) by SN4PR0501CA0035.outlook.office365.com (2603:10b6:803:40::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.5 via Frontend Transport; Wed, 1 Jun 2022 18:51:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0051.mail.protection.outlook.com (10.97.5.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5314.12 via Frontend Transport; Wed, 1 Jun 2022 18:51:32 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Jun 2022 19:51:30 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Jun 2022 19:51:30 +0100 Envelope-to: xiazhang@nvidia.com, orika@nvidia.com, xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, jiaweiw@nvidia.com, akozyrev@nvidia.com Received: from [10.71.119.118] (port=42053) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nwTRJ-0008Oe-Pu; Wed, 01 Jun 2022 19:51:30 +0100 Message-ID: Date: Wed, 1 Jun 2022 19:51:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [v1 1/4] ethdev: add IPv4/IPv6 ECN header rewrite action Content-Language: en-US To: Sean Zhang , Ori Kam , Xiaoyun Li , Aman Singh , Yuying Zhang , Thomas Monjalon , Andrew Rybchenko CC: , Jiawei Wang , Alexander Kozyrev References: <20220402071150.9392-1-xiazhang@nvidia.com> <20220402071150.9392-2-xiazhang@nvidia.com> From: Ferruh Yigit In-Reply-To: <20220402071150.9392-2-xiazhang@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f6c37cd-99f2-4e46-2f19-08da43ffbef2 X-MS-TrafficTypeDiagnostic: BN8PR02MB5956:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RfLdP+ZKWHfJbF3LbF5CWPdD9r+LlI/TElFPn4mnym97VyA9rI5ZxXL0b2dkXd1tTj4WxG8ZkX0vH1eYnc1D/sFTzRlAlLz7O+4rICTWq5t7jTCho1+LJWmDeTgotbBRYPWYXwIWdsFWIIEQRne+c+ne+VlgIB+UArd+kSgXdWm2JFlh0WjysyjvSNtAj85iTx4Yg00AmKAv+ngHi5BYK/Xx6evwCnVCDdRc++FyFqEEynwhxxIYeVCOtysGFB1D5ejXyEbJTDnLzOcIWFc8OpEXJX0oG5uF9BgdgwtM7vKT/XIPnPLtJmFoXcdbOO+gfsHmsiUce0ZQ+OlBNAFnPoeoHNJiTOeYE4+QuYslPZmfvN/u6NmXJ2P6GeuqZutxG8DrfqC/sfk1v70jCJX4f0BZ6Fqd5MOteSgYD1Jndrh+Qcl/vn6jV425ylU62gxULVzWZJ59gdl2+Hn6c8hohCsRV0DGwTA99b/kgUL5Ecl2VmCgpNbr6sLvKClrGCBE+d84SAfuA8hhnJA7a0jNt2zqCV75a3lGEZ9Md4r4nhQ+GDBNErGq8uyt5QsNSMxTbfg6H/TLjr2arLL1hW/t00866JaXakz+i4r90MlYGQOl7Tx4+sm/iD0dlxBgsC2jVBhTq1Jdum2xfKSxKOlQE5g/NAzpPErQHmY9FSfLVRovaeslNDoM/ES48SNL3JuKxX5UCrx2KYlrtvsBVqHmB9FUqgWODO5mRWL/r8XbIdU= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(31696002)(4326008)(70586007)(8676002)(70206006)(5660300002)(356005)(508600001)(7636003)(40460700003)(316002)(36860700001)(110136005)(54906003)(44832011)(186003)(2616005)(53546011)(6666004)(2906002)(26005)(8936002)(9786002)(36756003)(31686004)(83380400001)(47076005)(82310400005)(7416002)(426003)(336012)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 18:51:32.2954 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f6c37cd-99f2-4e46-2f19-08da43ffbef2 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0051.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR02MB5956 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/2/2022 8:11 AM, Sean Zhang wrote: > From: Jiawei Wang > > This patch introduces the IPv4/IPv6 ECN modify field support, and > adds the testpmd CLI commands support. > > Usage: > modify_field op set dst_type ipv4_ecn src_type ... > > For example: > > flow create 0 ingress group 1 pattern eth / ipv4 / end actions > modify_field op set dst_type ipv4_ecn src_type value src_value > 0x03 width 2 / queue index 0 / end > > Signed-off-by: Jiawei Wang > --- > app/test-pmd/cmdline_flow.c | 3 ++- > lib/ethdev/rte_flow.h | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index fc4a6d9cca..3250add834 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -795,7 +795,8 @@ static const char *const modify_field_ids[] = { > "tcp_seq_num", "tcp_ack_num", "tcp_flags", > "udp_port_src", "udp_port_dst", > "vxlan_vni", "geneve_vni", "gtp_teid", > - "tag", "mark", "meta", "pointer", "value", NULL > + "tag", "mark", "meta", "pointer", "value", > + "ipv4_ecn", "ipv6_ecn", NULL > }; > > /** Maximum number of subsequent tokens and arguments on the stack. */ > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index d8827dd184..1b56f23cba 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3690,6 +3690,8 @@ enum rte_flow_field_id { > RTE_FLOW_FIELD_META, /**< Metadata value. */ > RTE_FLOW_FIELD_POINTER, /**< Memory pointer. */ > RTE_FLOW_FIELD_VALUE, /**< Immediate value. */ > + RTE_FLOW_FIELD_IPV4_ECN, /**< IPv4 ECN. */ > + RTE_FLOW_FIELD_IPV6_ECN, /**< IPv6 ECN. */ > }; > > /** cc'ed Alexander. Patch looks good to me, only perhaps release notes can be updated, what do you think? @Ori, @Alex, do you have any objection/comment?