From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02A91A0C3F; Thu, 15 Apr 2021 17:32:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 935C516237E; Thu, 15 Apr 2021 17:32:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6744D16237B for ; Thu, 15 Apr 2021 17:32:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618500776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cluFziLJO5+yDhlR87maLOA7C2YheLVRhB80u0iycCw=; b=PhzGUm2yknObhiFA2IBAVRCU4ON13cQy5gTi+OkeqOdzbIW+01jpVB80OqtkXcTY2pgklt bEYKMBm1+B6Wq1R/KAW+n0iX5V834G5BDX5+IoRLEE+YGvQWXzraC4gGyriRUeQXkj1p1M iWpnBzrx6TqWiML9ZN67Dto1FJzVi/E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-VYT7jDzqORmaiyR4MnkiKw-1; Thu, 15 Apr 2021 11:32:54 -0400 X-MC-Unique: VYT7jDzqORmaiyR4MnkiKw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 25CC087A83E for ; Thu, 15 Apr 2021 15:32:51 +0000 (UTC) Received: from [10.36.110.28] (unknown [10.36.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AF321972B; Thu, 15 Apr 2021 15:32:50 +0000 (UTC) To: Balazs Nemeth , dev@dpdk.org References: <87be741c28c8d93a4cf93dc1af556cd4ead687ed.1617790501.git.bnemeth@redhat.com> From: Maxime Coquelin Message-ID: Date: Thu, 15 Apr 2021 17:32:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87be741c28c8d93a4cf93dc1af556cd4ead687ed.1617790501.git.bnemeth@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/4] vhost: allocate and free packets in bulk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/7/21 12:17 PM, Balazs Nemeth wrote: > Now that all allocation and freeing has been moved together, use the > faster bulk versions instead of handling packets one by one. > > Signed-off-by: Balazs Nemeth > --- > lib/librte_vhost/virtio_net.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c > index 496f750e3..2f0c97b91 100644 > --- a/lib/librte_vhost/virtio_net.c > +++ b/lib/librte_vhost/virtio_net.c > @@ -2469,10 +2469,10 @@ virtio_dev_tx_packed(struct virtio_net *dev, > { > uint32_t pkt_idx = 0; > uint32_t remained = count; > - uint16_t i; > > - for (i = 0; i < count; ++i) > - pkts[i] = rte_pktmbuf_alloc(mbuf_pool); > + if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts, count)) { > + return 0; > + } OK, get it now :) Maybe just add a comment in previous patches that it is going to be handled when moving to bulk allocation. > > do { > rte_prefetch0(&vq->desc_packed[vq->last_avail_idx]); > @@ -2497,8 +2497,9 @@ virtio_dev_tx_packed(struct virtio_net *dev, > > } while (remained); > > - for (i = pkt_idx; i < count; ++i) > - rte_pktmbuf_free(pkts[i]); > + if (pkt_idx != count) { > + rte_pktmbuf_free_bulk(&pkts[pkt_idx], count - pkt_idx); > + } > > if (vq->shadow_used_idx) { > do_data_copy_dequeue(vq); >