From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42C9544088; Tue, 21 May 2024 16:17:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C91C84028B; Tue, 21 May 2024 16:17:57 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2067.outbound.protection.outlook.com [40.107.94.67]) by mails.dpdk.org (Postfix) with ESMTP id 0F1364025C for <dev@dpdk.org>; Tue, 21 May 2024 16:17:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IbsJlwNDZbqbirkH4LHrLFuyJZDmt/izjAS+lQq9STGQiSIWqIDVl1U2pfqnUVzKdRIX3kACYe+KhHeonurVLRaYosqJ3OGkBiS8tb891bxq0E1DapR+kqSwkCARhF54jMQbtgni5HoWaOM6DNkj7V83Qo85DWSGYgjR9oi8udqehR0G3RB+VQ/vYulS0kg4kfPuA+sqXy8NfE0BNhSnD57wn0gns9K24DZwWlAHGBKexqB/M/hDyZ2o/oZS/RTLTRtbQ3HELJmuQq2piQyIBumBEtUT5rS2/3h945h2j2niBNT93b3V2bG2yjO3lEX1e/hJUVDgI/tz1b7TV8NioQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OBS4Dfo6TSbKc/y8bGeL5iu827rwktbBcd1e8hAoz8Y=; b=XngIZWLn3Ll1eZXRu56Gj04joVHBWEatlajWcqz8HOhFihwJS0h8YKRYk+iCgk8sMnz5zOviJWAOqcJ4j3TMZvptvbTK5Qz/LaUVmxZ29WEhwuALVt6MidB4vMABdnFJugIw+ckRXd2+1xD5MG/txKEUyYKeWwAQ5wnSmEJRASsDKA9RNLxMZ6qYt+6ht4RcaumYEQtm5PntdfYfCXgWgxL2ZNrhYmalu6haXJ8YlYj+00BKdC0tFRKFJY7iYFcrkLRoHOz9iwoBkLzcHGkNPgwW49oo6xg7sR3WmxY18blT3Vv0aqYMGeBQeDjZMwEGP6yzC2r69cEnjVoePe7Z9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OBS4Dfo6TSbKc/y8bGeL5iu827rwktbBcd1e8hAoz8Y=; b=ZRemPH5PAU2nZ7mqfU7L8fTsjd3pLavkd4pjultI5vkC98dG2yzDryYyiq/1sTV3VM+Hna/eTvzPP9yoedcn7he9oZgfO7F84mnyugfeRk5RTS+FzKpO0GkRhaA7YkHUJ0HRsynHqvuDGpt1XuBR/kJS0B4PXW6B2qKHjBsYeP0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM3PR12MB9328.namprd12.prod.outlook.com (2603:10b6:0:44::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Tue, 21 May 2024 14:17:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7587.035; Tue, 21 May 2024 14:17:51 +0000 Message-ID: <e8e8568e-e115-44fc-8e98-6c8540f5f76e@amd.com> Date: Tue, 21 May 2024 15:17:46 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 04/12] net/tap: validate and setup parameters for BPF RSS To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-5-stephen@networkplumber.org> <e00f3f03-0126-4808-b9dd-6d961fdf80d2@amd.com> <20240520190122.2469474a@hermes.local> Content-Language: en-US From: Ferruh Yigit <ferruh.yigit@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240520190122.2469474a@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0187.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM3PR12MB9328:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a483679-bdd8-4714-3d3a-08dc79a0cc70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OS9NL2ZQaTRmUEErMDg4eitJNXVnbTRJWTYwVVkzR3VFN2QxWlFMVnNROVdm?= =?utf-8?B?SkJhVTdZVVRNUldSZ2VQUTQxYUxSRkdYRTVKcE9TTldIY1BIQnZQYWRDc2RD?= =?utf-8?B?WXkzdGlwNUdSbXZRaktFcDM1eFd6R0NZZENBc2J4Sm41MlY5T3Zta0FnNThG?= =?utf-8?B?MFVPOWpiM1VQTHRhQnVjd21iZ2k1K2xZbVhkZVVqWVpsd2sydldLd24xN3cz?= =?utf-8?B?LzdEMWNYeDNtRVR6cENSOGg3WDNWenJPTVVta29xM2YwQW96Z05PZmtNRUxt?= =?utf-8?B?TUE4eDRQZ3FLRWhreHJVNnZCekFOZzdoSHk5T2RxdFVVdnE0eWlKVUgzOHhV?= =?utf-8?B?Nm1KaENwV0lWZ1NWMFJpaTlROUw4dkx4Q3F1N05WWmpIZURJOStqZCsyaUhZ?= =?utf-8?B?L1M2ZHEybW84UktqYi9oc3U3TU9qWml2NUx3QzUvemYzSEN6YWRJdUtaa3B6?= =?utf-8?B?QVJEWFF2ZW0wTDRqbWJlNk1DbUdEdlpHVWlRd2VjQ21BeHlib0I5S3loRnNC?= =?utf-8?B?NkJpSEZYb3lodktYMzJWNmdtSkNscmxTSEZjN0hCN0lIbDQ2ZU1rZTNPeFhV?= =?utf-8?B?S0V5T0hWZ1dSeC9TZm15K1JTOXlMenZqYXVjcU5Ccml1aml2dFFDTFBGODU1?= =?utf-8?B?OURmSWZaY3lMcUpsUjNJKzZSYzZaMnQ2U216eDlWOSt1dEJ1U2FUQ1gza3NH?= =?utf-8?B?OEhWYitad1ZRcENwenorb3ZkM05EUXF5U0l2b3k2R0c4K3hzQTFrSGZXcHhO?= =?utf-8?B?MWFRZFl4RlplbnVwamNndFZaaHhQR0svdnhFSGdZSFczbGM4VHprSEVRQzc0?= =?utf-8?B?TWlRM09hemxid1UxYmFHWWRBNnRtNk5UZTBTaHhuQ2lNd2tTZk5RT3ROdzVT?= =?utf-8?B?UVNlVFRUZVErbGdVSjQvaWFrRWVjQ3JQYWdSaDlxVVJ6ZVN6ODU5VmRyN1FD?= =?utf-8?B?VmtaWCtXOThJN2RGT3FTb2N6WFhidUpheFBSOWR4Y0VmS1htTkdacmt1aFRG?= =?utf-8?B?aFdDVEJOcGgrYStCUTB4TXZWbVBDNHhGTTNrczJMNFRydy9yYWg4TTJtQ1pa?= =?utf-8?B?VlhLc1l0MjFnYWdyd05IWCtqODJ6VGpQVzQxRGVDRXhKNUJsTk1UM2k3Sncx?= =?utf-8?B?NVUxeldIbUthM202WENpaE9JRS9DM2xHTzRGWkhiZitIYlZWODFObGlpZGNQ?= =?utf-8?B?Y0k0Tk5uMTEvcythdVVYT0wrTHdoYnBnSzZIUWNWTlU5OE5kbG1OOUViYmxt?= =?utf-8?B?eG1qK3Z4TkFvZ2JtYUVQbzZoWm5GU0tiSmE0NUhUWkV2d1hCRURRNk54UEpx?= =?utf-8?B?dS9FWWduSWZOTGsrTGRqdUdhOEM0NUt6RCsyNXIvMW9EekM2RklDZEJNaktO?= =?utf-8?B?cncyMWcrQ3FKTU1ERkJtRWthMldzOUtWS2c0YXRTMFVLWFVORFNybW1PN3VD?= =?utf-8?B?M0ZiTTdOM0RMNkNlMENXcDl4QWZzWGFkRjZ2QTNScU9reDFaWlFwMHl3VTA5?= =?utf-8?B?ZDFKR2NQeHd2TmhMeFFUYXo2bDdxa3ZEWUNFa0dLRFgrcTVKN25Ta1d6eGZK?= =?utf-8?B?aG9iSU9UUXJTWExPM3EwaDR0T3FNVlpwVndoajg4OGNzOXRUY2pLYWpsdDF2?= =?utf-8?B?QnNsdXQrSnlwNjkzSnBIam5naW8wS2M5eXdQVHFsS2dyQ1NFWXJ4SzRDblR0?= =?utf-8?B?UGdEMDJ5QzJFZFdiVldXVGExQTNYVTBNcERIWXRPU04xSHBaMVp2SGdBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WThyVzQrNXBMYklhOUJOZzVpK3hjL3FORmRFN2dZNTBuSzNaZmI5VXV6T0sw?= =?utf-8?B?VFVQVCtYRXNxNG9mMUp6Qkh4dllBZHF1cVhZajgvbmVzN0pzMTNDeUhwV21j?= =?utf-8?B?Z2J3QWI4NXFicmgzbnY1T3ZwaU52QndRaklTWUs1Sld4RWl4azJueFZjRGRs?= =?utf-8?B?TGhhT0dOcFVob05CMUZlWkllcTdnSmJEYjdlYlZsU0J3eTRlU21BZitudmpF?= =?utf-8?B?Ri9QU0RWVVpnd0lwalZJRTVvWUxDY2dyWXNRZU4vMEQ4cXFINmJJYVBpdGNm?= =?utf-8?B?eHFOL25iZTlEZ1RXenVMcXJFVStQdEZuM0VBcG5UbGl0aEgxK3FmSUNGbXJx?= =?utf-8?B?UXhrNjZWRUI3cUlTakZKeUFTbzFsNjZxS2doYnpJbjc5VmpLYmVEOUVQT1A2?= =?utf-8?B?azhrTjhCN1JvZkV2NUc1dmVPSzQ4TC85bVorYlR3RVp1K3FaVndlR0c2WGhw?= =?utf-8?B?SlJ4MlpiUHZzdTFvMzF0VVJWbnBpekswa2h6dUdGWUVqbHUxaVF6aTBSWVNu?= =?utf-8?B?a3lPNnRDUXR2b3N2b0dxNzAwVlYrdVdTMklycytZMmMyVnhBMjhtbm1lbXVH?= =?utf-8?B?VnBGN0FOM3YzQXM5VTE4MWxFclhMWXZROExmOS9NSXZnaHQ3dlhMaWtpcjNq?= =?utf-8?B?UWpob2Vndno1bnJ5SFpsR1ZPSDhBVVBYUkN3QUd5enFuSkNSb1lWVUNWbjBn?= =?utf-8?B?aWFIam1hT1dGYzRIYThJL0p6WDVvUzdFRWlsazF6c2dSY2kzZ1lXcjZOWmk3?= =?utf-8?B?RDU4RzY0akVvZ1lFTW80M1NoN0d2Zm1LT0oyUDUzOFJpOHhXNjE1aHhWaFVN?= =?utf-8?B?UWZ3ZnhKUm5YYnpRenZ6b1FXWXR6K2poUmt5Q2dEN1NTeE9wTkZNbHhBOExt?= =?utf-8?B?REYvQTJzWTU4WGhjSUNoM3lMdTdidVVzSEpWZHB3cTh0ZHlHUWZYNk5UeFlk?= =?utf-8?B?QjBYSzNmdkVhZVVKd2g1c0pkTmpkL1Y5VHd6Q3BjKzlOWm5kOTk2b3hvOGMv?= =?utf-8?B?NVlOWWNreWRObzBVejFMY3pMeWt2VkVPTlZ1QWw2ejRZUHZnOXQyVGM0TWZh?= =?utf-8?B?bitRTm8rMFlWbGxzdXJzUktBRzRpVUlaY1owTVdIUS9IY2liYWJVRGprdXdE?= =?utf-8?B?cHZrTHFoS0syNDhHbVlCN1c1a0ovNjVMNmIvSmFsZCsxTmIxZHQvcFozOWZ2?= =?utf-8?B?SnJRTTFLOUE5SDNocFBXeVNSZVVOTkVsUmYzTVJhcEJYRG9GNGJIcTBidkRu?= =?utf-8?B?MmJ6c25FdnRuNXpYSWlZRVJveEk0NUhvU1ZMOWZNOWphczd6YmcrUm9ybTJq?= =?utf-8?B?TjJrc1BnbjlQalVtWktYOG5nRCtJUkNSZU9SV21sM2o4b1BDVGJrMnVCb1ha?= =?utf-8?B?WFhtc1F1WldPS25UdUhTWnpnZlJ3dkhMaitVSUZYYXFCZEdnbXYyb3NCdGU3?= =?utf-8?B?TkZOTUcrTXZ5NHAwT0R2Q0ZFbDlXZEVHRHdGanBhbFR1SkJ0dVQ1MGZXNjZB?= =?utf-8?B?MEdwQmRjcDEvK0VkV0pCays0RmtKWWdNVTVRQTFUemcveS9hek9lVURET3NS?= =?utf-8?B?VjE2Zmg1ZmlUT2FmeGsxN1RsTUEvRjdSNnd0MzRYUUMyNVIwYmI0TGZEd1Vn?= =?utf-8?B?TWRpM1QyeDM4ZzZycnJEODNacVVEb1MraFBpQVpLYmNRN1ArL3poUDlXSFkw?= =?utf-8?B?TnJYbUxNZ2FGQ1crVms3ek9nVGthTjVIVkFCZkZmSWd5ZVoyNlczNnFHNjk5?= =?utf-8?B?dm55QmpDUmlrT0dZYThXc1kyaFYrdlJ2YmlMRWFqcW1xNWxRTEtKbG9ldjVw?= =?utf-8?B?b2NMZHNrK3JzKzc5c0FoSGU4bVdDa1VLQURheTF3VmxDV2RidVRKRXYrSjlX?= =?utf-8?B?SWNGOExRMjNhMUV0dTE4Uy9keFJMMVdQZjJGVjlOY2xKNG1WaGlReXdkMkwx?= =?utf-8?B?RjVOT0p1Y2Y4dk1BTzh4OSsxZmo5TVFpQVhzNjNZNEptYmE2UzJJRkR3MHNH?= =?utf-8?B?UUxsK1kyeXE3VUthaGlQbm9ZNjhEVmcxY0dTSjhzVVlWNWxJK2sySTdYZDc1?= =?utf-8?B?RmI0M2hHQ3NpNnltSXlzdXVBb3hPZnZUbWRpY1gzem9SbWpHQUxTcUp5Nngr?= =?utf-8?Q?mnkKEYuZt22CYdnbpLmgw/w3Y?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a483679-bdd8-4714-3d3a-08dc79a0cc70 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2024 14:17:51.3897 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Et22Nr5d5ynaUO0Epksx9VkRD3rbcTtdl2PsBEk2SaOj6p+tOc/cd6NHAHWFMdEZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB9328 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 5/21/2024 3:01 AM, Stephen Hemminger wrote: > On Mon, 20 May 2024 18:47:08 +0100 > Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >>> + >>> >> >> Why 'rte_convert_rss_key()' is required? Is this making an assumption on >> the CPU architecture? > > > What is happening here is that the key passed in is in cpu native > order, but the SW RSS algorithm needs it to be in big-endian to > work with IP protocols that are big-endian. > > In rte_thash the code to convert key is: rte_convert_rss_key() > and the code use the converted key is rte_softrss_be(). > > The BPF code doesn't (and cant easily because of license/validator) use the same > exact routine but it is equivalent to rte_softrss_be and uses pre-converted > key for performance. > got it, thanks for clarification. If there will be a new version, I think it helps others to add a comment before the call, up to you.