From: Sachin Saxena <sachin.saxena@oss.nxp.com> Dpaa2 pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com> --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 0e9f836e5..c91543131 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -241,7 +241,7 @@ dpaa2_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) PMD_INIT_FUNC_TRACE(); - dev_info->if_index = priv->hw_id; + dev_info->if_index = 0; dev_info->max_mac_addrs = priv->max_mac_filters; dev_info->max_rx_pktlen = DPAA2_MAX_RX_PKT_LEN; -- 2.28.0
On 9/11/2020 10:37 AM, Sachin Saxena (OSS) wrote:
> From: Sachin Saxena <sachin.saxena@oss.nxp.com>
>
> Dpaa2 pmd has no need to bound host interface
> for which we require if_index field.
> Setting it to 0 as unused.
>
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
> ---
> drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
> index 0e9f836e5..c91543131 100644
> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> @@ -241,7 +241,7 @@ dpaa2_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>
> PMD_INIT_FUNC_TRACE();
>
> - dev_info->if_index = priv->hw_id;
> + dev_info->if_index = 0;
>
Same here, I think assignment can be dropped completely.
From: Sachin Saxena <sachin.saxena@oss.nxp.com> Dpaa2 pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com> --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 0e9f836e5..02daa4d25 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -241,8 +241,6 @@ dpaa2_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) PMD_INIT_FUNC_TRACE(); - dev_info->if_index = priv->hw_id; - dev_info->max_mac_addrs = priv->max_mac_filters; dev_info->max_rx_pktlen = DPAA2_MAX_RX_PKT_LEN; dev_info->min_rx_bufsize = DPAA2_MIN_RX_BUF_SIZE; -- 2.28.0
On 9/14/2020 3:21 PM, Sachin Saxena (OSS) wrote:
> From: Sachin Saxena <sachin.saxena@oss.nxp.com>
>
> Dpaa2 pmd has no need to bound host interface
> for which we require if_index field.
> Setting it to 0 as unused.
>
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
Fixes: 3e5a335d3f88 ("net/dpaa2: add basic operations")
Cc: stable@dpdk.org
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.