From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6664A1B82B for ; Wed, 31 Jan 2018 20:18:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2018 11:18:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,441,1511856000"; d="scan'208";a="23930762" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.19.13]) ([10.252.19.13]) by FMSMGA003.fm.intel.com with ESMTP; 31 Jan 2018 11:18:43 -0800 To: Radu Nicolau , dev@dpdk.org Cc: mtetsuyah@gmail.com, declan.doherty@intel.com References: <1517235632-24080-1-git-send-email-radu.nicolau@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 31 Jan 2018 19:18:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1517235632-24080-1-git-send-email-radu.nicolau@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/null: add set MAC address dev op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 19:18:47 -0000 On 1/29/2018 2:20 PM, Radu Nicolau wrote: > Needed if used with net/bonding > > Signed-off-by: Radu Nicolau > --- > drivers/net/null/rte_eth_null.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index 7cd5c71..511e2b7 100644 > --- a/drivers/net/null/rte_eth_null.c > +++ b/drivers/net/null/rte_eth_null.c > @@ -456,6 +456,12 @@ eth_rss_hash_conf_get(struct rte_eth_dev *dev, > return 0; > } > > +static void > +eth_mac_address_set(struct rte_eth_dev *dev, struct ether_addr *addr) > +{ > + memcpy(dev->data->mac_addrs, addr, sizeof(struct ether_addr)); This copy already done in ethdev layer, an empty function will do the work. > +} > + > static const struct eth_dev_ops ops = { > .dev_start = eth_dev_start, > .dev_stop = eth_dev_stop, > @@ -466,6 +472,7 @@ static const struct eth_dev_ops ops = { > .rx_queue_release = eth_queue_release, > .tx_queue_release = eth_queue_release, > .link_update = eth_link_update, > + .mac_addr_set = eth_mac_address_set, > .stats_get = eth_stats_get, > .stats_reset = eth_stats_reset, > .reta_update = eth_rss_reta_update, >