From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DD3FA231E for ; Thu, 30 Aug 2018 11:09:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2018 02:09:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,306,1531810800"; d="scan'208";a="66288681" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.148]) ([10.237.220.148]) by fmsmga007.fm.intel.com with ESMTP; 30 Aug 2018 02:09:06 -0700 To: eric zhang , bruce.richardson@intel.com Cc: dev@dpdk.org, Allain.Legacy@windriver.com, Matt.Peters@windriver.com References: <1535558289-10336-1-git-send-email-eric.zhang@windriver.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 30 Aug 2018 10:09:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535558289-10336-1-git-send-email-eric.zhang@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2018 09:09:09 -0000 On 29-Aug-18 4:58 PM, eric zhang wrote: > This patch adds a configuration option to force the IOVA mode to > physical address (PA). There exists virtual devices that are not > directly attached to the PCI bus, and therefore the auto detection > of the IOVA mode based on probing the PCI bus and IOMMU configuration > may not report the required addressing mode. Having the configuration > option permits the mode to be explicitly configured in this scenario. > > Signed-off-by: eric zhang > --- Defining this at compile-time seems like an overkill. Wouldn't it be better to just add an EAL command-line option to force IOVA mode to a particular value? -- Thanks, Anatoly