From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D6E0C39EA for ; Thu, 16 Feb 2017 11:21:07 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Feb 2017 02:21:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,168,1484035200"; d="scan'208";a="65872284" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.0.57]) ([10.252.0.57]) by fmsmga005.fm.intel.com with ESMTP; 16 Feb 2017 02:21:05 -0800 To: Thomas Monjalon References: <20170214151326.7554-1-ferruh.yigit@intel.com> <20170215152632.25081-1-ferruh.yigit@intel.com> <20170215152632.25081-3-ferruh.yigit@intel.com> <371817936.VaZMuq7BCX@xps13> Cc: dev@dpdk.org, Bruce Richardson , John McNamara , Keith Wiles From: Ferruh Yigit Message-ID: Date: Thu, 16 Feb 2017 10:21:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <371817936.VaZMuq7BCX@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 3/4] mk: add new test-run make rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 10:21:08 -0000 On 2/16/2017 9:26 AM, Thomas Monjalon wrote: > 2017-02-15 15:26, Ferruh Yigit: >> --- a/mk/rte.sdkroot.mk >> +++ b/mk/rte.sdkroot.mk >> @@ -92,8 +92,8 @@ default: all >> config showconfigs showversion showversionum: >> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@ >> >> -.PHONY: test fast_test ring_test mempool_test perf_test coverage >> -test fast_test ring_test mempool_test perf_test coverage: >> +.PHONY: test test-run fast_test ring_test mempool_test perf_test coverage >> +test test-run fast_test ring_test mempool_test perf_test coverage: >> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@ > > "test" is a shortcut for build + basic tests. > I think test-run can be better named. It runs all the basic tests registered > in autotests. "test-all" would be wrong. What about "test-basic"? Right, "test-basic" matches more to existing rules (test-fast, test-perf, ..), all has hidden "run" action implied, I will use "test-basic" if there is no objection. My concerns is "test-basic" "running basic tests without compilation" may not be obvious for a newcomer. Should I add a line to "make help" for "test" and "test-*" rules? Like: test Compile tests and run basic unit tests test-* Run specific subset of the unit tests thanks, ferruh