From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6F4B85323; Wed, 14 Nov 2018 11:20:22 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2018 02:20:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,232,1539673200"; d="scan'208";a="104268115" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.124]) ([10.237.220.124]) by fmsmga002.fm.intel.com with ESMTP; 14 Nov 2018 02:20:08 -0800 To: Thomas Monjalon , "Varghese, Vipin" Cc: "dev@dpdk.org" , "Richardson, Bruce" , "stable@dpdk.org" , ferruh.yigit@intel.com References: <88cced4f601c44c6203b9adb09abacdce0b3a260.1542122595.git.anatoly.burakov@intel.com> <821e4582-5594-d291-6047-d6e5ba7b120f@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2BE984@BGSMSX101.gar.corp.intel.com> <2137402.5xZ7V9L5Yp@xps> From: "Burakov, Anatoly" Message-ID: Date: Wed, 14 Nov 2018 10:20:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2137402.5xZ7V9L5Yp@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 10:20:23 -0000 On 14-Nov-18 3:44 AM, Thomas Monjalon wrote: > 14/11/2018 04:24, Varghese, Vipin: >> Tested-by: Vipin Varghese >> >> >> >>>>> When creating process data structures, EAL will create many files in >>>>> EAL runtime directory. Because we allow multiple secondary processes >>>>> to run, each secondary process gets their own unique file. With many >>>>> secondary processes running and exiting on the system, runtime >>>>> directory will, over time, create enormous amounts of sockets, >>>>> fbarray files and other stuff that just sits there unused because the >>>>> process that allocated it has died a long time ago. This may lead to >>>>> exhaustion of disk (or RAM) space in the runtime directory. >>>>> >>>>> Fix this by removing every unlocked file at initialization that >>>>> matches either socket or fbarray naming convention. We cannot be sure >>>>> of any other files, so we'll leave them alone. Also, remove similar >>>>> code from mp socket code. >>>>> >>>>> We do it at the end of init, rather than at the beginning, because >>>>> secondary process will use primary process' data structures even if >>>>> the primary itself has died, and we don't want to remove those before >>>>> we lock them. >>>>> >>>>> Bugzilla ID: 106 >>>>> >>>>> Cc: stable@dpdk.org >>>>> >>>>> Reported-by: Vipin Varghese >>>>> >>>>> Signed-off-by: Anatoly Burakov >> >> Thanks Anatoly for the patch which clean-ups the tmpfs. This unblock the client from critical stopper too. >> >>>> >>>> I feel it is too big and too late for 18.11. >>>> Can we move it to 19.02? >>> >>> From maintainer's point of view, i agree that it's too risky to merge into 18.11 >>> at this stage. My input should probably stop there, but Vipin (the original bug >>> reporter) may have other thoughts on this matter. >> >> Hi Thomas, without the fix it affects both dpdk and non dpdk application use a host or VM. My suggestion to have the fix in and port to 18.11 LTS too. > > It is changing a behaviour. > I propose to test it on 19.02 and backport it in 18.11.1. > > Any other opinion? > That would probably be the best compromise IMO. -- Thanks, Anatoly