From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 13BA3201 for ; Fri, 10 Feb 2017 11:03:38 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2017 02:03:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,140,1484035200"; d="scan'208";a="223648735" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga004.fm.intel.com with ESMTP; 10 Feb 2017 02:03:36 -0800 To: Qi Zhang , helin.zhang@intel.com, jingjing.wu@intel.com References: <1486670573-5447-1-git-send-email-qi.z.zhang@intel.com> Cc: dev@dpdk.org, cunming.liang@intel.com From: Ferruh Yigit Message-ID: Date: Fri, 10 Feb 2017 10:03:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1486670573-5447-1-git-send-email-qi.z.zhang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix wrong handle when enable interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2017 10:03:39 -0000 On 2/9/2017 8:02 PM, Qi Zhang wrote: > In i40e_dev_interrupt_handler, when call rte_intr_enable, > We should parse dev->intr_handle but not intr_handle. > intr_handle is the copy of dev->intr_handle when > it is registered, but parameter of dev->intr_handle is > possible to be modifed later in i40e driver. If dev->intr_handle modified, shouldn't driver unregister old one and register new interrupt handle? Registering one handle but using another in handler function seems wrong. > > Fixes: 2ce7a1ed09fc ("net/i40e: localize mapping of ethdev to PCI device") > > Signed-off-by: Qi Zhang <...>