Re: [dpdk-dev] [PATCH v2 2/9] net/hns3: support Tx push quick doorbell to improve perf

["Min Hu (Connor)" <humin29@huawei.com>]

在 2021/3/12 2:05, Ferruh Yigit 写道:
> On 3/10/2021 6:16 AM, Min Hu (Connor) wrote:
>> From: Chengwen Feng <fengchengwen@huawei.com>
>>
>> Kunpeng 930 support Tx push mode which could improve performance, It
>> works like below:
>> 1. Add pcie bar45 which support driver direct write the Tx descriptor
>> or tail reg to it.
>> 2. Support three operations: a) direct write one Tx descriptor, b)
>> direct write two Tx descriptors, c) direct write tail reg.
>> 3. The original tail reg located at bar23, the above bar45 tail reg
>> could provide better bandwidth from the hardware perspective.
>>
>> The hns3 driver only support direct write tail reg (also have the name
>> of quick doorbell), the detail:
>> 1. Considering compatibility, firmware will report Tx push capa if the
>> hardware support it.
>> 2. Add control macro RTE_LIBRTE_HNS3_ENABLE_TX_PUSH which was not
>> defined default.
>> 3. If user define macro RTE_LIBRTE_HNS3_ENABLE_TX_PUSH and hardware
>> support, then driver will direct write bar45 tail reg to inform the
>> hardware.
> 
> Can you convert the copile time 'RTE_LIBRTE_HNS3_ENABLE_TX_PUSH' flag to 
> runtime device argument?
> 
> There is already 'tx_push_enable' variable check on datapath, so 
> converting to devarg shouldn't add any additional checks and shouldn't 
> have performance impact.
> 
After much thought, We choose to take the patch down from this patch 
set, because we want to take more test for this patch in new platform.

we will send the patch again in future.

   thanks
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> 
> <...>
> .