From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A3A5A0547; Fri, 12 Mar 2021 12:02:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EA8B406FF; Fri, 12 Mar 2021 12:02:32 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 006A34067E for ; Fri, 12 Mar 2021 12:02:30 +0100 (CET) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DxjXQ4GNdz8x30 for ; Fri, 12 Mar 2021 19:00:38 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Fri, 12 Mar 2021 19:02:26 +0800 To: Ferruh Yigit , References: <1615356985-24722-1-git-send-email-humin29@huawei.com> <1615356985-24722-3-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: Date: Fri, 12 Mar 2021 19:02:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 2/9] net/hns3: support Tx push quick doorbell to improve perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/3/12 2:05, Ferruh Yigit 写道: > On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> Kunpeng 930 support Tx push mode which could improve performance, It >> works like below: >> 1. Add pcie bar45 which support driver direct write the Tx descriptor >> or tail reg to it. >> 2. Support three operations: a) direct write one Tx descriptor, b) >> direct write two Tx descriptors, c) direct write tail reg. >> 3. The original tail reg located at bar23, the above bar45 tail reg >> could provide better bandwidth from the hardware perspective. >> >> The hns3 driver only support direct write tail reg (also have the name >> of quick doorbell), the detail: >> 1. Considering compatibility, firmware will report Tx push capa if the >> hardware support it. >> 2. Add control macro RTE_LIBRTE_HNS3_ENABLE_TX_PUSH which was not >> defined default. >> 3. If user define macro RTE_LIBRTE_HNS3_ENABLE_TX_PUSH and hardware >> support, then driver will direct write bar45 tail reg to inform the >> hardware. > > Can you convert the copile time 'RTE_LIBRTE_HNS3_ENABLE_TX_PUSH' flag to > runtime device argument? > > There is already 'tx_push_enable' variable check on datapath, so > converting to devarg shouldn't add any additional checks and shouldn't > have performance impact. > After much thought, We choose to take the patch down from this patch set, because we want to take more test for this patch in new platform. we will send the patch again in future. thanks >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Min Hu (Connor) > > <...> > .