From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54C9543C12; Wed, 28 Feb 2024 04:05:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EEB5402AC; Wed, 28 Feb 2024 04:05:32 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2074.outbound.protection.outlook.com [40.107.102.74]) by mails.dpdk.org (Postfix) with ESMTP id 763974027D; Wed, 28 Feb 2024 04:05:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OM3iPpKKbhI5ykgwNMgg8ceYxrF/K7BfO64rKGog2+AMPUB7Trz9YF0fsmsvAP5BzhTg3XMCI7IwB05N2XLgmDHrjZRiUvzqOsKakqbLe4InUr3CDc8dhFKHR9OxvB5NqPiw3z0nvmn9BI0rKtKxLAQNP+ef1+3U8FHZv4pYw/1GqVG5CmsYzfuqFOmW1pA4a83G+U0XP9UDNz+Dm4y+tbAI/JmYhsQQPvshmB5E8mwBV/M1GO/2HG5NKPL8EVGGrndAGFBlSHix/XBPiz94dIwqx4ZIznMb5MzuVYWloQMNqjBqlXJNHkKv4bFLAddfBQIiIyZ6uIyl12j9oB+xew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RwF6JR9127nDO+YuchUkVa85jbw3QjXg6L4nsl/PmzE=; b=DIvYppkd74pBmkRIQ4VfIuyeeCenUl7cXONRDQ4Db8j++hHlNiBqFYsCIgrLr5jBzEox7Rv/QtpeN7iSG1qebwnp7WsHw04gZ7dUFFFAAvPIxBwfQg1j9/LLYKy619HuFRq4eW4pfaTJz9Z/wZFAwN3a8izsLCVB6ecvPpvTrsznEUfwf4R3nZHQs8nlRB3jktfk3lrjsQglfr5l/JjmrcHK0tCnnNlqiFNl9LtuNK7pb84wNV0DdvVsnnlstRsD6qHE8FpvqdIOpOQVDdCTkn3C9M2WOxvfAQA8PnGH8k8Zc6PGaGCsciTgsmLbxTv2z+M6xPxfiV8iRQVzSe4Naw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RwF6JR9127nDO+YuchUkVa85jbw3QjXg6L4nsl/PmzE=; b=nnlhPITvWETib46N69RY78bfW4sYumgoyZW9OX8Wa1m6K08LA9ww0U+MWOX4yQ1OKiHB7bavTHdE+6D8tKdQqYOXOEEvCoGAsT0KiNv+HP+Yaq4HGyxHMROegyiRzIXEuUZDEdi1V9DOGsE9MZ3qCySSh2yFMbZ+V10EuYwolE4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) by DS0PR12MB8504.namprd12.prod.outlook.com (2603:10b6:8:155::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.34; Wed, 28 Feb 2024 03:05:28 +0000 Received: from PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::5f0d:af7:7f6b:9b9c]) by PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::5f0d:af7:7f6b:9b9c%5]) with mapi id 15.20.7316.035; Wed, 28 Feb 2024 03:05:28 +0000 Message-ID: Date: Wed, 28 Feb 2024 08:35:25 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/dma-perf: add average latency per worker Content-Language: en-US To: fengchengwen , dev@dpdk.org, stable@dpdk.org, honest.jiang@foxmail.com, gmuthukrishn@marvell.com, ferruh.yigit@amd.com References: <20231219164021.858-1-vipin.varghese@amd.com> <9acefd53-f617-28c1-1d6b-21b137d336eb@huawei.com> From: "Varghese, Vipin" In-Reply-To: <9acefd53-f617-28c1-1d6b-21b137d336eb@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0140.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:bf::12) To PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB8596:EE_|DS0PR12MB8504:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d4ffe9e-f32c-4e88-4274-08dc380a1dd3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cXUC5lNOO3/LGWFrnN1yxOw0PEYM07OP/YqlgKkPsfDZUFDJktVbxRYNDKkBY0Q7rxQdjuTSIWZDVyZKPHXmbThC1ZiPShTep8XU43Cx37d+3AxPWRM5T4dV2vl65+o3TYNqag1qq5m3t0gK37n4NPg0aNXkLzkXva+k4G4ZFcVtDtkot5y52f0MofbhE++R4zcA8UOgotJp8kGmmDdvIQLmOwqKBeHCrkvvZIfSsS+kKOZqxx1BnFBOeKW1/r3Qn/l4viBegAip03Xo5w38ffVBC7/bALaVL1izFdeEf45XOKW13JJb4hH3/iFutNg0lXUKfF7t0PfUqK7KcpERXD1ZmyFQMHI0vxyoO1k8UR9FJ6W9x6og6PYMMBqNFLhrIQaJNYposvgtMjKnZpfE2W4o9X1o9hs5t2xTpO5KyYtKAVPX/Ytlb685oqtc3hHubcmjxyCesD/pfsDud5wv4n17ymZpNBRt5UXfH0hIiCQrjzV5e2qqw0cJXBieS04v5KuDXdqQKsDzM8GU4P+AGS81QHY78y+O/hK9phdVLGaNSmg47Y5NMwJKFAdVvhgbwN22pvd5w349G7MiFiNb6hMGdDB1BJALMFxs1jfk4Rr1kYXKDmmXEl6BBqszcmou7KzuOwbJ7zzPspVL4te6s/OM7dJaZ2Eb4tKB1UdOkDQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB8596.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(230273577357003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VExSb0tMMmJOMkx6dXMzOFhJdDc5RkFPZVpYaTNueGRISU81cGlRVG41a29T?= =?utf-8?B?ZnJ2aEFoOXVLVjVXZ3dBZWdiVnNYa0FaV3RER3JJYUN2WXErT0FXSFhOdVBv?= =?utf-8?B?UlMzM1pWY2xzRlBwZCtzeFhsdDFKblU3ckFBd2RtWFRXU2NPOTlJVlgzN3N5?= =?utf-8?B?aHJFSm1DdUVDWGp2UERuZmtyZGNXcGlBd0lWdDBrYW0rdE5BZEhjUHBScEM1?= =?utf-8?B?ZjdJRFdZRzZDUTlmN2ZvUmc3VGhuL3dScXBnbmVKQUJDVWlXZC9oaEYzR0Nl?= =?utf-8?B?UGRHelBmSUc2am5xek1kM1kxUExHYzNpSWRZS3hGUmEzYW95ZFpMdVI5ZXJI?= =?utf-8?B?TWNQaXZHS3VXMVVrRWI5WW5VQXpLdFRJRmxhZXFNSXk5eC9sSFVmUURFWlhR?= =?utf-8?B?VEt3SHprQUo3b0k1UGVERHFpaGx5Y1FvQ0FXRmg2MnhWTGlVU3M4OE1DNitS?= =?utf-8?B?Rk9nTUZWNTF2M2ZaMXBXejVudU1vWEEvekQxb2hENEgvZy9BSmVhaU13N2Nv?= =?utf-8?B?aTlLUzFtaUI2OTZieUdqZ1czeUVsWkRKVjJCOVhldVgxWEExWmJVYUwxYXJQ?= =?utf-8?B?Ym1NTzFJQzFFNWVRTkVHRmhPVmxGMkxMTFI2Y3BZTFd5UDJjcEdVUG5qQ0U3?= =?utf-8?B?a285OVVJaWMzOE9OdWYrV3B2THViTUZtNS9PeTc1bHozMVQ0V3BsT1dtZ28x?= =?utf-8?B?dGkyR2NDN2p0K1lPMWo1dllxQzluQXZvZUhjdVhRVDhPeGdRR25jWkw0QllN?= =?utf-8?B?anJQbGV0ZjQyMEF0cy84d1h0VTBYN3lBbDlnelNuUXI4V0Zlb2EwcG9haWlE?= =?utf-8?B?Q2hCSU0rUDR3OWpRS0h3a0V6cHV3WS9wNWN4SlByeDY5Z0huZno2RmlLeFVP?= =?utf-8?B?OFFPc0MwQU4zeUYrN1Jma0YwMFBsVHNYT3dYRFAzeGVwTHBDVDJtbnlickF4?= =?utf-8?B?OVN0am9WZ25iNWRCNTJmRzBWQkdhL281VUlUQU5DZDR1OFRZcjVWdTNoTW9w?= =?utf-8?B?c0t6RFg4SFErRGkvc1ZRQVZJbXZFNlRNd2xLa3hkMFlzNDEycnNLamNCOXE1?= =?utf-8?B?N0NXUzByQkgvekt2alZNRGlpMXBaazJ1V2RUUWE5RFF5L01DRDRBa0V6YXBw?= =?utf-8?B?NVorRTFrVUJSNUlPZndsclEwSkN1RFZQM1daY3ppaU9uaHRvUThvNjk4K1ZW?= =?utf-8?B?SGk5R0lnZ0dCbnRFeUJ4VklFejMza2lmWTRNTkdVYkVhcXNxWDBWci9GYjBp?= =?utf-8?B?VVpMSHVqb21RczVXMTZIOWUyUGdWQzEzY0dHMFcya28rVGtZV0FKUnUxaHI4?= =?utf-8?B?azZjaXF5eUk5QjV2UVVoNGNPVjhFN3BqbkJIbVhvS0VzVjlVSmNZMlN1eG42?= =?utf-8?B?SHhiVnpwVE5vcUZjSm1rd1dEVU42VE8wdnI3bG0xY2JzZTlLWVYrWHZyWkFw?= =?utf-8?B?ZkhDQ3ROdjZXdkdNeWdCRGhCcVdMOXljQXk0ckdSdkRBbStDY2QvblVmRlVt?= =?utf-8?B?b3dOUlB6c3JVWWIwd01nVWhHelNxRFFsSUhNZERiNmxIYm5lcEMyRVRrV2pE?= =?utf-8?B?MFBsaTdjQWFQTkM5TE1XU2wvYnhzb1VGSkhSa1g4d01DeUdwVk0wUkhVcHVD?= =?utf-8?B?a21LOVExcmxucngzSVQ3L3JtUjZZRHFIcEQ4MXpFTnM2ckNzQnE0cnlMTjhS?= =?utf-8?B?eGJKUzdPaC83dVNxZjBCekpMeWJzMFJNUlJuRW9iMDRBZkoxVExwdlpnVzJ5?= =?utf-8?B?ckVCL3RBdi9XdmdaaTRDOHduR0pwR2tqSXVwNWlBbklIQTJiTTFvOCtjWExa?= =?utf-8?B?Q2tmWjJBcVZqNkFRcm50WWh4L2VQa0ZCa1k5b09ZZENsaEtHZjM3UGVYNzNy?= =?utf-8?B?TmJTZ2FqK1A0blJ2RWFtbm12Tm50WXFsQjQrM1dDeXJnQS9DbmIyNVFBUmVq?= =?utf-8?B?V3cxVnZNQzNvSDFpYXd4L29KUDVxUzVhS0EzaXBrVzhCZ3hmd21qVXFldzZZ?= =?utf-8?B?ZGJnMTEwdjlMV0w2MzkvV254V1dURDFIak9naTlncGluWWhxenpVOHcwaExU?= =?utf-8?B?WFVzcUdKWGxmcUlmVnpwbHpweUtDTGR3UktPai9qVWVkeWFPZVNndzRlVzlW?= =?utf-8?Q?usk6aH6sW9k6JSAp8pw2kzeha?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d4ffe9e-f32c-4e88-4274-08dc380a1dd3 X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB8596.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 03:05:28.2277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4VnBu5aI9U4NtTEuSYSv+we/6haSYUxVKrokg3evLwD7TtUrjSKsugIMC+7mhSMQsnZijkEfRgMKSDjd/X1BQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8504 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2024 3:15 PM, fengchengwen wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > Hi Vipin, > > On 2023/12/20 0:40, Vipin Varghese wrote: >> Modify the user display data with total average latency per worker. >> >> Signed-off-by: Vipin Varghese >> --- >> app/test-dma-perf/benchmark.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c >> index 9b1f58c78c..8b6886af62 100644 >> --- a/app/test-dma-perf/benchmark.c >> +++ b/app/test-dma-perf/benchmark.c >> @@ -470,7 +470,8 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma) >> bandwidth_total += bandwidth; >> avg_cycles_total += avg_cycles; >> } >> - printf("\nTotal Bandwidth: %.3lf Gbps, Total MOps: %.3lf\n", bandwidth_total, mops_total); >> + printf("\nAverage Cycles/op: %.2lf, Total Bandwidth: %.3lf Gbps, Total MOps: %.3lf\n", >> + (float) avg_cycles_total / nb_workers, bandwidth_total, mops_total); > Because this is total stats, suggest add Total prefix, e.g. "Total Average Cycles/op" > > I think print format keep one-digit precision is enough. Also please modify CSV_TOTAL_LINE_FMT > make sure the csv also have same precision of Cycles/op. Thank you Chengwen, let me share v2 shortly. > > Thanks > >> snprintf(output_str[MAX_WORKER_NB], MAX_OUTPUT_STR_LEN, CSV_TOTAL_LINE_FMT, >> cfg->scenario_id, nr_buf, memory * nb_workers, >> avg_cycles_total / nb_workers, bandwidth_total, mops_total); >>