From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADD09A09E4; Fri, 29 Jan 2021 10:19:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4462824011B; Fri, 29 Jan 2021 10:19:42 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id C6DFC40694 for ; Fri, 29 Jan 2021 10:19:39 +0100 (CET) IronPort-SDR: xRZAMzt4PysZ3/kTDblTJ2WUIN3btdq5gce+lPtYQ+hDxMTMlGDCZlbbsWmO6isDb6Nsi4qKew XWwXF5Vydsbg== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="176886706" X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="176886706" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 01:19:38 -0800 IronPort-SDR: 6ibKJ+qkKjgf4GSYPNpFnfL7Hi38cPFB3M8dn3uUxz10+YdvXs4vIRG1h5oalMz/2sKFFkHx87 lgxh7AO3XCFQ== X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="389227898" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.204]) ([10.213.197.204]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 01:19:35 -0800 To: Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru , Anatoly Burakov Cc: jerinj@marvell.com, sburla@marvell.com, dev@dpdk.org References: <20210128152220.214485-1-pnalla@marvell.com> <20210129001640.1251-5-pnalla@marvell.com> From: Ferruh Yigit Message-ID: Date: Fri, 29 Jan 2021 09:19:32 +0000 MIME-Version: 1.0 In-Reply-To: <20210129001640.1251-5-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6 04/12] net/octeontx_ep: add device init and uninit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/29/2021 12:16 AM, Nalla Pradeep wrote: > Add basic init and uninit function which includes > initializing fields of ethdev private structure. > > Signed-off-by: Nalla Pradeep <...> > @@ -43,6 +104,7 @@ otx_ep_eth_dev_pci_remove(struct rte_pci_device *pci_dev) > /* Set of PCI devices this driver supports */ > static const struct rte_pci_id pci_id_otx_ep_map[] = { > { RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_OCTEONTX_EP_VF) }, > + { RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_OCTEONTX2_EP_NET_VF) }, Can you please move this to 3/12 where 'pci_id_otx_ep_map' is introduced? > { RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_CN98XX_EP_NET_VF) }, > { .vendor_id = 0, /* sentinel */ } > }; > @@ -57,3 +119,6 @@ static struct rte_pci_driver rte_otx_ep_pmd = { > RTE_PMD_REGISTER_PCI(net_otx_ep, rte_otx_ep_pmd); > RTE_PMD_REGISTER_PCI_TABLE(net_otx_ep, pci_id_otx_ep_map); > RTE_PMD_REGISTER_KMOD_DEP(net_otx_ep, "* igb_uio | vfio-pci"); > +RTE_LOG_REGISTER(otx_net_ep_logdbg, pmd.net.octeontx_ep, DEBUG); > +RTE_LOG_REGISTER(otx_net_ep_logerr, pmd.net.octeontx_ep, ERR); > +RTE_LOG_REGISTER(otx_net_ep_loginfo, pmd.net.octeontx_ep, INFO); > This is wrong. You should register single logtype, as done in v5, and use for various log levels. Please make the default log level for registered logtype 'NOTICE' (again as done in v5) The macros 'otx_ep_info', 'otx_ep_err' & 'otx_ep_dbg' should share same logtype.