From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 770DEFEB for ; Tue, 30 Oct 2018 11:26:52 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD7EA3164683; Tue, 30 Oct 2018 10:26:51 +0000 (UTC) Received: from [10.36.112.50] (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58B6160BE7; Tue, 30 Oct 2018 10:26:50 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org References: <20181029052808.16520-1-tiwei.bie@intel.com> <20181029052808.16520-6-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Tue, 30 Oct 2018 11:26:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181029052808.16520-6-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 30 Oct 2018 10:26:51 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 5/6] net/virtio-user: simplify device features preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 10:26:52 -0000 On 10/29/18 6:28 AM, Tiwei Bie wrote: > Get rid of the duplicated code in device features preparation > which looks awful. > > Signed-off-by: Tiwei Bie > --- > .../net/virtio/virtio_user/virtio_user_dev.c | 31 +++++++------------ > 1 file changed, 11 insertions(+), 20 deletions(-) Welcomed cleanup! Reviewed-by: Maxime Coquelin Thanks, Maxime