From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DEFBA04DB; Thu, 15 Oct 2020 17:33:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 649FE1EB2B; Thu, 15 Oct 2020 17:32:40 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 247A41EB25 for ; Thu, 15 Oct 2020 17:32:38 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id e18so4019808wrw.9 for ; Thu, 15 Oct 2020 08:32:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=GhF4eht96pJIPWb7nVL0mwyZak9Njm6nWxJ5wgB3FR4=; b=X079dw+sOKjv2PV2fq1xCmNiCGI3m5e8AkGykrCs+DtYNbxQ1OthAIjCtyMnalmtQW S0J8cz79mO0S3teyFtCppcNzD0j9vpj1fWyubPSKUstk4a0D9zjG0Fajx33X6jCIJNN4 ou3XIBoNXzsnepSXbL0G9+mTFakUorx0UGRzygG0OrBZy1IgLXVmhb2dPfxLsiGBJbhi 1SjAmE6pWe2Gj0mTW4gB/LmS4Pv5ko2nYx+diS288SwLDrEHcyMHwp5iouPw+K/Vramj JUi+Ivt5Se0qHhZU4sOezIlBCt8czFe4nQKaLJm2MCdn+JRUKrQeF8UIg+zntvFdEhQO AYLw== X-Gm-Message-State: AOAM533v/FVuq/ueC4JXFPCUDEbw4Pb9yTJygaPFDcayqlh4kXGngx8V a9XRCYyivsLxTVEorPOhztfdCunGvfZr5Q== X-Google-Smtp-Source: ABdhPJzTUyynHSU7eZBgZsaf0kBq5B0YYoA1bZmzPo8NZMwL9USz47srJm4LY4+PuxLdtD9NTtjKtw== X-Received: by 2002:a5d:4ed2:: with SMTP id s18mr4998803wrv.36.1602775956814; Thu, 15 Oct 2020 08:32:36 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id y14sm4742080wma.48.2020.10.15.08.32.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 08:32:35 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, arybchenko@solarflare.com, ferruh.yigit@intel.com, thomas@monjalon.net Date: Thu, 15 Oct 2020 16:32:35 +0100 In-Reply-To: <20201015140312.GD554@bricha3-MOBL.ger.corp.intel.com> References: <20200916164429.244847-1-bruce.richardson@intel.com> <20201014141304.632120-1-bruce.richardson@intel.com> <20201014141304.632120-7-bruce.richardson@intel.com> <431a3c639870949ee8c62a6e2ab9d3a1bd567d0f.camel@debian.org> <20201015111839.GB554@bricha3-MOBL.ger.corp.intel.com> <7dc47047bf543a0f239a1c07b3b0c67158271ba3.camel@debian.org> <20201015140312.GD554@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 6/7] build: standardize component names and defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2020-10-15 at 15:03 +0100, Bruce Richardson wrote: > On Thu, Oct 15, 2020 at 02:05:37PM +0100, Luca Boccassi wrote: > > On Thu, 2020-10-15 at 12:18 +0100, Bruce Richardson wrote: > > > On Thu, Oct 15, 2020 at 11:30:29AM +0100, Luca Boccassi wrote: > > > > On Wed, 2020-10-14 at 15:13 +0100, Bruce Richardson wrote: > > > > > As discussed on the dpdk-dev mailing list[1], we can make some ea= sy > > > > > improvements in standardizing the naming of the various component= s in DPDK, > > > > > and their associated feature-enabled macros. > > > > >=20 > > > > > Following this patch, each library will have the name in format, > > > > > 'librte_.so', and the macro indicating that library is enab= led in the > > > > > build will have the form 'RTE_LIB_'. > > > > >=20 > > > > > Similarly, for libraries, the equivalent name formats and macros = are: > > > > > 'librte__.so' and 'RTE__', where class = is the > > > > > device type taken from the relevant driver subdirectory name, i.e= . 'net', > > > > > 'crypto' etc. > > > > >=20 > > > > > To avoid too many changes at once for end applications, the old m= acro names > > > > > will still be provided in the build in this release, but will be = removed > > > > > subsequently. > > > > >=20 > > > > > Signed-off-by: Bruce Richardson > > > > >=20 > > > > > [1] http://inbox.dpdk.org/dev/ef7c1a87-79ab-e405-4202-39b7ad6b0c7= 1@solarflare.com/t/#u > > > > > --- > > > > > app/test-bbdev/meson.build | 4 ++-- > > > > > app/test-crypto-perf/meson.build | 2 +- > > > > > app/test-pmd/meson.build | 12 ++++++------ > > > > > app/test/meson.build | 8 ++++---- > > > > > doc/guides/rel_notes/deprecation.rst | 8 ++++++++ > > > > > drivers/baseband/meson.build | 1 - > > > > > drivers/bus/meson.build | 1 - > > > > > drivers/common/meson.build | 1 - > > > > > drivers/common/mlx5/meson.build | 1 - > > > > > drivers/common/qat/meson.build | 1 - > > > > > drivers/compress/meson.build | 1 - > > > > > drivers/compress/octeontx/meson.build | 2 +- > > > > > drivers/crypto/meson.build | 1 - > > > > > drivers/crypto/null/meson.build | 2 +- > > > > > drivers/crypto/octeontx/meson.build | 2 +- > > > > > drivers/crypto/octeontx2/meson.build | 2 +- > > > > > drivers/crypto/scheduler/meson.build | 2 +- > > > > > drivers/crypto/virtio/meson.build | 2 +- > > > > > drivers/event/dpaa/meson.build | 2 +- > > > > > drivers/event/dpaa2/meson.build | 2 +- > > > > > drivers/event/meson.build | 1 - > > > > > drivers/event/octeontx/meson.build | 2 +- > > > > > drivers/event/octeontx2/meson.build | 2 +- > > > > > drivers/mempool/meson.build | 1 - > > > > > drivers/meson.build | 9 ++++----- > > > > > drivers/net/meson.build | 1 - > > > > > drivers/net/mlx4/meson.build | 2 +- > > > > > drivers/raw/ifpga/meson.build | 2 +- > > > > > drivers/raw/meson.build | 1 - > > > > > drivers/regex/meson.build | 1 - > > > > > drivers/vdpa/meson.build | 1 - > > > > > examples/bond/meson.build | 2 +- > > > > > examples/ethtool/meson.build | 2 +- > > > > > examples/ioat/meson.build | 2 +- > > > > > examples/l2fwd-crypto/meson.build | 2 +- > > > > > examples/ntb/meson.build | 2 +- > > > > > examples/vm_power_manager/meson.build | 6 +++--- > > > > > lib/librte_ethdev/meson.build | 1 - > > > > > lib/librte_graph/meson.build | 2 -- > > > > > lib/meson.build | 3 ++- > > > > > 40 files changed, 47 insertions(+), 55 deletions(-) > > > >=20 > > > > Does this change the share object file names too, or only the macro= s? > > > >=20 > > >=20 > > > It does indeed change the object name files, which is a little bit > > > concerning. However, the consensus based on the RFC seemed to be that= the > > > benefit is likely worth the change. If we want, we can look to use sy= mlinks > > > to the old names on install, but I think that just delays the pain si= nce I > > > would expect few to actually change their build to the new names unti= l the > > > old ones and the symlinks completely go away. > > >=20 > > > /Bruce > >=20 > > It is a backward incompatible change, so we need to provide symlinks, > > right? On upgrade, programs linked to librte_old.so will fail to start. > > Or was this targeted at 20.11 thus piggy-backing on the ABI change > > which forces a re-link? > >=20 > More of the latter, and the fact that changing the build system involved = a > few library renames anyway for those using make. Since the ABI is changin= g > this release, and all the libs have a new major version number there is n= o > requirement for libs linked against an older version to work, and since > pkg-config should now be used for linking the actual names should not be > a concern. >=20 > That's the thinking anyway. :-) >=20 > /Bruce Ok that makes sense, I wasn't sure if this series was targeted for 20.11 or for later. In that case, Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi