From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9917A0518; Fri, 24 Jul 2020 10:55:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59E4D1C012; Fri, 24 Jul 2020 10:55:18 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 341841C010 for ; Fri, 24 Jul 2020 10:55:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595580916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NoT2Qr1HNydUdDci0lgg//KN1+bvfyTi+BpEJySbw5E=; b=DdKD/JaePZJA6NkZJvFmGETKRQCHzwbdO/0Yd22BESotjFeoCsK7N+Mvb+7L9Yn8Sx0Te9 +Pq49cUO7438inMVjCbZnfsZVJrK5mLn7323Y5ELPzSqCqiOYILO89p0nMAq3i+cCFjSvv BHHXed9cxEjPGagpt6sTbUJ6Af+viDQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-9fswuPFrOtKWyMPSR_zjiw-1; Fri, 24 Jul 2020 04:55:03 -0400 X-MC-Unique: 9fswuPFrOtKWyMPSR_zjiw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2E35E1932481; Fri, 24 Jul 2020 08:55:02 +0000 (UTC) Received: from [10.36.110.21] (unknown [10.36.110.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10EAF71D24; Fri, 24 Jul 2020 08:54:57 +0000 (UTC) From: Maxime Coquelin To: "Wang, Yinan" , "dev@dpdk.org" , "matan@mellanox.com" , "Xia, Chenbo" , "Liu, Yong" Cc: "thomas@monjalon.net" , "Yigit, Ferruh" , "david.marchand@redhat.com" References: <20200723130854.322771-1-maxime.coquelin@redhat.com> <5a8329d8-4835-de6b-bce3-498b587c3cc9@redhat.com> Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Fri, 24 Jul 2020 10:54:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <5a8329d8-4835-de6b-bce3-498b587c3cc9@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/2] Fix vhost performance regression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/24/20 9:06 AM, Maxime Coquelin wrote: > Hi Yinan, > > On 7/24/20 6:55 AM, Wang, Yinan wrote: >> Hi Maxime, >> >> The performance drop issue can be fixed, thanks! >> The multi-queues interrupt issue still exist w/ this patch set. > > Thanks for the test report, so that's only half good. > I'm setting up the multi-queues interrupt test case to further debug it. I have now a reproducer, i.e. only interrupts are received on rxq0. (gdb) p *((struct internal_list *)internal_list)->eth_dev->intr_handle $20 = { { vfio_dev_fd = 0, uio_cfg_fd = 0 }, fd = 0, type = RTE_INTR_HANDLE_VDEV, max_intr = 2, nb_efd = 1, efd_counter_size = 8 '\b', efds = {622, 621, 624, 626, 628, 630, 632, 634, 636, 638, 640, 642, 692, 646, 701, 650, 0 }, elist = {{ status = 1, fd = 622, epfd = 645, epdata = { event = 2147483651, data = 0x1, cb_fun = 0x8af840 , cb_arg = 0x7f4df0001580 } }, { status = 0, fd = 0, epfd = 0, epdata = { event = 0, data = 0x0, cb_fun = 0x0, cb_arg = 0x0 } } }, intr_vec = 0x7f4df0007db0 } In above dump, we can see the efds are well set via the fix provided by Matan, but max_intr and nb_efd aren't so polling won't take them into account. I'm working on a fix. Regards, Maxime > Regards, > Maxime > >> BR, >> Yinan >> >>> -----Original Message----- >>> From: Maxime Coquelin >>> Sent: 2020?7?23? 21:09 >>> To: dev@dpdk.org; matan@mellanox.com; Xia, Chenbo >>> ; Liu, Yong ; Wang, Yinan >>> >>> Cc: thomas@monjalon.net; Yigit, Ferruh ; >>> david.marchand@redhat.com; Maxime Coquelin >>> >>> Subject: [PATCH 0/2] Fix vhost performance regression >>> >>> Hi, >>> >>> This series aims at fixing the performance degradation reported >>> by Intel QE. I managed to reproduce the issue, and this series >>> fixes it. >>> >>> I only tested the first test case provided in the Bz[0], but wanted >>> to send early for Intel QE to try and confirm it solves the issue. >>> >>> I will work on reproducing the other test cases, and see if this >>> also fixes them. >>> >>> Thanks to Intel QE team for finding this issue. >>> Maxime >>> >>> [0]: https://bugs.dpdk.org/show_bug.cgi?id=507#c0 >>> >>> Maxime Coquelin (2): >>> vhost: fix guest notification setting >>> net/vhost: fix queue update >>> >>> drivers/net/vhost/rte_eth_vhost.c | 25 ++++++------------------- >>> lib/librte_vhost/vhost.c | 24 ++++++++++++++++++++---- >>> lib/librte_vhost/vhost.h | 5 +++++ >>> lib/librte_vhost/vhost_user.c | 11 ++++++++--- >>> 4 files changed, 39 insertions(+), 26 deletions(-) >>> >>> -- >>> 2.26.2 >> >