From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BADDA04C8; Sat, 19 Sep 2020 10:45:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 06E191D991; Sat, 19 Sep 2020 10:45:14 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 8C1BE1D949 for ; Sat, 19 Sep 2020 10:45:12 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.150]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 308B82004E; Sat, 19 Sep 2020 08:45:12 +0000 (UTC) Received: from us4-mdac16-24.at1.mdlocal (unknown [10.110.49.206]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 2EFF7800A3; Sat, 19 Sep 2020 08:45:12 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.32]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id BDAF110004F; Sat, 19 Sep 2020 08:45:11 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 704F8280063; Sat, 19 Sep 2020 08:45:11 +0000 (UTC) Received: from [127.0.0.27] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 19 Sep 2020 09:45:04 +0100 To: Ajit Khaparde , "Ananyev, Konstantin" CC: "Min Hu (Connor)" , "dev@dpdk.org" , "thomas@monjalon.net" , "Yigit, Ferruh" , "linuxarm@huawei.com" References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1600429707-6879-1-git-send-email-humin29@huawei.com> <1600429707-6879-2-git-send-email-humin29@huawei.com> From: Andrew Rybchenko Message-ID: Date: Sat, 19 Sep 2020 11:44:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25674.003 X-TM-AS-Result: No-10.088200-8.000000-10 X-TMASE-MatchedRID: fE0JoqABJp3mLzc6AOD8DfHkpkyUphL90Y5wB8cprq75+tteD5RzhVem QtpKzZIz2qLJOCm+Gy+7oI/ypOeHzpcvKjLILi9VLbjXqdzdtCXR+aCnUtmPaMZltfe/nRavL/y d2jgNiCPeTHPmCCrjc85gLQgIAFB+qZWpk+GKRVPZ+i/tPCEvyW4gOG7cxxfb33Nl3elSfspo8w ucTFrANXH2JbN7IgBCClmN4J93B65yOVk+FPzL16JVTu7sjgg1rkGhd90/DD4XOKW+DiYK9uaI/ 0WlF413pEYBIO560cqv8TAvJrvuV3Ho2p42VhyY2zNZ+bvs0+vQevMKEpazy8O/l0Ny5PZ5VS7h 0xs0g5nMlqxW2sAwJZnXzeukfgq6rYdEhLwunNSdOp1TjDrlaRi5JnKa1HKDmyiLZetSf8nJ4y0 wP1A6AAOkBnb8H8GWp5scLHMFXhOyO81X3yak83brIcBCF+W7psmwHRvMF38nS9tYvdjlIKxuTC 5wrXjoh5a3ucslkNNV3hxHgsz1KZQp1EgPlg1vNfry/3NIRS8GYTwUUA/63Q== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--10.088200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25674.003 X-MDID: 1600505112-dF4xnqcstZyK Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH V7 1/3] ethdev: introduce FEC API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/18/20 9:10 PM, Ajit Khaparde wrote: > On Fri, Sep 18, 2020 at 5:13 AM Ananyev, Konstantin > wrote: >> >>> This patch adds Forward error correction(FEC) support for ethdev. >>> Introduce APIs which support query and config FEC information in >>> hardware. >>> >>> Signed-off-by: Min Hu (Connor) >>> Reviewed-by: Wei Hu (Xavier) >>> Reviewed-by: Chengwen Feng >>> Reviewed-by: Chengchang Tang >>> --- >>> v6->v7: >>> deleted RTE_ETH_FEC_NUM to prevent ABI breakage. >>> add new macro to indicate translation from fec mode >>> to capa. >>> >>> --- >>> v5->v6: >>> modified release notes. >>> deleted check duplicated for FEC API >>> fixed code styles according to DPDK coding style. >>> added _eth prefix. >>> >>> --- >>> v4->v5: >>> Modifies FEC capa definitions using macros. >>> Add RTE_ prefix for public FEC mode enum. >>> add release notes about FEC for dpdk20_11. >>> >>> --- >>> v2->v3: >>> add function return value "-ENOTSUP" for API >>> >>> --- >> Acked-by: Konstantin Ananyev > Reviewed-by: Ajit Khaparde I'm sorry, but I'm still unhappy with enum members order and get capabilities API. See v5 notes.