From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B784CA0564; Fri, 12 Mar 2021 01:59:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C2BF4067E; Fri, 12 Mar 2021 01:59:42 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id ADA724014D for ; Fri, 12 Mar 2021 01:59:40 +0100 (CET) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DxS8K158pzNlbK; Fri, 12 Mar 2021 08:57:21 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Fri, 12 Mar 2021 08:59:35 +0800 To: Ferruh Yigit , CC: Ciara Power , David Marchand References: <1615356985-24722-1-git-send-email-humin29@huawei.com> <1615356985-24722-2-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: Date: Fri, 12 Mar 2021 08:59:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 1/9] net/hns3: support runtime config to select IO burst func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/3/12 1:31, Ferruh Yigit 写道: > On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> Currently, the driver support multiple IO burst function and auto >> selection of the most appropriate function based on offload >> configuration. >> >> Most applications such as l2fwd/l3fwd don't provide the means to >> change offload configuration, so it will use the auto selection's io >> burst function. >> >> This patch support runtime config to select io burst function, which >> add two config: rx_func_hint and tx_func_hint, both could assign >> vec/sve/simple/common. >> >> The driver will use the following rules to select io burst func: >> a. if hint equal vec and meet the vec Rx/Tx usage condition then use >> the neon function. >> b. if hint equal sve and meet the sve Rx/Tx usage condition then use >> the sve function. >> c. if hint equal simple and meet the simple Rx/Tx usage condition then >> use the simple function. >> d. if hint equal common then use the common function. >> e. if hint not set then: >> e.1. if meet the vec Rx/Tx usage condition then use the neon function. >> e.2. if meet the simple Rx/Tx usage condition then use the simple >> function. >> e.3. else use the common function. >> >> Note: the sve Rx/Tx usage condition based on the vec Rx/Tx usage >> condition and runtime environment (which must support SVE). >> >> In the previous versions, driver will preferred use the sve function >> when meet the sve Rx/Tx usage condition, but in this case driver could >> get better performance if use the neon function. >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Min Hu (Connor) >> --- >>   doc/guides/rel_notes/release_21_05.rst |  1 + >>   drivers/net/hns3/hns3_ethdev.c         | 74 >> ++++++++++++++++++++++++++++++++++ >>   drivers/net/hns3/hns3_ethdev.h         | 12 ++++++ >>   drivers/net/hns3/hns3_ethdev_vf.c      |  1 + >>   drivers/net/hns3/hns3_rxtx.c           | 54 ++++++++++++++++++------- >>   5 files changed, 128 insertions(+), 14 deletions(-) >> > > Hi Connor, > > There are two recently added APIs to enable user to select vector datapath: > 'rte_vect_set_max_simd_bitwidth()' > 'rte_vect_get_max_simd_bitwidth()' > > Also there is an eal parameter around those APIs: > '--force-max-simd-bitwidth' > > I wonder these existing APIs can be utilized to select the vector path > instead of adding device args to the PMD, can you please check? Hi, ferruh, we will support the two methods to select IO patch. By the way, the method of "simd bitwidth" will be supported in next patches, thanks. > Thanks, > ferruh > .