From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2BECA0560; Tue, 18 Oct 2022 18:28:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBF9040395; Tue, 18 Oct 2022 18:28:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BCEB04021D for ; Tue, 18 Oct 2022 18:28:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666110499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nA4VYA+unY0fLqVEXwpi+SfRx5ulTNJ8uazwSXydLtI=; b=MNqraHjps0ogs24sfzP31nPvTQFcHBp5StV3vtJkVoa3cwOpRb4wLkv78GVIbA5X2I4Eqg 9KTsFipiqm3dgHLfVGVQitY5YSVZK/64Wz6HuVxs2hAloosXMrhiqz57PmkzWnXjf2lpD0 ZjcHQYsynBKdzPEjOC1xAwmszdTJLLc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-434-ndLF8LpGPa29TBAA6MRUbA-1; Tue, 18 Oct 2022 12:28:13 -0400 X-MC-Unique: ndLF8LpGPa29TBAA6MRUbA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3EE728027F5; Tue, 18 Oct 2022 16:28:13 +0000 (UTC) Received: from [10.39.208.29] (unknown [10.39.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD2472024CBB; Tue, 18 Oct 2022 16:28:11 +0000 (UTC) Message-ID: Date: Tue, 18 Oct 2022 18:28:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 18/30] baseband/acc100: enable input validation by default To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20221012025346.204394-1-hernan.vargas@intel.com> <20221012025346.204394-19-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20221012025346.204394-19-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/12/22 04:53, Hernan Vargas wrote: > Enable validation functions by default and provide a new flag > RTE_LIBRTE_SKIP_VALIDATE if the user wants to run without > validating input to save cycles. I would prefer a devarg, so that it can be enabled/disabled at runtime, instead of build time. The extra if condition would minimal. > Signed-off-by: Hernan Vargas > > Reviewed-by: Maxime Coquelin > --- > drivers/baseband/acc/rte_acc100_pmd.c | 36 +++++++++++++-------------- > 1 file changed, 18 insertions(+), 18 deletions(-) >