From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Shepard Siegel <shepard.siegel@atomicrules.com>,
ed.czeck@atomicrules.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] doc: update ark guide
Date: Fri, 10 Feb 2023 22:56:15 +0000 [thread overview]
Message-ID: <eac3beaa-dce5-3ffb-2bc9-6b54fcef5b13@amd.com> (raw)
In-Reply-To: <20230210223517.2606357-1-shepard.siegel@atomicrules.com>
On 2/10/2023 10:35 PM, Shepard Siegel wrote:
> Add ark PCIe device 1d6c:1022 FX2 to pci_id_ark_map.
> Include introduced FX2 PCIe ID and description.
>
Thanks for v2, but this is no more just a documentation patch,
can you please split the patch into two,
first one adds new device support and update documentation related to
new device, with a 'net/ark:' title,
second one updates the document for extended information which is most
of this patch
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> ---
> doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
> drivers/net/ark/ark_ethdev.c | 1 +
> 2 files changed, 21 insertions(+)
>
> diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> index ba00f14e80..39cd75064d 100644
> --- a/doc/guides/nics/ark.rst
> +++ b/doc/guides/nics/ark.rst
> @@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
> hardware queue-pairs are negotiated; the driver is designed to
> remain constant over a broad and extendable feature set.
>
> +* FPGA Vendors Supported: AMD/Xilinx and Intel
> +* Number of RX/TX Queue-Pairs: up to 128
> +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> +
> Intentionally, Arkville by itself DOES NOT provide common NIC
> capabilities such as offload or receive-side scaling (RSS).
> These capabilities would be viewed as a gate-level "tax" on
> @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
> * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
> * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
> * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
> +
> +Arkville RTL Core Configurations
> +-------------------------------------
> +
> +Arkville's RTL core may be configured by the user for three different
> +datapath widths to balance throughput against FPGA logic area. The ARK PMD
> +has introspection on the RTL core configuration and acts accordingly.
> +All three configurations present identical RTL user-facing AXI stream
> +interfaces for both AMD/Xilinx and Intel FPGAs.
> +
> +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
>
> DPDK and Arkville Firmware Versioning
> -------------------------------------
> @@ -334,6 +352,8 @@ Supported Features
> ------------------
>
> * Dynamic ARK PMD extensions
> +* Dynamic per-queue MBUF (re)sizing up to 32KB
> +* SR-IOV, VF-based queue-segregation
> * Multiple receive and transmit queues
> * Jumbo frames up to 9K
> * Hardware Statistics
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index c654a229f7..b2995427c8 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
> {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
> {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
> {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
> + {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
> {.vendor_id = 0, /* sentinel */ },
> };
>
next prev parent reply other threads:[~2023-02-10 22:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 19:38 [PATCH] " Shepard Siegel
2023-02-10 20:34 ` Ferruh Yigit
2023-02-10 21:03 ` Shepard Siegel
2023-02-10 21:10 ` Ferruh Yigit
2023-02-10 21:43 ` Shepard Siegel
2023-02-10 21:46 ` Shepard Siegel
2023-02-10 22:35 ` [PATCH v2] " Shepard Siegel
2023-02-10 22:56 ` Ferruh Yigit [this message]
2023-02-10 23:47 ` Shepard Siegel
2023-02-11 1:26 ` [PATCH v3 1/2] net/ark: introduce Arkville FX2 PCIe device Shepard Siegel
2023-02-11 1:26 ` [PATCH v3 2/2] doc: add Arkville FX2 PCIe device description Shepard Siegel
2023-02-11 2:13 ` Ferruh Yigit
2023-02-11 3:07 ` Shepard Siegel
2023-02-13 12:07 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eac3beaa-dce5-3ffb-2bc9-6b54fcef5b13@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=shepard.siegel@atomicrules.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).