From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Li Zhang <lizh@nvidia.com>,
dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com,
matan@nvidia.com, shahafs@nvidia.com,
cristian.dumitrescu@intel.com, lironh@marvell.com
Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter
Date: Tue, 13 Apr 2021 00:54:55 +0100 [thread overview]
Message-ID: <eaebf1de-1d4b-9f5d-b5a2-f3b1f2434d43@intel.com> (raw)
In-Reply-To: <20210410072445.1872769-1-lizh@nvidia.com>
On 4/10/2021 8:24 AM, Li Zhang wrote:
> Currently meter algorithms only supports rate is bytes per second(BPS).
> Add packet_mode flag in meter profile parameters data structure.
> So that it can meter traffic by packet per second.
>
> When packet_mode is 0, the profile rates and bucket sizes are
> specified in bytes per second and bytes
> when packet_mode is not 0, the profile rates and bucket sizes are
> specified in packets and packets per second.
>
> Add the necessary checks to the existing drivers implementing
> the rte_mtr API to makes sure that profiles with
> packet_mode set to TRUE are rejected.
>
> RFC ("adds support PPS(packet per second) on meter")
> https://patchwork.dpdk.org/project/dpdk/patch/20210125012023.1769769-2-lizh@nvidia.com/
>
> Depends-on: series=15998 ("Add ASO meter support in MLX5 PMD")
> https://patchwork.dpdk.org/project/dpdk/list/?series=15998
>
Above patch is mlx5 patch, but this driver doesn't update mlx5, is above
dependency correct?
And there is apply errors in the set, that is preventing CI to run on it, can
you please rebase on latest master to enable CI?
> V2: create a unified patch that contains both the series with
> the API changes and the series with the necessary error checks in the drivers.
>
> V3: Fix comments from Matan and Cristian.
>
> Li Zhang (4):
> ethdev: add packet mode in meter profile structure
> app/testpmd: add meter profile packet mode option
> net/softnic: check meter packet mode
> net/mvpp2: check meter packet mode
>
> app/test-pmd/cmdline_mtr.c | 40 ++++++++-
> doc/guides/rel_notes/release_21_05.rst | 12 +++
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 31 +++----
> drivers/net/mvpp2/mrvl_mtr.c | 6 ++
> drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++
> lib/librte_ethdev/rte_mtr.h | 90 ++++++++++++++++++---
> 6 files changed, 159 insertions(+), 28 deletions(-)
>
next prev parent reply other threads:[~2021-04-12 23:55 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 8:54 [dpdk-dev] [PATCH 0/2] " Li Zhang
2021-03-31 8:54 ` [dpdk-dev] [PATCH 1/2] ethdev: add packet mode in meter profile structure Li Zhang
2021-03-31 16:26 ` Dumitrescu, Cristian
2021-04-01 1:41 ` Li Zhang
2021-04-01 6:19 ` Li Zhang
2021-04-07 20:20 ` Dumitrescu, Cristian
2021-04-08 4:06 ` Li Zhang
2021-03-31 8:54 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-07 20:17 ` Dumitrescu, Cristian
2021-04-08 2:34 ` Li Zhang
2021-04-07 20:21 ` Dumitrescu, Cristian
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 0/4] Support PPS(packet per second) on meter Li Zhang
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 1/4] ethdev: add packet mode in meter profile structure Li Zhang
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 2/4] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 3/4] net/softnic: check meter packet mode Li Zhang
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 4/4] net/mvpp2: " Li Zhang
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter Li Zhang
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 1/4] ethdev: add packet mode in meter profile structure Li Zhang
2021-04-12 19:23 ` Dumitrescu, Cristian
2021-04-12 19:28 ` Jerin Jacob
2021-04-13 3:48 ` Ajit Khaparde
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 2/4] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-12 23:51 ` Ferruh Yigit
2021-04-13 2:57 ` Li Zhang
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 3/4] net/softnic: check meter packet mode Li Zhang
2021-04-12 19:24 ` Dumitrescu, Cristian
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 4/4] net/mvpp2: " Li Zhang
2021-04-12 23:54 ` Ferruh Yigit [this message]
2021-04-13 2:53 ` [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 " Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 1/4] ethdev: add packet mode in meter profile structure Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 2/4] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 3/4] net/softnic: check meter packet mode Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 4/4] net/mvpp2: " Li Zhang
2021-04-13 5:42 ` [dpdk-dev] [EXT] " Liron Himi
2021-04-13 10:24 ` [dpdk-dev] [PATCH v4 0/4] Support PPS(packet per second) on meter Ferruh Yigit
2021-04-13 11:02 ` Li Zhang
2021-04-13 11:05 ` Ferruh Yigit
2021-04-13 15:46 ` Li Zhang
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 " Li Zhang
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 1/4] ethdev: add packet mode in meter profile structure Li Zhang
2021-04-17 22:35 ` Thomas Monjalon
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 2/4] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-13 16:09 ` Ajit Khaparde
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 3/4] net/softnic: check meter packet mode Li Zhang
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 4/4] net/mvpp2: " Li Zhang
2021-04-13 18:39 ` [dpdk-dev] [PATCH v5 0/4] Support PPS(packet per second) on meter Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaebf1de-1d4b-9f5d-b5a2-f3b1f2434d43@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=lironh@marvell.com \
--cc=lizh@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=roniba@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).