From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 4D7BB44CF for ; Fri, 30 Mar 2018 10:03:55 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE2EA4023141; Fri, 30 Mar 2018 08:03:54 +0000 (UTC) Received: from [10.36.112.32] (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 166B710B009F; Fri, 30 Mar 2018 08:03:53 +0000 (UTC) To: xiangxia.m.yue@gmail.com, jianfeng.tan@intel.com Cc: dev@dpdk.org References: <1521771531-95836-1-git-send-email-xiangxia.m.yue@gmail.com> From: Maxime Coquelin Message-ID: Date: Fri, 30 Mar 2018 10:03:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521771531-95836-1-git-send-email-xiangxia.m.yue@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 30 Mar 2018 08:03:54 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 30 Mar 2018 08:03:54 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2 1/2] vhost: make sure vhost fdset-thread created successfully X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 08:03:55 -0000 On 03/23/2018 03:18 AM, xiangxia.m.yue@gmail.com wrote: > From: Tonghao Zhang > > When first call the 'rte_vhost_driver_start', the > fdset_event_dispatch thread should be created successfully. > Because the vhost uses it to poll socket events for vhost > server or clients. Without it, for example, vhost will not > get the connection event. > > This patch returns err code directly when created not successful. > > Signed-off-by: Tonghao Zhang > Reviewed-by: Jianfeng Tan > --- > v2: > According to rte_vhost_driver_start doc, replace the err code > of pthread_create with -1. > --- > lib/librte_vhost/socket.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied to dpdk-next-virtio/master. Thanks, Maxime