From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77B27468B7; Mon, 9 Jun 2025 17:39:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6FDC427A5; Mon, 9 Jun 2025 17:38:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id E3AA7427BF for ; Mon, 9 Jun 2025 17:38:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749483493; x=1781019493; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Xjo7scfY+F3t4cxV5hL9XfijA2cQX/4e1M53BtP98Ts=; b=Es7pvZfBUBZlvApuSppe0YEY3atqGGRK+6HycTTT3l2libd6BgxmZGcR 0MUd/doSTAjAJhJxHeIMAJ7LRdFim4EytFEKOyW13yEsTWUWT0S7/0Ko6 DRI9qh3ZeIqhKw1cvnk8XldD+Xh33eKkFUjYdkKAtbWhmxeobK5LpaRW+ pDNeL7OvHjHSh+UOwL8mVRXNVokO+iKkJDYh6FcUrMx+Qqk84EknyZl4y /zkxbbiwsmJPO6VmhXWKNEs1pwoBLLX1Y+Gfybh/vd0leCRzpybbZDabA HRxBfXkyAQB4lNBYxAM3GC0rzTGZsmFsgMWvie7POnbx0pt1l7g7eFd/F g==; X-CSE-ConnectionGUID: aN0xLTX1Tj+TMXPrJ1TBAQ== X-CSE-MsgGUID: vtctPZZQQE67SskPJRfzRQ== X-IronPort-AV: E=McAfee;i="6800,10657,11459"; a="69012201" X-IronPort-AV: E=Sophos;i="6.16,222,1744095600"; d="scan'208";a="69012201" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2025 08:38:13 -0700 X-CSE-ConnectionGUID: 6+8DQXvpSviCwkNzfspWEg== X-CSE-MsgGUID: yatOJ/yWQXOz7j9NQ81mcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,222,1744095600"; d="scan'208";a="151419679" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by fmviesa005.fm.intel.com with ESMTP; 09 Jun 2025 08:38:11 -0700 From: Anatoly Burakov To: dev@dpdk.org, Vladimir Medvedkin Cc: bruce.richardson@intel.com Subject: [PATCH v6 17/33] net/ixgbe: replace always-true check Date: Mon, 9 Jun 2025 16:37:15 +0100 Message-ID: X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org There is an option `RTE_PMD_PACKET_PREFETCH` in `rte_config.h` that is always set to 1 by default, and that controls some prefetch behavior in the driver. However, there's another prefetch behavior that is controlled by `RTE_PMD_USE_PREFETCH`, which is always defined unconditionally (literally using `#if 1` construct). Replace the check to also use `RTE_PMD_PACKET_PREFETCH` to allow turning it off at build time. Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v3 -> v4: - Add this commit drivers/net/intel/ixgbe/ixgbe_rxtx.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c b/drivers/net/intel/ixgbe/ixgbe_rxtx.c index 48675ab964..cdf0d33955 100644 --- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c @@ -92,11 +92,7 @@ #define IXGBE_TX_OFFLOAD_NOTSUP_MASK \ (RTE_MBUF_F_TX_OFFLOAD_MASK ^ IXGBE_TX_OFFLOAD_MASK) -#if 1 -#define RTE_PMD_USE_PREFETCH -#endif - -#ifdef RTE_PMD_USE_PREFETCH +#ifdef RTE_PMD_PACKET_PREFETCH /* * Prefetch a cache line into all cache levels. */ -- 2.47.1