DPDK patches and discussions
 help / color / mirror / Atom feed
From: oulijun <oulijun@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>, <linuxarm@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: use unsigned types for bit operator
Date: Mon, 9 Nov 2020 17:21:45 +0800
Message-ID: <eb396127-b6f1-88a1-336c-753448f089b3@huawei.com> (raw)
In-Reply-To: <59c4a8e3-fddc-cae7-3b8e-f52631407e4b@intel.com>



在 2020/11/7 0:38, Ferruh Yigit 写道:
> On 11/6/2020 3:51 AM, Lijun Ou wrote:
>> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>>
>> According to bit operator reliability style, variables in
>> the right expression participating int bit operation
>> cannot be of unsigned type.
> 
> Assuming this is talking about BIT() ("#define BIT(nr) (1UL << (nr))"),
> is this description says, in the "a << b", 'b' can't be unsigned?
> 
> The code below does the opposite, "int i" -> "uint32_t i", even though 
> there is a typo in above description, why 'b' can't be signed?
> It can't be negative, but not sure if is it a problem to have it signed.
> 
> 
> Also only first change in this patch seems related to the patch title 
> and the description, rest looks related to signed / unsigned comparison 
> fixes, if so can you separate them into their patch with proper 
> description please?
> 
>>
>> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> ---
>>   drivers/net/hns3/hns3_ethdev_vf.c     |  2 +-
>>   drivers/net/hns3/hns3_rxtx_vec_neon.h | 11 +++++------
>>   2 files changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/hns3/hns3_ethdev_vf.c 
>> b/drivers/net/hns3/hns3_ethdev_vf.c
>> index 6f71cd6..2e9bfda 100644
>> --- a/drivers/net/hns3/hns3_ethdev_vf.c
>> +++ b/drivers/net/hns3/hns3_ethdev_vf.c
>> @@ -1331,7 +1331,7 @@ hns3vf_get_tc_info(struct hns3_hw *hw)
>>   {
>>       uint8_t resp_msg;
>>       int ret;
>> -    int i;
>> +    uint32_t i;
>>       ret = hns3_send_mbx_msg(hw, HNS3_MBX_GET_TCINFO, 0, NULL, 0,
>>                   true, &resp_msg, sizeof(resp_msg));
>> diff --git a/drivers/net/hns3/hns3_rxtx_vec_neon.h 
>> b/drivers/net/hns3/hns3_rxtx_vec_neon.h
>> index 8d7721b..fe525de 100644
>> --- a/drivers/net/hns3/hns3_rxtx_vec_neon.h
>> +++ b/drivers/net/hns3/hns3_rxtx_vec_neon.h
>> @@ -89,13 +89,12 @@ hns3_desc_parse_field(struct hns3_rx_queue *rxq,
>>                 struct hns3_desc *rxdp,
>>                 uint32_t   bd_vld_num)
>>   {
>> -    uint32_t l234_info, ol_info, bd_base_info;
>> +    uint32_t l234_info, ol_info, bd_base_info, cksum_err, i;
> 
> Not sure combining more variable declarations into same line is good 
> idea, why not have their own lines?
Yes. I agree with you. I will fixes it in next patch version.
> 
>>       struct rte_mbuf *pkt;
>>       uint32_t retcode = 0;
>> -    uint32_t cksum_err;
>> -    int ret, i;
>> +    int ret;
>> -    for (i = 0; i < (int)bd_vld_num; i++) {
>> +    for (i = 0; i < bd_vld_num; i++) {
>>           pkt = sw_ring[i].mbuf;
>>           /* init rte_mbuf.rearm_data last 64-bit */
>> @@ -129,9 +128,9 @@ hns3_recv_burst_vec(struct hns3_rx_queue 
>> *__restrict rxq,
>>       uint16_t rx_id = rxq->next_to_use;
>>       struct hns3_entry *sw_ring = &rxq->sw_ring[rx_id];
>>       struct hns3_desc *rxdp = &rxq->rx_ring[rx_id];
>> -    uint32_t bd_valid_num, parse_retcode;
>> +    uint32_t bd_valid_num, parse_retcode, pos;
>>       uint16_t nb_rx = 0;
>> -    int pos, offset;
>> +    int offset;
>>       /* mask to shuffle from desc to mbuf's rx_descriptor_fields1 */
>>       uint8x16_t shuf_desc_fields_msk = {
>>
> 
> .
> 

  reply	other threads:[~2020-11-09  9:22 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 14:23 [dpdk-dev] [PATCH 0/5] bugfix and cleanups for hns3 Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 1/5] net/hns3: use correct logging format symbol Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 2/5] net/hns3: use unsigned types for bit operator Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 3/5] net/hns3: adjust some code style Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 4/5] net/hns3: check PCI config space writes Lijun Ou
2020-11-05 14:23 ` [dpdk-dev] [PATCH 5/5] net/hns3: fix queue enabling status not store after FLR Lijun Ou
2020-11-06  3:51 ` [dpdk-dev] [PATCH v2 0/5] bugfix and cleanups for hns3 Lijun Ou
2020-11-06  3:51   ` [dpdk-dev] [PATCH v2 1/5] net/hns3: use correct logging format symbol Lijun Ou
2020-11-06  3:51   ` [dpdk-dev] [PATCH v2 2/5] net/hns3: use unsigned types for bit operator Lijun Ou
2020-11-06 16:38     ` Ferruh Yigit
2020-11-09  9:21       ` oulijun [this message]
2020-11-09  9:28       ` oulijun
2020-11-06  3:51   ` [dpdk-dev] [PATCH v2 3/5] net/hns3: adjust some code style Lijun Ou
2020-11-06 16:44     ` Ferruh Yigit
2020-11-09  9:32       ` oulijun
2020-11-09 10:51         ` Ferruh Yigit
2020-11-06  3:51   ` [dpdk-dev] [PATCH v2 4/5] net/hns3: check PCI config space writes Lijun Ou
2020-11-06 16:45     ` Ferruh Yigit
2020-11-09 13:44       ` oulijun
2020-11-06  3:51   ` [dpdk-dev] [PATCH v2 5/5] net/hns3: fix queue enabling status not store after FLR Lijun Ou
2020-11-06 16:57     ` Ferruh Yigit
2020-11-09 14:27       ` oulijun
2020-11-09 14:28   ` [dpdk-dev] [PATCH V3 0/6] bugfix and cleanups for hns3 Lijun Ou
2020-11-09 14:28     ` [dpdk-dev] [PATCH V3 1/6] net/hns3: use correct logging format symbol Lijun Ou
2020-11-09 14:28     ` [dpdk-dev] [PATCH V3 2/6] net/hns3: use unsigned types for bit operator Lijun Ou
2020-11-09 14:28     ` [dpdk-dev] [PATCH V3 3/6] net/hns3: adjust code style for initial struct Lijun Ou
2020-11-09 14:29     ` [dpdk-dev] [PATCH V3 4/6] net/hns3: check PCI config space writes Lijun Ou
2020-11-09 14:29     ` [dpdk-dev] [PATCH V3 5/6] net/hns3: fix queue enabling state not store after FLR Lijun Ou
2020-11-09 14:29     ` [dpdk-dev] [PATCH V3 6/6] net/hns3: remove some unnecessary blank lines Lijun Ou
2020-11-10 10:17     ` [dpdk-dev] [PATCH V3 0/6] bugfix and cleanups for hns3 Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb396127-b6f1-88a1-336c-753448f089b3@huawei.com \
    --to=oulijun@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=linuxarm@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git