From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D4CEA0C41; Wed, 12 May 2021 18:39:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E15F2410DB; Wed, 12 May 2021 18:39:00 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id AE5E34003F; Wed, 12 May 2021 18:38:57 +0200 (CEST) IronPort-SDR: 1z4xi1naHK9e4NdUVvFSYWfTCp+oHwrcMbSXAUR4EKrWxnH90EdFWCr8Vs+1VjHA2Gp4vcD4+g v0ZVhnfxDybA== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="199429614" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="199429614" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 09:38:56 -0700 IronPort-SDR: /1/opHlV0oF1rLgY7jbzBA+OkgmXo8LmM7SYk7/4oE/f0bGYWTVF9satSM5dmHC2oY8lp56OSd wkghnS++sB6A== X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="625472178" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.17.89]) ([10.252.17.89]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 09:38:55 -0700 To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, stable@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>, ferruh.yigit@intel.com References: <20210422144030.16746-1-david.hunt@intel.com> <20210422144030.16746-2-david.hunt@intel.com> <e3fe702b-b003-95ec-e156-39bdc4e39d20@intel.com> <3917343.xMDbZIhCeM@thomas> From: David Hunt <david.hunt@intel.com> Message-ID: <eb462b99-a500-a087-0449-4db80bf55c52@intel.com> Date: Wed, 12 May 2021 17:38:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <3917343.xMDbZIhCeM@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1 2/4] test/power: add turbo mode to freq check function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 12/5/2021 4:34 PM, Thomas Monjalon wrote: > 22/04/2021 18:13, Burakov, Anatoly: >> On 22-Apr-21 3:40 PM, David Hunt wrote: >>> --- a/app/test/test_power_cpufreq.c >>> +++ b/app/test/test_power_cpufreq.c >>> @@ -48,7 +48,7 @@ static uint32_t total_freq_num; >>> static uint32_t freqs[TEST_POWER_FREQS_NUM_MAX]; >>> >>> static int >>> -check_cur_freq(unsigned lcore_id, uint32_t idx) >>> +check_cur_freq(unsigned int lcore_id, uint32_t idx, int turbo) >> Nitpicking, but stdbool exists :) it would be nice to use bool type for >> bool variables, not int. > Dave, I think you missed this comment. > Thanks for the reminder Thomas, I've just pushed a new version replacing the int with a bool. Regards, Dave.