From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60B43425D1; Mon, 18 Sep 2023 14:31:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 142C44025D; Mon, 18 Sep 2023 14:31:16 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2055.outbound.protection.outlook.com [40.107.220.55]) by mails.dpdk.org (Postfix) with ESMTP id 6D8AB4025C for ; Mon, 18 Sep 2023 14:31:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E5JG6NSDPXSLjtJ/2+9U2GIAw39Ti+8T26RwwyIcb3xd5IXBwx4jCOZ6wO9Y6XeU+YbP5Ospmq/hZaWrpZrmNa9N/sr7w5mlk4zXFp3Xlq3FeRrbJ1oIaoHo+9zaMLciXX6CHPLOeeCUto3V4PJ1cDOfK5tjK2uJn+gOikcFDZiYP3NU1y6TdW/B0f3mJektyITVBaDXJTQ5DqLWB5ooWghLyRLq0gEAuCIvLBZ04Ie+sF8nj3Q5tpfJsgFt9hm4sFeOA4KysMdZpLYnpFFPu+/+1zPEvg5khTgErP6wm6enC/7UiWvsE4IKUL0P1HLCAuEBsBuS78wYbFp4+zEQAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SUtiGaHrFkym6YIP5DntkvpfLQZXQ+/uXe71XN31T30=; b=a2HW+IL0chad96Cho8oY6i+Sl0OwJkkALLFclTHvPCk/jN1HBxzapDxSG1Aw89kvKB7llJjI0qHrNlMaEGRyIHAqt1qETJT9IaCDrD6ikpZDlvSEnpAunL0x9beglmA+45SROMCHw8yTDyOJXlumxe895MpER+Ce0UMBn9o7omU5kpIKNT2+FbrOyNOPr9dDChlSn9hjwFzXMvCS1Pvrt1TIhLrTd+Ovh8qC4Fv/ZxWjXWPxz4oT4q7H/WEvuEHBpIz43sfuwhz7n8V/FXVqwdcH8xw1YfXZijmk8sne2Ubjivq22gRvxbNTOhpY2XJiDdMRECh+24yTSEpii28Kgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUtiGaHrFkym6YIP5DntkvpfLQZXQ+/uXe71XN31T30=; b=Fibm4HqWrwD8pS10FA8k5MLsSKM9/uGdMltF3gBHzyInTp3Uxac5kPAq9WhKQ+wf3S1LwikMRZYUgeLoDC0CaaQsU+aO6rxDhObXmTXT6XCQ3n9vfq+5tOvkSyPZCirzlyIfMrcr0qz6JKfdcZDcsW6rg9/WOc7RLtcr7qzWy+c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN0PR12MB6151.namprd12.prod.outlook.com (2603:10b6:208:3c5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Mon, 18 Sep 2023 12:31:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 12:31:11 +0000 Message-ID: Date: Mon, 18 Sep 2023 13:31:04 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 19/27] net/nfp: refact the nsp module Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, =?UTF-8?Q?Niklas_S=C3=B6derlund?= References: <20230830021457.2064750-1-chaoyong.he@corigine.com> <20230915091551.1459606-1-chaoyong.he@corigine.com> <20230915091551.1459606-20-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230915091551.1459606-20-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0087.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN0PR12MB6151:EE_ X-MS-Office365-Filtering-Correlation-Id: dda3efb6-84a8-4bbe-057b-08dbb8432452 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FUAEQg78a8LZAiXLhNmFBDxlgJ8CA7TnuMrzP0ezSQCl0iVMUfhyaq31+ANbl5qX+YnMo1bXqJTPrNQuK6B03MG3K3o+SdVeNb2mrfuKoza/r8jLuMWjXQXzIaNbAiStbkikOKMfXBElrka3uKLuTcSFcIfqUa/Q45c3vTEaEWTK1by2V0VVfAJtcvqtswfrp2KeDYLq9UEtjLOoXx8z/P2KRik2FuraIRxx1EXmpi+TzUdZRulDnMd8WM63W166NgoUXLBNLL9NHW5LrAxVlSanNanWgtebD4so5NFBRIOtEKSp5XZIaP757oe/ichNkgTQhW1YO6N/h9v2Crpvvn8J80VgeeAisepfuCji+hjAgY0OpDg+1zm4ajzDHGm1mdvDsqe0VjgeQ5LK30Eu8OCmbbSw4kKLchC9ZzFs+loTInnsJZKH+WKNYxTNpZn/f5ywCwBregRvFk2Ztgskxi73xrJyEMDNDq28DXxhp5c7EPkdrfyLvvWx5XZ4VNiy+zDDR8qT97VOVe3tecv0U3pOzp9mR7YKpcMdU+Q/lo24vKPxRpYcbIBTPtL4Iha/D8Cp5x2sKJWc5G98i1T5fVfd1nbF08tBZdj+tfkZmXyTqRapJknUIwr96SQYYNqSUTLA7V6/Qepl337rejDRNA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(346002)(396003)(376002)(39860400002)(1800799009)(186009)(451199024)(26005)(2616005)(8936002)(4326008)(8676002)(83380400001)(2906002)(36756003)(31696002)(66574015)(5660300002)(44832011)(86362001)(53546011)(6506007)(6486002)(478600001)(31686004)(6666004)(316002)(6512007)(66946007)(41300700001)(38100700002)(66556008)(66476007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rkl3RWxuU0hOQ1RBWFlHdDlEenZiZURvVjlCUkplYW1GdjNHZGxsREs4bDln?= =?utf-8?B?L3oyTTZnMHlqWklLNVpOOTdOMTlueUpMK2xDUHdnc0l1cVNtZXVWY2ozT3R0?= =?utf-8?B?cWorUWRlMkVFbEtSc1lRUDBrbmMyZ0N2NzlGRE9DU3ZZQ09Xd3R2b003L2tQ?= =?utf-8?B?Um5SZ0pMajdabDFZaGVNdE40RW1qOTNMZVRwOE10U2R4bmhGSmZ5d3hGS1Nq?= =?utf-8?B?NUpsSlZQeFRFWjJnUDBDbGU5NlArbGYxOFExR1duM3UrN3RVWUtrbUdvWVFh?= =?utf-8?B?Z2l0T3lyWS9neUVzYXozZkN5anh4aVJsa3FJakNyeHRpTVk3UWJtbCtUVGJL?= =?utf-8?B?bjhSYlphQ2hTMEFkYk9iWlIvZ0gvYUJvcjBRQmw0SmV5MnYrMUthd1VpZy9v?= =?utf-8?B?ejg2Zmt3ZzZHMTM5UkdTeUtyT0tkcHRkOG5tQWZpRXJDRnRzTCs1eXZ6d3Qx?= =?utf-8?B?bndCVEk1MWFSYTBEeFUxZGgzbWdBK1VXbWtiNlVQczZLSDA0S3F0eER4S1dH?= =?utf-8?B?Sm14NTRjTVZEU2xvT0kzWlpZRTE5aWRrelZrWi9OUG10STZpTXprUEZkMG5q?= =?utf-8?B?L1QvbEhKbmRQQkM1Yy91bXp3S3NIcldaT20xS2E2RGdoOFdzcG56Y0lsZHds?= =?utf-8?B?MVFaMjUybmtEUlpwbEdlRE5rMzJwVUpkVFFsM0QvaFhBbXZYSlN4cHB2N2JJ?= =?utf-8?B?bG9NM2pVUHZDVk5PdnluMDJRaUxSdW9xUmRGdmpqRU1qQlE2cW1Vd2hRaFVn?= =?utf-8?B?WDRiK1NwdU44UW0wcittei9rTnowanhyaXNWY0swajR0STlja09mUjJ2b1h3?= =?utf-8?B?czFMdHRqeml6eG9vLytsOXh3Zkx0T0NNUjZyaU41WnU5eGdWNWJmcWRnbFFU?= =?utf-8?B?bnlNY2djU3VxWGZFOVdXWTNCUW12T1VyVHJjbVpWVDlld0gweC9iWnhCQjlw?= =?utf-8?B?b1ZzbjlZaWpOd0puL0NEYVNDREJrRU5CZjZnOUd2aDRUdVJQSTZoRTNpMWg3?= =?utf-8?B?TGFkaGYvZUtrRCtDWStmak9vc2xVbzVhVU54dE56SGZJVXhXREF3SnNQSGhi?= =?utf-8?B?bGpDVmkvUXZmamV6WHA3OXpOS2xRUFpHcU5Bc0ZMQy9lWnFoL2dHYkEveTBD?= =?utf-8?B?UmhoT2JCOWNWaEcyQ1NadmxaK1crU3cvUVljMXlURFVMRWhwRUoxbW8vekJr?= =?utf-8?B?RzZMS2JsMm9pTlNtdjVFMXQ1ZzRqTUpVZU1BSEVSTjYxYWliMUhYQ0xSdVJq?= =?utf-8?B?eEFrejVSZk1ONFJCMkpjMXJoL0tJM054Ujg0ajdJcjYyekxnV1lRczNLVUJT?= =?utf-8?B?MmIyRVhaMTBYMGlxMXZabWp0cWtUcmNaNk9ObHJFV2R4NURTcGw2WkpNd2c2?= =?utf-8?B?aHJxenorb2VLczdHTHFLSkQ2Ky9sdHZlSVIwVDU5UFlOaEIwRVVSeldlWEJK?= =?utf-8?B?ZjBaVnVOdW5hZis4czJYUERIZmNQVytvcEFhMUI2bEVJRTJyVHM5YUVIYkN3?= =?utf-8?B?OXU3TFNvaDcydTV4aHQ3aHV5Z0Q3WjUrSmY1Rk1RRk1GVHlFaXliQjhFY2p2?= =?utf-8?B?bEVPdGxQZjc3VG1TTzhhRVZiYlJzUktxVWJjVWhhZW1XL0d0blNtNHB3MVFi?= =?utf-8?B?QzN3MHVIRHZnZGRpazJUcHNsSi8yRTY0VFpvZmUrZUVwbitVTURlbEo1OFR6?= =?utf-8?B?SVVYbDFMTmF5Rk5ycm1yUjIzWUxmcTFXbU1iSm10U3JBWDNWWGxveGFkNGZk?= =?utf-8?B?dkxQcDhRektGRzlBbmJncXQ4WmlweUJIa2s5QzQ3NkVMbW0zZmdpSzdCSm13?= =?utf-8?B?QmxGcmoxNVpSUGMrY0d2dU9Ca2FnZ1RuY2IvTENDcENmVVBwYVJxbWRyUHlQ?= =?utf-8?B?SEIwUWNDTUcxNlBhWXBuTVdyeHc5d0dpNkF1c3VmYU50UFU3WXVWU2pLMUVi?= =?utf-8?B?RUF5S1doczZrVk92TlEvUFlta3VMakZxTlc0eGJtVTV0dDFON1dTcU4wMy9N?= =?utf-8?B?ZXlGM3g5dGJYRDNhelFWNThTNHZWYzJQZ25LVnZmZURNSVdKcFh3LytQS3A5?= =?utf-8?B?cVhJS1hqZ2dITGZ1bXJMeHdTZWY3TkE5OWdQandid1EwclZFaGx3M0NCSXBh?= =?utf-8?Q?CYUWSGE3Jefa3iR/cdvPC9uhA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dda3efb6-84a8-4bbe-057b-08dbb8432452 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 12:31:11.6818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C1P007y/95qjuR+epb7sGqMHZwgIzdO/kmVwUGNsaqMVsXpjFw1gUJRDxGT/yVg7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6151 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/15/2023 10:15 AM, Chaoyong He wrote: > Move the definition of data structure into the implement file. > Also sync the logic from kernel driver and remove the unneeded header > file include statements. > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund <...> > @@ -381,6 +478,43 @@ nfp_nsp_command_buf(struct nfp_nsp *nsp, > return ret; > } > > +#define SZ_1M 0x00100000 > +#define SZ_4K 0x00001000 > + > +static int > +nfp_nsp_command_buf(struct nfp_nsp *nsp, > + struct nfp_nsp_command_buf_arg *arg) > +{ > + int err; > + uint64_t reg; > + uint32_t size; > + uint32_t max_size; > One of the previous patches, patch 3/27, updates variable type 'unsigned int max_size;' -> 'size_t max_size;' Now it is updated again to 'uint32_t max_size;', I assume by mistake that previous patch updated by this one didn't. If it is by mistake can you please check all patches that moves code, if they are aligned with previous cleanups. Or if this is intentional, can you please update the first patch to set the variable correct at first place?