DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Laatz <kevin.laatz@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH v4] eal: add bus cleanup to eal cleanup
Date: Tue, 24 May 2022 16:20:38 +0100	[thread overview]
Message-ID: <eb796642-e294-aad3-33c8-ea55da4ce571@intel.com> (raw)
In-Reply-To: <20220524074857.4b22e9eb@hermes.local>

On 24/05/2022 15:48, Stephen Hemminger wrote:
> On Tue, 24 May 2022 10:25:01 +0100
> Kevin Laatz <kevin.laatz@intel.com> wrote:
>
>> +
>> +		RTE_LOG(DEBUG, EAL,
>> +				"Clean up PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n",
>> +				drv->driver.name, dev->id.vendor_id, dev->id.device_id,
>> +				loc->domain, loc->bus, loc->devid, loc->function,
>> +				dev->device.numa_node);
>> +
> No message is needed here.>
>
>> +			RTE_LOG(ERR, EAL, "Cleanup for device "PCI_PRI_FMT" failed\n",
>> +					dev->addr.domain, dev->addr.bus, dev->addr.devid,
>> +					dev->addr.function);
> As Bruce said, the driver probably already logged something.
> So no message, or make it a DEBUG message.
Ack, will remove unnecessary logging in v5.


  reply	other threads:[~2022-05-24 15:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 16:14 [RFC] " Kevin Laatz
2022-04-19 16:36 ` Stephen Hemminger
2022-04-20  6:55 ` Morten Brørup
2022-04-22  9:18   ` Kevin Laatz
2022-04-22 12:14     ` Morten Brørup
2022-04-22 16:27 ` [RFC v2] " Kevin Laatz
2022-05-24  9:08 ` [PATCH v3] " Kevin Laatz
2022-05-24  9:25 ` [PATCH v4] " Kevin Laatz
2022-05-24  9:38   ` Bruce Richardson
2022-05-24 15:19     ` Kevin Laatz
2022-05-24 14:48   ` Stephen Hemminger
2022-05-24 15:20     ` Kevin Laatz [this message]
2022-05-25 10:39 ` [PATCH v5] " Kevin Laatz
2022-05-25 11:12   ` Bruce Richardson
2022-05-26  8:36     ` Kevin Laatz
2022-06-01 17:02 ` [PATCH v6] " Kevin Laatz
2022-06-01 17:03   ` Bruce Richardson
2022-06-02  2:06   ` lihuisong (C)
2022-06-03 14:35     ` Kevin Laatz
2022-06-03 14:36 ` [PATCH v7] " Kevin Laatz
2022-06-03 15:11   ` Stephen Hemminger
2022-06-03 15:39     ` Bruce Richardson
2022-06-04  2:07   ` lihuisong (C)
2022-06-07 11:09   ` Thomas Monjalon
2022-06-07 15:12     ` David Marchand
2022-06-13 15:58       ` Bruce Richardson
2022-10-03 12:35         ` David Marchand
2022-10-03 14:39           ` Kevin Laatz
2022-10-04 13:11 ` [PATCH v8] " Kevin Laatz
2022-10-04 15:28   ` David Marchand
2022-10-04 15:36     ` Kevin Laatz
2022-10-04 16:50 ` [PATCH v9] " Kevin Laatz
2022-10-05  7:45   ` David Marchand
2022-10-05  9:41     ` Thomas Monjalon
2022-10-05 11:03       ` Kevin Laatz
2022-10-05 12:06         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb796642-e294-aad3-33c8-ea55da4ce571@intel.com \
    --to=kevin.laatz@intel.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).