From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29281A04FF; Tue, 24 May 2022 17:20:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7C3740140; Tue, 24 May 2022 17:20:48 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id A3B9E400D6 for ; Tue, 24 May 2022 17:20:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653405646; x=1684941646; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=sx3Glip4IdVzjA1YtBGKL8lBuF5/T2jLXHtwOCkydG4=; b=JA/ziFnWK7RID/J/IrBYQ4RUh9sf6z5YLZvLAp5whAwZQOhdkCI74u/D JmHy0Ohhm4gGhnoEbOC1GNybKarrQkgedlUTtLjWjVYR0rjJwxba3jwo/ 29dweFFAZWi6DDabIfo4ZdWGieX5qV8MLGoqjE5//eFe0ozJVjOCeO0PA w+xRKoDaJQKtNKaDrTnddEPTBRZN0/1rCpeiOFopatDwPfRy24sMVurry Jc2H/NWY3+VRSWOLb1utL2L8YvIO74B2pl/ftmKkibAKIl4PoJZJ5b/IV g/MdGNDKRmE+PnokYSBrohOjm42misNV2iEkSfxQNsKV6XjPvA+dOR8v9 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="298881373" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="298881373" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 08:20:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="608712976" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga001.jf.intel.com with ESMTP; 24 May 2022 08:20:45 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 08:20:44 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 08:20:44 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 08:20:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jCpTkDUU/9MGD6bocdsCy/x9hsFgeWe6ufljoKG9D1kF3wDPvGOqv7PFF3FgNlHvOcWOqwDVzEFXrstZwG4lvPckaHQ/c1iWSBda9H9z0Dokyr3x41EwNxp2lm+9WZBaCHQKHfQCXtsyvOPugMcpejvqGi+3hMJhKqJvTjznMvT/gzFMTO4BQrL21ZNLf7YYXrZA0A0HhkVzUlrJyN8l/FZpmb1pLqb6W/Upkhhir7L0m564r9YbFkTwlz9cnjA0MSbGkYxHn73UJyiaMGwWIIFlS/OzjOCF0aOXsavSv5/h1v3k1Q1NEf5y1+AUFut6ZAoWpbTAZKKH30qg0icleA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KjLz4r0hSCyj84fvwkSPxOHoboBMr3LJiDaYtUZWfd8=; b=UZUB95Nf5C9r36lZbAg7zlSnxFgndzdrrndSDjc/mybi9lvYpa30p00pVXH63nB6lWbi/rVTl1AoRBg7WZWFssY2UTf4mrWJYnjZec2p1fawT/vmDz+HyB7TliqqI6lhShT2mWPGqsNNYDg9CDgkQIxYfjTL/9QIDYKHNx9x/5mKPOekJphlq61T0c0L6I5fUjZDwSyQ8gG7PEH/2JbDo0cN/fNjT6WLU1pgUujQfQikc4CH9QmupXKrKRgM0tA1fDhSbsAx5UW2pJTzznPT9YxH6lvvL2jRrxh3JUt0KuM2IfOHoblZIzA+KHZDi9h6L3bzL3HbHWUC406/Anlf0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM6PR11MB4105.namprd11.prod.outlook.com (2603:10b6:5:5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Tue, 24 May 2022 15:20:43 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd%5]) with mapi id 15.20.5273.023; Tue, 24 May 2022 15:20:43 +0000 Message-ID: Date: Tue, 24 May 2022 16:20:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4] eal: add bus cleanup to eal cleanup To: Stephen Hemminger CC: , =?UTF-8?Q?Morten_Br=c3=b8rup?= References: <20220419161438.1837860-1-kevin.laatz@intel.com> <20220524092501.419761-1-kevin.laatz@intel.com> <20220524074857.4b22e9eb@hermes.local> From: Kevin Laatz In-Reply-To: <20220524074857.4b22e9eb@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0372.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::17) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 321c53fe-c677-49a0-1361-08da3d98f7ba X-MS-TrafficTypeDiagnostic: DM6PR11MB4105:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EXmDqjxHHRsc3AeFf/V7M6oZ+kKcRdctsBnc4fDEkSvz2Y6/E2p9va9YY3JelBNIwqiK3RT440r2SKHH6g/qMJtXKXl/H6LrbU+scYBQ8CmNzKtTxaBTJzDuUcESC3TgqIRRhRhscthyDkJxAZItjHnI5aJwyfxnLHSBMhvt4ph51aCH4hommVfB2VgckGO5WU0j7w8OrkJoEH52IJmbZzeEl95zfQJ6Zkgho/fvC4p5a3ZY0J2DUlRlAE+m5Whd1Cfy1SOjn7Q79TX7IEytdBAJkIy59g2hn5y70YBpCUrSx4/cQRvIyRJaCVNcr4NAQbqZf5ZVPh+wlNY41PWTg66DDdbojb+XUWXLSL6rnQBABOffiVL4LERTp73fqVN9uuh6CmBDFUfevJX697ulVuHfDFfIrv7/tiueypITCGSVCQeLYU9POI0ErjLzz96oldeDXmD8zizobIpZx4s7PRAGR1hEuW+XJiTeH9j/n/bW9U1aov/xdPcvWjhU+p7NgllJuGRBis59wCJPIjbGB14O4cJ/ipjedLcMMs8GVnNLLZo8Z/H547tV6ypuaUOmJcCsUiLNcNfDj4iYRKRLUy6GADHFS3r+ce/pHLC9Gn0DVE2Z3N+XAmBpIu20qoUyat72+5KJ6uCQHB6XfeER77iXWIXARnH2gTxSbd+NURhpKQN6k+55xZUr0kddkpnQEKB7cYyPH3U3W5WVKSgvzJVrFXXVT+8DX09HumgE088= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6916009)(38100700002)(508600001)(53546011)(82960400001)(6486002)(83380400001)(316002)(86362001)(5660300002)(8936002)(31696002)(4744005)(6512007)(6506007)(186003)(4326008)(44832011)(66476007)(6666004)(31686004)(66556008)(66946007)(36756003)(26005)(2906002)(2616005)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUNOTnpTdXZMY25ubGh4M1FaazNwMllmV3hxYkJFckRsVDNRdGM5Nzhvd0ND?= =?utf-8?B?d2ZtZ1JqU2ZqR0FnRzdLRUllOWRzTUdaaU9XZE1aSnFoeUF1K2lDb2JiV213?= =?utf-8?B?dlVXSEd4N0tiZSszYnVpVGRuL3FjQ3RSREUyNUhVTzdhS3gyU3VDZDFzSWlI?= =?utf-8?B?eDRYU2hTMmg4bTdmSzM1dGh6UmFtb243ZkJKbHpaRG82aVU5c2J2TzBsanpt?= =?utf-8?B?NmFoYXhBT21seUFhTnI0RURXMi9OS2IzQW5QTGc3aDgxeWN4N2hleVhXcysr?= =?utf-8?B?ZzVJK0E0Tm9OM1ZWL0lIT2tiWTFXSWFhdFBPS25IRjJVZDlScjdTMGh3bGp0?= =?utf-8?B?OVNoYkwrN2w1ek9oaXEvWk5YU3I2QVV3eFpNZDc2ZTk5Q0dUdyswL202eEpj?= =?utf-8?B?cmROMjQwc1I4dkxjOTlvSEdzWW00NEZyUTYxVUpOaUZqYUJISzBtY1FlWHpr?= =?utf-8?B?d0pLUE5BcW1HdHNwTDVVZDY2Vm5odGt6YmtjWWd2eTcxQURJWWFhVk5zRnJs?= =?utf-8?B?azkzaUxPY2sxTE9RSXFldGJpYlpPcHR1Qm9VRFRqZEUxU0JrUmtETmNZbGNa?= =?utf-8?B?ZS9xQ0szbU5zeE1zZ0ZSTTExTTlielNaUTVFc3BJdnhnZ2VrcU5iQXhBRmkv?= =?utf-8?B?TERBMThNbFhFNEZ3ZlgzM3Z5WFZ2WHd5NVdRcVd1TVBsa0U1bWhNR0Q5dyti?= =?utf-8?B?TUpudDN0TkUvSHVYd2wxMGRlaUNSVk92MUpmVC9NN0IxTkZYSytsM2puY3gw?= =?utf-8?B?UGxsbk5PcDg0TGFKRDVtVXFDRUhxUVIveUlucDZaU0lVeldSVG1sMmVHbDda?= =?utf-8?B?aytYYlRZRzd5VnBMSlV1bUFWa2c1U2VXc0xOY3RMUXhxcndocmQ2WDhnNlRv?= =?utf-8?B?dEk5TVFFU3FIeDUvMVA2RXR4WkFFSURxaXlTQk5NVnZWOHJwMGNNVWpLOUR4?= =?utf-8?B?RVpMVDZQZEliMXFNdHJCbFUyOVpaa25QNGwzT1c3NUF6bXhLUDZvRDFydTFB?= =?utf-8?B?RS9sRXBwL1RlcDYydkEwNXdiM0FHQVl1a0t4T3Q3MVU0OUxPVDRna1VNdlMz?= =?utf-8?B?bStscVJlUHRiVitnWHQ0L3VYZE01aXJheDU2NVd2K0RzSG1LS2J4WlEwalZS?= =?utf-8?B?Z2JKVXkxK3Z2SHBwdjl3bDlGRVpQZFB5UERsQzdHNVl5T3IzYUZST1o1OU5k?= =?utf-8?B?NDUzRDdici9nYlRoWnlNZ1dyMlpQVE56N1JSdlZmUTdXSmRzQ0RVZnJyTWVZ?= =?utf-8?B?dkdHL3BCZStNVlF3RnVHbWNIUTBRWndYeEkwQ3B0UDBPajV1enhXb0pScXRn?= =?utf-8?B?ZTFIRGJ5SmNUQ2hEcjBqY1pWWGNBam14UzNqQXlsSXA5WXZ4NTg1UG1DZnhv?= =?utf-8?B?dlJycnlJellyWmpDajhHbk1nNGdaL3R0emlzMGtDN0licjhhUjNEWmkvNkJM?= =?utf-8?B?TkFsUVRwOS8wWnRPV3lnWW9UN1RXTTBpWnFjOVZRejJiZmpzeG9OdFBBdHFH?= =?utf-8?B?dzBlOVNTLzNGbTV2UXNZVUJ2YVZuVTAwS3RkRm82RG4rZTVPbnVmWlhPdWhi?= =?utf-8?B?QmhBWXRoeTJRdkVBY3hUTjdnSTY3VWNNdE5NL2RaNTM3ZmUzQ1NRcFB0NWQ1?= =?utf-8?B?b0VCaVZRZ1cvdmd1SitCcVBFeGM2OStkaHovVDdkS1VMRjFrWksreGZ0cEZj?= =?utf-8?B?WEFEM0FwNE94S1k0SUVsTHhLak05RUhUZzZ2S0pacDFOOWh3QWM5M2lWYzU5?= =?utf-8?B?RVdXRFBaNGlxbEdvcTB3WTgxdDdEZitYUUZTelpUQjhhWUM1aWVPSG5vV1Rh?= =?utf-8?B?aFpWd1pQbWhZRXpkdUNnZzFmTlJIdE1NWkJtWVVzazlONVRGdE8zN1B4SzBj?= =?utf-8?B?ME51Vk5zM0xhamFQY1ZabzZ1T0ZJS1U4VTZJcnlpazJ2RW9lZzV1L3lPRzZB?= =?utf-8?B?ZWtnMXNFRlVmTGh4OFI5bDhyMWhoMWVPRVBmRXhiVisvMXZ5YWtVL2NRaEh6?= =?utf-8?B?aDF4TGhHenNGZEZyNHZET2piUTBVZWdER2d0Nmo1K2NKUWY2L2p3NVhPK1pz?= =?utf-8?B?S094aFRQMkJMOGlCNDJFZVFickpFamZ6RERqeEZENlhSZFh4c3BiU3dQVkZh?= =?utf-8?B?ejZpNUErdyttNG9FVDEyN3pNNjU3YmZVTzA2MVpYN2xLZ1I2ZEE4V3R0YURy?= =?utf-8?B?bTZUVm85ZHBJVXRHcy9kV3hwQTF2WDVpZExNK2Z5Zy9LOE9EUWc0UTBKWHRm?= =?utf-8?B?Wm43aEF2b2hHSmJPSVNublBraGwzVUJjRmJOTmNjVGQxOWNwbDdudlZ1VHN3?= =?utf-8?B?WEYwNm1NeVRJYTR3U1lueUxINzRzdi9wM3RTN1JPcFIrZnk5eHR4dz09?= X-MS-Exchange-CrossTenant-Network-Message-Id: 321c53fe-c677-49a0-1361-08da3d98f7ba X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2022 15:20:42.9023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: itxtAPEpHKsbvx1kZdhXjsAQKDD7PlXyaGnUcO5eV8xqA7sjNJ1TOXaX+kMrnU/4v+rEnxlVbvnYa6PoB8WBpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4105 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 24/05/2022 15:48, Stephen Hemminger wrote: > On Tue, 24 May 2022 10:25:01 +0100 > Kevin Laatz wrote: > >> + >> + RTE_LOG(DEBUG, EAL, >> + "Clean up PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n", >> + drv->driver.name, dev->id.vendor_id, dev->id.device_id, >> + loc->domain, loc->bus, loc->devid, loc->function, >> + dev->device.numa_node); >> + > No message is needed here.> > >> + RTE_LOG(ERR, EAL, "Cleanup for device "PCI_PRI_FMT" failed\n", >> + dev->addr.domain, dev->addr.bus, dev->addr.devid, >> + dev->addr.function); > As Bruce said, the driver probably already logged something. > So no message, or make it a DEBUG message. Ack, will remove unnecessary logging in v5.