From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 337C545843; Fri, 23 Aug 2024 09:36:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB31143245; Fri, 23 Aug 2024 09:34:17 +0200 (CEST) Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013008.outbound.protection.outlook.com [52.101.67.8]) by mails.dpdk.org (Postfix) with ESMTP id 086F542FF9 for <dev@dpdk.org>; Fri, 23 Aug 2024 09:34:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aXsWWbHxpe22YUMIzVIfMMcdmLmoYx/B6nZ/H1tv0/MIex5a3hXQmd9CWZMNkiAoTjgYfXCPcuB4MSKmKWYa/LMWNhLYX3/oHiqlTBgDP8WbAoPXaKBRMlxROOB2+B/jW57AWbGhvbNfqYn/+kyWoyGYjRjA7T6WBS0+1sPjp9DERIjmXTj3JapiTJUiVLLVSMxcpaNFg1xpco5/T2aV7kUrLPEmjcUtk8cVPB7pfnmXTO3vVVOA+E51NKV0AM8/ajrzZTx+kBCZTrpTkCj9tqbo+ZD0u+/IQAdx0VUxLuFt6DJjw5YMQ+VX90ExQNWu6bUWnceh6UEkkOn8JubtQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OX9+Vzt2OvEX8EOZVnFhy4K59A2rKEjrH2Eh8jQIV5I=; b=r/qmm8EwBoYb7fG0pO2SMkl/DongCZNdP5+AdgbbuU+qaDIP5GOXEubYgf5HULUz741vHz/sP86l/d/s9nUBnpkFntH0UrwxRLrJt9vzbXF61JtaDUIpjPh6DU3H2dWyKXv+acWSSK/g1bXmP97kPn/ELYg1R4/APdi3FtnxLBZ4Z5BFq9uUT7H+L0q1FvBf4EbqEtvsbn7sqNKiEdgCR3rRjcHUV8Y62SX9t2EIDGRP8hPerNdTKs4vpoeMqSjQqsiXAuMeLq309Ww18X2ZF/w3n0bqAvjp8bx8CfRYr+c/luWXptB/TYCR/6rSubu6A+R7as5F5+N45Z5zvYJc8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OX9+Vzt2OvEX8EOZVnFhy4K59A2rKEjrH2Eh8jQIV5I=; b=nczc3c7yVZ90EIwdxLl/VjBOzwh0S2beoSWbNT1aCVpi3jguLPbslpvnZysUEIsVxlDV0hjVogRIs2auH8EBxDfAmarfmDCNTNeWdh3ZgxizPjAUfvQZlA//FgfS1BhRo/bhEcn6R0Vdbg+SCeaTdEIJj8t/5dL1oUIGX3rhxUvu9J0lJfYs+ALlx/4RyZZlksc9LP3StL5SjnfRj8ZgupoePgHAwMHk6/hQ3CZlkD/fdfmYUEr/jvnXbDtuxoAaHN1s0g899EjzzdEr0ugJxEqutDVqp/X/YxrX3jJZHYWYLyTeF0/9S/VZPXSOAUOn3OfGaPaFyaxAmjgR9gkbyg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by DU2PR04MB8789.eurprd04.prod.outlook.com (2603:10a6:10:2e0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.18; Fri, 23 Aug 2024 07:34:14 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%3]) with mapi id 15.20.7875.019; Fri, 23 Aug 2024 07:34:14 +0000 Message-ID: <eb7d6561-30ff-3aee-580f-99ed53f81cbb@oss.nxp.com> Date: Fri, 23 Aug 2024 13:04:07 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 05/17] net/dpaa: support Tx confirmation to enable PTP Content-Language: en-US To: Ferruh Yigit <ferruh.yigit@amd.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org Cc: Vanshika Shukla <vanshika.shukla@nxp.com>, Thomas Monjalon <thomas@monjalon.net> References: <20240801105313.630280-1-hemant.agrawal@nxp.com> <20240801105313.630280-6-hemant.agrawal@nxp.com> <e8b73b7f-85ba-4862-a486-e2778270ef81@amd.com> From: Hemant Agrawal <hemant.agrawal@oss.nxp.com> In-Reply-To: <e8b73b7f-85ba-4862-a486-e2778270ef81@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR03CA0118.apcprd03.prod.outlook.com (2603:1096:4:91::22) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|DU2PR04MB8789:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f6f64fc-9dbd-4da9-8570-08dcc345fcf5 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cDhCdXZqZ1A3RVYyZUh4dVVQZWdQamlDQWo3WW9ESXIxeThhd2dDY2VSa3Vm?= =?utf-8?B?aUxXU3BmL2RSY3IyZTVXYWxaSFVXKytmRVlxY1NZNnhDbURUeWdhUjlpeG9S?= =?utf-8?B?YlkrMXROSGxwUTJzZ2lPb0V3aUpxRVVUZmowOVorWkt0YmI0T0p2SDJGdkVw?= =?utf-8?B?aFpodGFYWExFUEhGbGk3S29YWGh1K2J0bUsxOFc4Wmc2RUIxa0dNNTFxL0xP?= =?utf-8?B?Nzc2bGhRREpwMFFjMXJ3VWJwcUF0emh1V0NCZ0llY3NGUi9pc3ZuUFlkZGRR?= =?utf-8?B?M1hvVnNweTloWml0a0Q0R2NDdnlINlJDZ1Bhb0tTN09uTDNQRXBMUWRXakxy?= =?utf-8?B?QzAxVVBMNnJZYlNnRGtZSnQ5SnpvZTNVM3I3cWpFMFYzcU9uM0xrVElwQjkx?= =?utf-8?B?SzVGTWs2YjFSMEowZlJVanJNZUlNTUNKa2hQdTBORUNIVDVhbzZmQzNlUjdv?= =?utf-8?B?ZmZtb1ZGMXVvRlhxZmhvMCt5NFVBQlEzMjNQcStLdmt0Mkp4T0NJZHJNQk82?= =?utf-8?B?enFTUjFoVHZJd2lCVlY3WFR2cmMxTVZkMmZoZTJKTEtFNkRxQlNIcEdIWTEx?= =?utf-8?B?UnkzSk1tK2FtUXJpd0JnQ2U2Rnc2SGp5TVd5eis0UFd6M2x2clZlTFloeEhx?= =?utf-8?B?TTFJQjR0ZjJmRG90VkNzRzlLdzlkWkhYaXFaQVFJT0Yrem1rajlIbllUekgw?= =?utf-8?B?d054eGpxZWZwSlp0akh4UDNiWVdUcXFOamZUdXdlNXJSckNVc0VtUUo1bXNz?= =?utf-8?B?azNNSVh0b09KS1A2RFVZbUFsV1cyNzQxVjArc0gva3NwNkVJZE1ESncwMU9x?= =?utf-8?B?d1V0Ynl4c1NkaGhKNkswZXp3OUduWWtlTnQ0WVkvRi9rbHc2d1JBTHNVNnlM?= =?utf-8?B?Rm81ay8yY0VFMURzL3Y2dTZNMVUwM2FPS1FIaUpCVUExQ1FESkZWYTh4ZHA0?= =?utf-8?B?SlgzWEVlZFJHSXUrb3ZXMXM1QjJFQjhhdUZTRWV4bGk1TUp6bmFJNitYUDFV?= =?utf-8?B?T1NyS3I4ZlF6Uk13ajBVcnNJSDhTRFFiYXFFaW5FYVVEU0tUWGdiMkNvUC9S?= =?utf-8?B?M2thYkZLczVUdWhkN0hnQ0hBcGF1eFZMZHpBL20vMFJ3QXBvWkxXZ3JVZDBv?= =?utf-8?B?dnVEd3ZyeUFyN0ZycWlvYWFaMFlOcTRHYUROSDdPTFhOL3hUajh4TWZlZXlG?= =?utf-8?B?TkNYOWVaUnlSalZJMnNwWExFbW83MWgyRk5IWXlQMnhncjE0emNpU1VaVHpQ?= =?utf-8?B?azVaWEdjK2Z3dGxJS2xwdlFEYXBjRDIwb2dGZmxXdkh3V2hkMTM4c2ViVmxi?= =?utf-8?B?dXBrQk5Gc2ZsU2EySFRsYm95SFBIeUMyYU1KSGVhSVc0c3B5cWs1Ym1PYVNy?= =?utf-8?B?a0l5QWErWTNNY1IrTXhNbnk2ZjZKcXkwaFl3U0I2cVZVR0pBY0g5TVdYbG9Z?= =?utf-8?B?R1o3UlVGOXNHVm5UN294a1BRNHdheFc0ekJKeVpmYWhKYWxHNEZ6T1lyMTZu?= =?utf-8?B?b3FPdnJieGI3ZzYyWFV0eVJReVQ5MDZVYW1qa3NQN2ZaNHNyNDBNYndVNG5t?= =?utf-8?B?Mjk1Z0w3ZjQ4dmI5bExDR3JWeHlHS0x1MWZMaThrUHRMNFZVS1hJZGtxaDB4?= =?utf-8?B?YjZ0a2NxdUZKYTFHYXdBZkxNLzViNUpqeGUrNXVicnBpNGFvNEZTQWk0dTM4?= =?utf-8?B?SVJjdXg3NnVhdFR2b2JRU2haODJndWc2YlFpcTdiNWRwbXc4M3NIcHdFWEdt?= =?utf-8?Q?645PhwlDIsDq3YJq+A=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnFDeElKRFN4a2VGSG1uSUx4WnNKd05Pa3k4aE9XQlZxYVp5VkxtaGUvLzVT?= =?utf-8?B?Wjk2U3NzcGE0MFUzSVFCWlUyNCtvK2lRSXh4SW5jemZ6ZHk0MmMvY3RGbW45?= =?utf-8?B?VzJRU1dwREJPZkt5SC9KVDlCTXNYc0cvRFQyK2pIRmF4SlpqOGpXVDk1QktP?= =?utf-8?B?ZTdXb0NVTHFNdng1eGVZZkFXb1F2S1JXaDRONEEwdTZLQi9CVnIyR2IwTVF4?= =?utf-8?B?UnVBSEh3Q3l6Vk9nMml4L3J2a0RqU2l4bnlQdVc1VVVKcG9LSUJEUGl1R1Yr?= =?utf-8?B?Zm9PZDdLNEcwN0xhMjI1dE05dnN2dlZWNWVIUTJwUndFSkdWRURjaVkyN1M1?= =?utf-8?B?aVlITUNkUTF2eERzMzBlS0RGUjBia1ZFVDV3U2tBSnlEenZiU0lxbDBNeUhN?= =?utf-8?B?eXZ2aENocTU2NnhvSmJtazRhcTVuOU9JeTc2VUdySTdHWnFmWVlPYjNhbnRJ?= =?utf-8?B?cG9obStqNllMd013VzRTcWJCT1BCRUNPdVlobFV6cVVBUjNjRWYvUFozS00z?= =?utf-8?B?YUlUME5xcm9Sdys4dG5IU0hYTzV3ZXlsZkI1WUlXMEJBajhzeU5sMm5PZ0pU?= =?utf-8?B?cGFzTzB3STVSRU5Hc2xBWVVBbFhFditLeGU0clRnRUNWWHpXVjVYZDRwSUEx?= =?utf-8?B?Sk1ublB1Nk1WR0NLbnR6d2lxVFFKdDE0dGxjR210bytVcDhzcHpTQkMvT3pG?= =?utf-8?B?MTlpZVFGbVEzQndoVWQzcWhMUHpUajY1UEpLbTU3SXJqdUp2TXkzNCtJM2dE?= =?utf-8?B?SjBjekU3dUhzemlwWG5IQ00xWmM3L085dytNbk5maHdQSHlwWE1sY09kMXY4?= =?utf-8?B?OFNzNmdPVjE5bGJCODZSUTA2U1FNaFphWWJ6L2ViVU1rQWRsaXIvT2lGTW9J?= =?utf-8?B?R3VnOGJGNVRJN1VYdEVXaVRHN0Y1ZlpkQjlDcFhZbmlZSWovTTlrWHlONGJx?= =?utf-8?B?bWxiQ2pBREZLRGdOSWh3OVY5MGd4Q2FzTHBTc09IOUVKYkp6RHVoc1hUWDVh?= =?utf-8?B?S3ZYdkV2LytxendoVlZIdDZrODZkRXB0d1RFMG05M1dNbjZESStnSnBvNndE?= =?utf-8?B?V0VrMGFYYWtsVVFjZmZ4WXBIN0xBb1ZpaVZ4NzVwWmlhMDdzM1RYYm9ZeE5w?= =?utf-8?B?R21vOWkrUVdQVjlraGFjM091ZEhkMHh5OVZjSTg5dStkMHhCS05OS0ZYWlZx?= =?utf-8?B?ZXl1UmtPcVBOZ0R0YlhTMmpQUkxLWGV6SU1lVWpRcDFtUnV2dHhNSUdHTC9P?= =?utf-8?B?RTZrUGFaOXAreEJaK3lZbStSK3FSS3pFMUJWaFU2M3Rac3QrMkt3V0taUXUw?= =?utf-8?B?cWkxMEFtVTNwZGQvbFlNZXdZU25RMXZIRVpHUFlFTFR2Q2ZORkRMaklUM1I3?= =?utf-8?B?RDBXNGZVaVU4L2dhdFhmSkluSTQyQVhrZE1EVlpJMDdJS3k4QnBPVTVnNXkr?= =?utf-8?B?bmJlRUpuc1hBeUsrUVgvVE9aV1BPU0RmeDhTZDZrTWxTL1RsS0FFdFZvVEZi?= =?utf-8?B?RDgyd3ZRY2t2aHMxZ2phSG13U0t5bkFoM1pMSCthb1dDbDhtc3B6YmhpUGdT?= =?utf-8?B?T1c1WUFuNnBkZ0txd0JEQzVOVTA0cVg5dDV5QWFiMjZNOUdDbDlXUCtHbHFZ?= =?utf-8?B?TDFtcG9BMVlQdXNmYVUyVkk3TWEwcHFpSytYbWpHTFdEek1YZmZFa2p5ZVZw?= =?utf-8?B?NnY3cW04bjZLaW43Y3pZL3lwVWE2ZjNUaEpEbXhCNnIyTXY0eE5Hc2kyVVBh?= =?utf-8?B?anZWT3JNeU1rQmJ4VmhHRFBFeVZaOVRhZEZ1U0hwdjYwRmN2YXhtSWxHUWZT?= =?utf-8?B?Ly9aQXMyWXVFalZacUY1TEtsdHQ5T1pNZzlObFlNZDdpU3R1em0rcUxFcC8v?= =?utf-8?B?T3RJK1JNYTNOMDRqeVZXVjEwS1NNMi84alAwQWVuUHpKV1kyL0hrejBpNkdi?= =?utf-8?B?L2ttc1dXa0JjQXNGNzZFSGxKdE8yUXk5cnoyWXY5bUlUK1c1bE1yM0UybXpk?= =?utf-8?B?WmNlVUEzU2JvVjRGV3N0YkpGeWVqOXF0bW5xd1F1aWtWTExUdk9YS0d1SDJo?= =?utf-8?B?ZC9qNkptY2NsT1NLNDdaWUxUZ2d2TzFGN2RPcW5yemwzSkh1QXRrcklNNTg1?= =?utf-8?B?MnF0V3QvTzFkZXRieWNFdUR5ZjcydHRITmhqQVlFWmZ5dmoyeTVpTmJjdFhD?= =?utf-8?B?b1E9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6f64fc-9dbd-4da9-8570-08dcc345fcf5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2024 07:34:14.6130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ceAoe7odhWhb9h5pdljWen5z7nlVv4tkJDwgUplPBZKDxv2Td/n0c31K1LtMST4R6/Vd96IBUt+kVh4bQigNdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8789 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 07-08-2024 21:08, Ferruh Yigit wrote: > On 8/1/2024 11:53 AM, Hemant Agrawal wrote: >> From: Vanshika Shukla <vanshika.shukla@nxp.com> >> >> TX confirmation provides dedicated confirmation >> queues for transmitted packets. These queues are >> used by software to get the status and release >> transmitted packets buffers. >> >> Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com> >> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> >> --- >> drivers/net/dpaa/dpaa_ethdev.c | 45 ++++++++++++++++++++++------- >> drivers/net/dpaa/dpaa_ethdev.h | 3 +- >> drivers/net/dpaa/dpaa_rxtx.c | 52 ++++++++++++++++++++++++++++++++++ >> drivers/net/dpaa/dpaa_rxtx.h | 2 ++ >> 4 files changed, 90 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c >> index 90b34e42f2..9ffb8c578c 100644 >> --- a/drivers/net/dpaa/dpaa_ethdev.c >> +++ b/drivers/net/dpaa/dpaa_ethdev.c >> @@ -1826,9 +1826,15 @@ static int dpaa_tx_queue_init(struct qman_fq *fq, >> opts.fqd.dest.wq = DPAA_IF_TX_PRIORITY; >> opts.fqd.fq_ctrl = QM_FQCTRL_PREFERINCACHE; >> opts.fqd.context_b = 0; >> +#if defined(RTE_LIBRTE_IEEE1588) >> + opts.fqd.context_a.lo = 0; >> + opts.fqd.context_a.hi = fman_dealloc_bufs_mask_hi; >> +#else >> > There is already a target to remove 'RTE_LIBRTE_IEEE1588' macro [1], > waiting for drivers clean up, lets not introduce more of it. > > Can you use runtime configuration to enable PTP support? > OK, we have made it device args based control. > > > [1] > https://patches.dpdk.org/project/dpdk/patch/20230203132810.14187-1-thomas@monjalon.net/