From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com [208.91.2.12]) by dpdk.org (Postfix) with ESMTP id 0BBF968B5 for ; Mon, 13 Oct 2014 20:35:01 +0200 (CEST) Received: from sc9-mailhost2.vmware.com (sc9-mailhost2.vmware.com [10.113.161.72]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id B6EC5282B4; Mon, 13 Oct 2014 11:42:32 -0700 (PDT) Received: from EX13-CAS-005.vmware.com (EX13-CAS-005.vmware.com [10.113.191.55]) by sc9-mailhost2.vmware.com (Postfix) with ESMTP id B1784B1587; Mon, 13 Oct 2014 11:42:32 -0700 (PDT) Received: from EX13-MBX-024.vmware.com (10.113.191.44) by EX13-MBX-012.vmware.com (10.113.191.32) with Microsoft SMTP Server (TLS) id 15.0.775.38; Mon, 13 Oct 2014 11:42:32 -0700 Received: from EX13-MBX-026.vmware.com (10.113.191.46) by EX13-MBX-024.vmware.com (10.113.191.44) with Microsoft SMTP Server (TLS) id 15.0.775.38; Mon, 13 Oct 2014 11:42:19 -0700 Received: from EX13-MBX-026.vmware.com ([fe80::858b:7f42:fd7c:703d]) by EX13-MBX-026.vmware.com ([fe80::858b:7f42:fd7c:703d%17]) with mapi id 15.00.0775.031; Mon, 13 Oct 2014 11:42:19 -0700 From: Yong Wang To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping Thread-Index: AQHP5q+f3kqeQUkLF0OqkGkH2ZSdUZwuOPwAgAAiocU= Date: Mon, 13 Oct 2014 18:42:18 +0000 Message-ID: References: <1413181389-14887-1-git-send-email-yongwang@vmware.com> <1413181389-14887-2-git-send-email-yongwang@vmware.com>, <20141013113146.202b5eb3@uryu.home.lan> In-Reply-To: <20141013113146.202b5eb3@uryu.home.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.113.160.246] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Oct 2014 18:35:01 -0000 Are you referring to the patch as a whole or your comment is about the rese= t of vlan_tci on the "else" (no vlan tags stripped) path? I am not sure I = get your comments here. This patch simply fixes a bug on the rx vlan strip= ping path (where valid vlan_tci stripped is overwritten unconditionally lat= er on the rx path in the original vmxnet3 pmd driver). All the other pmd dr= ivers are doing the same thing in terms of translating descriptor status to= rte_mbuf flags for vlan stripping.=0A= ________________________________________=0A= From: Stephen Hemminger =0A= Sent: Monday, October 13, 2014 2:31 AM=0A= To: Yong Wang=0A= Cc: dev@dpdk.org=0A= Subject: Re: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping=0A= =0A= On Sun, 12 Oct 2014 23:23:05 -0700=0A= Yong Wang wrote:=0A= =0A= > Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped.=0A= >=0A= > Signed-off-by: Yong Wang =0A= =0A= Since vlan_tci is initialized to zero by rte_pktmbuf layer,=0A= the driver shouldn't be messing with it.=0A= =0A=