From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0A0D93237 for ; Mon, 30 Jan 2017 18:42:26 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 30 Jan 2017 09:42:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,312,1477983600"; d="scan'208";a="59865133" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga006.fm.intel.com with ESMTP; 30 Jan 2017 09:42:25 -0800 To: "Wiles, Keith" References: <20170129021205.36860-1-keith.wiles@intel.com> <2c430141-94c1-5482-7fc2-94f5908b41e0@intel.com> <6B37A978-0F89-4299-86E1-5697392EDC49@intel.com> Cc: "dev@dpdk.org" From: Ferruh Yigit Message-ID: Date: Mon, 30 Jan 2017 17:42:24 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <6B37A978-0F89-4299-86E1-5697392EDC49@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 17:42:27 -0000 On 1/30/2017 2:34 PM, Wiles, Keith wrote: > >> On Jan 30, 2017, at 5:00 AM, Yigit, Ferruh wrote: >> >> On 1/29/2017 2:12 AM, Keith Wiles wrote: >>> The tap driver setup both rx and tx file descriptors when the >>> rte_eth_rx_queue_setup() causing the tx to be closed when tx setup >>> was called. >> >> Can you please describe the problem more. >> Without this patch rx->fd == tx->fd, with this patch rx and tx has >> different file descriptors. > > Let me look at this more, I am getting the same FD for both. Must be something else going on. After patch, tun_alloc() called twice, one for Rx_q and other for Tx_q. And tun_alloc does open() to "/dev/net/tun", I expect they get different file descriptors. And if they have same FD, won't this cause same problem, rx_queue_setup() will close the FD, if Tx_q has same FD it will have invalid descriptor. > >> >> What was the wrong with rx and tx having same fd? >> >> As far as I can see, rte_eth_rx_queue_setup() won't close tx->fd, that >> function will do nothing if rx or tx has valid fd. > > The rte_eth_rx_queue_setup() look at line 1146 if rxq has a value then release it, which happens on both Rx/Tx code > > rxq = dev->data->rx_queues; > if (rxq[rx_queue_id]) { > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, > -ENOTSUP); > (*dev->dev_ops->rx_queue_release)(rxq[rx_queue_id]); > rxq[rx_queue_id] = NULL; > } Got it thanks, I missed (relatively new) above code piece. > > if (rx_conf == NULL) > rx_conf = &dev_info.default_rxconf; > > ret = (*dev->dev_ops->rx_queue_setup)(dev, rx_queue_id, nb_rx_desc, > socket_id, rx_conf, mp); > >> >>> >>> Signed-off-by: Keith Wiles >> >> <...> > > Regards, > Keith >