From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 27BBF1B4E4; Wed, 10 Oct 2018 12:25:27 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76FA281104; Wed, 10 Oct 2018 10:25:26 +0000 (UTC) Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0F4310018FF; Wed, 10 Oct 2018 10:25:20 +0000 (UTC) To: Tiwei Bie Cc: dev@dpdk.org, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com, dgilbert@redhat.com, stable@dpdk.org References: <20181009205426.21219-1-maxime.coquelin@redhat.com> <20181009205426.21219-16-maxime.coquelin@redhat.com> <20181010101305.GC2956@debian> From: Maxime Coquelin Message-ID: Date: Wed, 10 Oct 2018 12:25:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181010101305.GC2956@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 10 Oct 2018 10:25:26 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v5 15/19] vhost: send userfault range addresses back to qemu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 10:25:27 -0000 On 10/10/2018 12:13 PM, Tiwei Bie wrote: > On Tue, Oct 09, 2018 at 10:54:22PM +0200, Maxime Coquelin wrote: >> Signed-off-by: Dr. David Alan Gilbert >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost_user.c | 49 ++++++++++++++++++++++++++++++++--- >> 1 file changed, 46 insertions(+), 3 deletions(-) >> >> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c >> index 96290fdb4..170d258c4 100644 >> --- a/lib/librte_vhost/vhost_user.c >> +++ b/lib/librte_vhost/vhost_user.c >> @@ -79,6 +79,11 @@ static const char *vhost_message_str[VHOST_USER_MAX] = { >> [VHOST_USER_POSTCOPY_LISTEN] = "VHOST_USER_POSTCOPY_LISTEN", >> }; >> >> +static int >> +send_vhost_reply(int sockfd, struct VhostUserMsg *msg); >> +static int >> +read_vhost_message(int sockfd, struct VhostUserMsg *msg); > > Something like this looks better: > > static int send_vhost_reply(int sockfd, struct VhostUserMsg *msg); > static int read_vhost_message(int sockfd, struct VhostUserMsg *msg); > Agree.