From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] net/bnxt: update HWRM structures
Date: Wed, 30 Sep 2020 23:17:32 +0100 [thread overview]
Message-ID: <eba08c82-f93d-7ff8-6b84-47e47a323612@intel.com> (raw)
In-Reply-To: <20200929205935.20432-3-ajit.khaparde@broadcom.com>
On 9/29/2020 9:59 PM, Ajit Khaparde wrote:
> HWRM API to a newer 1.10.1.70 version.
>
> Few fields have been renamed because of this.
> rx_err_pkt -> rx_discard_pkts
> rx_drop_pkts -> rx_error_pkts
>
> tx_err_pkts -> tx_discard_pkts
> tx_drop_pkts -> tx_error_pkts
>
> link_signal_mode -> active_fec_signal_mode
>
> tx_bd_long_hi.mss -> tx_bd_long_hi.kid_or_ts_high_mss
> tx_bd_long_hi.hdr_size -> tx_bd_long_hi.kid_or_ts_low_hdr_size
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
There are some basic checkpatch errors like spelling mistakes, can you please
take care of them:
http://mails.dpdk.org/archives/test-report/2020-September/155556.html
Also some of the comment are too long, can you please check them too, again
above checkpatch link has them listed.
next prev parent reply other threads:[~2020-09-30 22:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 20:59 [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD Ajit Khaparde
2020-09-29 20:59 ` [dpdk-dev] [PATCH 1/3] net/bnxt: add support for RSS hash selection Ajit Khaparde
2020-09-29 20:59 ` [dpdk-dev] [PATCH 2/3] net/bnxt: update HWRM structures Ajit Khaparde
2020-09-30 22:17 ` Ferruh Yigit [this message]
2020-10-01 3:56 ` [dpdk-dev] [PATCH 0/2] patchset for bnxt PMD Ajit Khaparde
2020-10-01 3:56 ` [dpdk-dev] [PATCH 1/2] net/bnxt: add support for RSS hash selection Ajit Khaparde
2020-10-01 3:56 ` [dpdk-dev] [PATCH 2/2] net/bnxt: update HWRM structures Ajit Khaparde
2020-10-01 9:12 ` [dpdk-dev] [PATCH 0/2] patchset for bnxt PMD Ajit Khaparde
2020-09-29 20:59 ` [dpdk-dev] [PATCH 3/3] doc: fix vector mode info for bnxt Ajit Khaparde
2020-09-30 17:28 ` Lance Richardson
2020-09-30 17:37 ` Ajit Khaparde
2020-09-30 17:16 ` [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD Ajit Khaparde
2020-09-30 21:29 ` Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eba08c82-f93d-7ff8-6b84-47e47a323612@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).