From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 146D34A65 for ; Fri, 9 Dec 2016 14:35:38 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP; 09 Dec 2016 05:35:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="40837812" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by fmsmga006.fm.intel.com with ESMTP; 09 Dec 2016 05:35:37 -0800 To: Rasesh Mody , dev@dpdk.org References: <1480746909-25686-1-git-send-email-Rasesh.Mody@cavium.com> Cc: Dept-EngDPDKDev@cavium.com From: Ferruh Yigit Message-ID: Date: Fri, 9 Dec 2016 13:35:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480746909-25686-1-git-send-email-Rasesh.Mody@cavium.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to get vendor/device id info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 13:35:39 -0000 Hi Rasesh, On 12/3/2016 6:35 AM, Rasesh Mody wrote: > Fixes: ec94dbc5 ("qede: add base driver") > > Signed-off-by: Rasesh Mody Related to the commit logs of this patchset. Many people, including me, won't know technical details of your driver as you do. >>From below patch, I also can see vendor_id and device_id get, which were not there before. But I have no clue why? Or what happens when you don't have them, or what works fine when you have them. Overall a little context helps a lot to understand what is really fixed, and what happens if not fixed. For example in patch 8/8, it is a one line easy modification :), but there is no way that I can understand what really it does, but commit log comes to help there, and describes it really fixes VF over legacy PF, by VF asking a FW overwrite instead of failing on PF reject msg. So patch subject can be here: fix VF over legacy PF. Please trying to provide more context on fixes. Also you need to add CC:stable@dpdk.org to commit log, so that git send-email ensures this fixes also sent to stable trees. Thanks, > --- > drivers/net/qede/qede_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index 9c2a5eae..b9a325df 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -2071,6 +2071,10 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) > > rte_eth_copy_pci_info(eth_dev, pci_dev); > > + /* @DPDK */ > + edev->vendor_id = pci_dev->id.vendor_id; > + edev->device_id = pci_dev->id.device_id; > + > qed_ops = qed_get_eth_ops(); > if (!qed_ops) { > DP_ERR(edev, "Failed to get qed_eth_ops_pass\n"); >