DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Kinsella, Ray" <mdr@ashroe.eu>
To: Gage Eads <gage.eads@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, david.marchand@redhat.com,
	nhorman@tuxdriver.com, phil.yang@arm.com,
	honnappa.nagarahalli@arm.com
Subject: Re: [dpdk-dev] [PATCH] stack: remove experimental tag from API
Date: Mon, 5 Oct 2020 10:53:40 +0100
Message-ID: <ebacf674-affa-73d3-7972-807e9a8350b3@ashroe.eu> (raw)
In-Reply-To: <4d6110f8-fc91-2622-1b10-2cd881f512c6@ashroe.eu>



On 05/10/2020 10:07, Kinsella, Ray wrote:
> A nit and some questions below, thanks Ray K.
> 
> On 30/09/2020 22:39, Gage Eads wrote:
>> The stack library was first released in 19.05, and its interfaces have been
>> stable since their initial introduction. This commit promotes the full
>> interface to stable, starting with the 20.11 major version.
>>
>> Signed-off-by: Gage Eads <gage.eads@intel.com>
>> Acked-by: David Marchand <david.marchand@redhat.com>
>> ---
>>  doc/guides/rel_notes/release_20_11.rst |  3 +++
>>  lib/librte_stack/rte_stack.h           | 32 --------------------------------
>>  lib/librte_stack/rte_stack_lf.h        |  2 --
>>  lib/librte_stack/rte_stack_std.h       |  3 ---
>>  lib/librte_stack/rte_stack_version.map |  2 +-
>>  5 files changed, 4 insertions(+), 38 deletions(-)
> NIT: You are missing the v3 in the subject line, doesn't require a fix. 
> 
[SNIP]

So after chatting with David, it looks like there is no _nice_ way to indicate that 
some inlines are "internal" while others are "public". 
Something to look at in future maybe.

>>  
>> diff --git a/lib/librte_stack/rte_stack_lf.h b/lib/librte_stack/rte_stack_lf.h
>> index e67630c27..eb106e64e 100644
>> --- a/lib/librte_stack/rte_stack_lf.h
>> +++ b/lib/librte_stack/rte_stack_lf.h
>> @@ -27,7 +27,6 @@
>>   * @return
>>   *   Actual number of objects enqueued.
>>   */
>> -__rte_experimental
> 
> This looks like an internal function, should it be __rte_internal?
> 
>>  static __rte_always_inline unsigned int
>>  __rte_stack_lf_push(struct rte_stack *s,
>>  		    void * const *obj_table,
>> @@ -66,7 +65,6 @@ __rte_stack_lf_push(struct rte_stack *s,
>>   * @return
>>   *   - Actual number of objects popped.
>>   */
>> -__rte_experimental
> 
> This looks like an internal function, should it be __rte_internal?
> 
>>  static __rte_always_inline unsigned int
>>  __rte_stack_lf_pop(struct rte_stack *s, void **obj_table, unsigned int n)
>>  {
>> diff --git a/lib/librte_stack/rte_stack_std.h b/lib/librte_stack/rte_stack_std.h
>> index 7142cbf8e..ae28add5c 100644
>> --- a/lib/librte_stack/rte_stack_std.h
>> +++ b/lib/librte_stack/rte_stack_std.h
>> @@ -19,7 +19,6 @@
>>   * @return
>>   *   Actual number of objects pushed (either 0 or *n*).
>>   */
>> -__rte_experimental
> 
> This looks like an internal function, should it be __rte_internal?
> 
>>  static __rte_always_inline unsigned int
>>  __rte_stack_std_push(struct rte_stack *s, void * const *obj_table,
>>  		     unsigned int n)
>> @@ -59,7 +58,6 @@ __rte_stack_std_push(struct rte_stack *s, void * const *obj_table,
>>   * @return
>>   *   Actual number of objects popped (either 0 or *n*).
>>   */
>> -__rte_experimental
> 
> This looks like an internal function, should it be __rte_internal?
> 
>>  static __rte_always_inline unsigned int
>>  __rte_stack_std_pop(struct rte_stack *s, void **obj_table, unsigned int n)
>>  {
>> @@ -94,7 +92,6 @@ __rte_stack_std_pop(struct rte_stack *s, void **obj_table, unsigned int n)
>>   * @return
>>   *   The number of used entries in the stack.
>>   */
>> -__rte_experimental
>>  static __rte_always_inline unsigned int
>>  __rte_stack_std_count(struct rte_stack *s)
>>  {
>> diff --git a/lib/librte_stack/rte_stack_version.map b/lib/librte_stack/rte_stack_version.map
>> index 6662679c3..8c4ca0245 100644
>> --- a/lib/librte_stack/rte_stack_version.map
>> +++ b/lib/librte_stack/rte_stack_version.map
>> @@ -1,4 +1,4 @@
>> -EXPERIMENTAL {
>> +DPDK_21 {
>>  	global:
>>  
>>  	rte_stack_create;
>>

Acked-by: Ray Kinsella <mdr@ashroe.eu>




  reply	other threads:[~2020-10-05  9:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28  1:04 Gage Eads
2020-05-28  5:46 ` Ray Kinsella
2020-05-28  8:10   ` Thomas Monjalon
2020-05-28  8:22     ` Ray Kinsella
2020-05-28 14:18     ` Eads, Gage
2020-05-28 14:33       ` Bruce Richardson
2020-05-28 15:04 ` [dpdk-dev] [20.11] [PATCH v2] " Gage Eads
2020-05-28 15:29   ` Thomas Monjalon
2020-09-30 18:49   ` David Marchand
2020-09-30 21:39 ` [dpdk-dev] [PATCH] " Gage Eads
2020-10-05  9:07   ` Kinsella, Ray
2020-10-05  9:53     ` Kinsella, Ray [this message]
2020-10-05 12:57   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebacf674-affa-73d3-7972-807e9a8350b3@ashroe.eu \
    --to=mdr@ashroe.eu \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=nhorman@tuxdriver.com \
    --cc=phil.yang@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git