From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAB25A04DC; Tue, 20 Oct 2020 16:52:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2486EAD50; Tue, 20 Oct 2020 16:52:36 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3105FAD4F for ; Tue, 20 Oct 2020 16:52:33 +0200 (CEST) IronPort-SDR: g8nMuwTRVy07/6y+xUiJFdL1fK9M+B6A+CD30qLCaNIimqawcJK7DXhUz40txiCpW7e7uXBq4u lV3XGTFF+a6w== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="164608836" X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="164608836" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 07:52:32 -0700 IronPort-SDR: VMR5McxmEK9LCzgkNgAajGQf7ae/4o/TWVkBJLkR0swMLhonzxjPP1uGrogUGijg1YXWkIpZ47 UuECq1xr9TdA== X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="347894793" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.249]) ([10.213.247.249]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 07:52:29 -0700 To: Andrew Rybchenko , Ray Kinsella , Neil Horman , Hemant Agrawal , Sachin Saxena , Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org, Xiaoyun Li References: <1603030152-13451-1-git-send-email-arybchenko@solarflare.com> <1603030152-13451-15-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Tue, 20 Oct 2020 15:52:26 +0100 MIME-Version: 1.0 In-Reply-To: <1603030152-13451-15-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/18/2020 3:09 PM, Andrew Rybchenko wrote: > The legacy filter API, including rte_eth_dev_filter_supported() and > rte_eth_dev_filter_ctrl() is removed. Flow API should be used. > > examples/tep_termination build is broken. > > Signed-off-by: Andrew Rybchenko <...> > --- a/lib/librte_ethdev/rte_eth_ctrl.h > +++ b/lib/librte_ethdev/rte_eth_ctrl.h > @@ -43,17 +43,7 @@ enum rte_filter_type { > * Generic operations on filters > */ > enum rte_filter_op { > - /** used to check whether the type filter is supported */ > - RTE_ETH_FILTER_NOP = 0, > - RTE_ETH_FILTER_ADD, /**< add filter entry */ > - RTE_ETH_FILTER_UPDATE, /**< update filter entry */ > - RTE_ETH_FILTER_DELETE, /**< delete filter entry */ > - RTE_ETH_FILTER_FLUSH, /**< flush all entries */ > - RTE_ETH_FILTER_GET, /**< get filter entry */ > - RTE_ETH_FILTER_SET, /**< configurations */ > - RTE_ETH_FILTER_INFO, /**< retrieve information */ > - RTE_ETH_FILTER_STATS, /**< retrieve statistics */ > - RTE_ETH_FILTER_OP_MAX > + RTE_ETH_FILTER_GET, /**< get flow API ops */ > }; Thanks Andrew working on this, It would be nice to have it in -rc1 to be tested better but it was received late for it. I suspect there will be more cleanup here or there by time. Since there will be a new version, What do you thinks creating a new dev_ops, like '.flow_ops_get' and replace '.filter_ctrl' in this patchset? This makes the naming/logic more clear, also allows removing a above 'RTE_ETH_FILTER_GET'.