From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 795D25F59 for ; Wed, 21 Mar 2018 20:08:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2018 12:08:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,341,1517904000"; d="scan'208";a="213440981" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.63]) ([10.237.221.63]) by fmsmga006.fm.intel.com with ESMTP; 21 Mar 2018 12:08:30 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20180306194020.71231-1-ajit.khaparde@broadcom.com> Cc: Shahaf Shuler From: Ferruh Yigit Message-ID: Date: Wed, 21 Mar 2018 19:08:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180306194020.71231-1-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bnxt: switch to the new offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 19:08:33 -0000 On 3/6/2018 7:40 PM, Ajit Khaparde wrote: > Update bnxt PMD to new ethdev offloads API. > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 59 +++++++++++++++++++++++++++++------------- > 1 file changed, 41 insertions(+), 18 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 21c46f833..cca4ef40c 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -146,6 +146,27 @@ static const struct rte_pci_id bnxt_pci_id_map[] = { > ETH_RSS_NONFRAG_IPV6_TCP | \ > ETH_RSS_NONFRAG_IPV6_UDP) > > +#define BNXT_DEV_TX_OFFLOAD_SUPPORT (DEV_TX_OFFLOAD_VLAN_INSERT | \ > + DEV_TX_OFFLOAD_IPV4_CKSUM | \ > + DEV_TX_OFFLOAD_TCP_CKSUM | \ > + DEV_TX_OFFLOAD_UDP_CKSUM | \ > + DEV_TX_OFFLOAD_TCP_TSO | \ > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | \ > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | \ > + DEV_TX_OFFLOAD_GRE_TNL_TSO | \ > + DEV_TX_OFFLOAD_IPIP_TNL_TSO | \ > + DEV_TX_OFFLOAD_GENEVE_TNL_TSO | \ > + DEV_TX_OFFLOAD_MULTI_SEGS) > + > +#define BNXT_DEV_RX_OFFLOAD_SUPPORT (DEV_RX_OFFLOAD_VLAN_FILTER | \ > + DEV_RX_OFFLOAD_VLAN_STRIP | \ > + DEV_RX_OFFLOAD_IPV4_CKSUM | \ > + DEV_RX_OFFLOAD_UDP_CKSUM | \ > + DEV_RX_OFFLOAD_TCP_CKSUM | \ > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | \ > + DEV_RX_OFFLOAD_JUMBO_FRAME | \ > + DEV_RX_OFFLOAD_CRC_STRIP) > + > static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask); > static void bnxt_print_link_info(struct rte_eth_dev *eth_dev); > > @@ -430,21 +451,14 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, > dev_info->min_rx_bufsize = 1; > dev_info->max_rx_pktlen = BNXT_MAX_MTU + ETHER_HDR_LEN + ETHER_CRC_LEN > + VLAN_TAG_SIZE; > - dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP | > - DEV_RX_OFFLOAD_IPV4_CKSUM | > - DEV_RX_OFFLOAD_UDP_CKSUM | > - DEV_RX_OFFLOAD_TCP_CKSUM | > - DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM; > - dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT | > - DEV_TX_OFFLOAD_IPV4_CKSUM | > - DEV_TX_OFFLOAD_TCP_CKSUM | > - DEV_TX_OFFLOAD_UDP_CKSUM | > - DEV_TX_OFFLOAD_TCP_TSO | > - DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > - DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > - DEV_TX_OFFLOAD_GRE_TNL_TSO | > - DEV_TX_OFFLOAD_IPIP_TNL_TSO | > - DEV_TX_OFFLOAD_GENEVE_TNL_TSO; > + > + dev_info->rx_queue_offload_capa = BNXT_DEV_RX_OFFLOAD_SUPPORT; Hi Ajit, Is bnxt supports queue level offloads? If not PMD should return 0 as rx_queue_offload_capa and tx_queue_offload_capa. > + dev_info->rx_offload_capa = BNXT_DEV_RX_OFFLOAD_SUPPORT; > + if (bp->flags & BNXT_FLAG_PTP_SUPPORTED) > + dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TIMESTAMP; > + dev_info->tx_queue_offload_capa = BNXT_DEV_TX_OFFLOAD_SUPPORT; > + dev_info->tx_offload_capa = BNXT_DEV_TX_OFFLOAD_SUPPORT; > + dev_info->flow_type_rss_offloads = BNXT_ETH_RSS_SUPPORT; > > /* *INDENT-OFF* */ > dev_info->default_rxconf = (struct rte_eth_rxconf) { > @@ -454,7 +468,8 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, > .wthresh = 0, > }, > .rx_free_thresh = 32, > - .rx_drop_en = 0, > + /* If no descriptors available, pkts are dropped by default */ > + .rx_drop_en = 1, > }; > > dev_info->default_txconf = (struct rte_eth_txconf) { > @@ -465,8 +480,6 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, > }, > .tx_free_thresh = 32, > .tx_rs_thresh = 32, > - .txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | > - ETH_TXQ_FLAGS_NOOFFLOADS, > }; > eth_dev->data->dev_conf.intr_conf.lsc = 1; > > @@ -510,6 +523,16 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, > static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev) > { > struct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private; > + uint64_t tx_offloads = eth_dev->data->dev_conf.txmode.offloads; > + uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads; > + > + if (tx_offloads != BNXT_DEV_TX_OFFLOAD_SUPPORT) > + PMD_DRV_LOG(ERR, "Tx offloads requested 0x%lx supported 0x%x\n", > + tx_offloads, BNXT_DEV_TX_OFFLOAD_SUPPORT); Isn't is possible that application request only a subset of the supported offloads? And should API return an error for this case? > + > + if (rx_offloads != BNXT_DEV_RX_OFFLOAD_SUPPORT) > + PMD_DRV_LOG(ERR, "Rx offloads requested 0x%lx supported 0x%x\n", > + rx_offloads, BNXT_DEV_RX_OFFLOAD_SUPPORT); > > bp->rx_queues = (void *)eth_dev->data->rx_queues; > bp->tx_queues = (void *)eth_dev->data->tx_queues; >