DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Pei, Andy" <andy.pei@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xia, Chenbo" <chenbo.xia@intel.com>
Subject: RE: [PATCH 1/3] vdpa/ifc: fix log info mismatch
Date: Mon, 13 Dec 2021 07:26:40 +0000	[thread overview]
Message-ID: <ebe696972548429ea570ba569205d9c1@intel.com> (raw)
In-Reply-To: <DM8PR11MB57517BF2F3EBB5754AC60276B8749@DM8PR11MB5751.namprd11.prod.outlook.com>

Hi Xiao,

"Fixes: " line will be added in V2.
Thanks for reply.

-----Original Message-----
From: Wang, Xiao W <xiao.w.wang@intel.com> 
Sent: Monday, December 13, 2021 2:55 PM
To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
Cc: Xia, Chenbo <chenbo.xia@intel.com>
Subject: RE: [PATCH 1/3] vdpa/ifc: fix log info mismatch

Hi Andy,

Thanks for the patch.
You need to add the "Fixes: " line.

BRs,
Xiao

> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Monday, December 13, 2021 12:29 PM
> To: dev@dpdk.org
> Cc: Pei, Andy <andy.pei@intel.com>; Xia, Chenbo 
> <chenbo.xia@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: [PATCH 1/3] vdpa/ifc: fix log info mismatch
> 
> fix log info mismatch.
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/vdpa/ifc/base/ifcvf.c 
> b/drivers/vdpa/ifc/base/ifcvf.c index 721cb1d..d10c1fd 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.c
> +++ b/drivers/vdpa/ifc/base/ifcvf.c
> @@ -94,12 +94,14 @@
>  		return -1;
>  	}
> 
> -	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
> -			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
> -			"multiplier: %u\n",
> -			hw->common_cfg, hw->dev_cfg,
> -			hw->isr, hw->notify_base,
> -			hw->notify_off_multiplier);
> +	DEBUGOUT("capability mapping:\n"
> +		 "common cfg: %p\n"
> +		 "notify base: %p\n"
> +		 "isr cfg: %p\n"
> +		 "device cfg: %p\n"
> +		 "multiplier: %u\n",
> +		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
> +		 hw->notify_off_multiplier);
> 
>  	return 0;
>  }
> --
> 1.8.3.1



  reply	other threads:[~2021-12-13  7:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13  4:29 Andy Pei
2021-12-13  6:36 ` [PATCH v2] " Andy Pei
2021-12-13  7:29   ` Wang, Xiao W
2021-12-13  7:36     ` Pei, Andy
2021-12-13  6:54 ` [PATCH 1/3] " Wang, Xiao W
2021-12-13  7:26   ` Pei, Andy [this message]
2021-12-13  7:00 ` [PATCH v3] " Andy Pei
2022-01-14  7:22   ` Xia, Chenbo
2022-01-27  5:14   ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebe696972548429ea570ba569205d9c1@intel.com \
    --to=andy.pei@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).