From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2AB3A04B7; Wed, 14 Oct 2020 10:32:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1467D1DC67; Wed, 14 Oct 2020 10:32:31 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7F67F1C1BB for ; Wed, 14 Oct 2020 10:32:29 +0200 (CEST) IronPort-SDR: vaaEInubt1rzFwnjG95zUbH3HvMcc2HZXunNjtDLF4AMeM10rMGeJdCcsW0ZXuphYqzOx/POh9 Za4uMa9ep+VA== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="162595427" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="162595427" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 01:32:27 -0700 IronPort-SDR: fEqGORlZRBib6naaqEaCvdKUreIYIJL9/m457tuTsjIdvxb6kFVbYRbbiiGqF9mds1K6m19eIW futFpj9nl+aA== X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="521343087" Received: from rsimofi-mobl1.ger.corp.intel.com (HELO [10.251.83.231]) ([10.251.83.231]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 01:32:25 -0700 To: Jerin Jacob , "Ananyev, Konstantin" Cc: "Van Haaren, Harry" , Honnappa Nagarahalli , "Richardson, Bruce" , "dev@dpdk.org" , "jerinj@marvell.com" , nd References: <20200908105211.10066-1-radu.nicolau@intel.com> <46118f3466274596a663d7d44abb680a@intel.com> <20200925102805.GD923@bricha3-MOBL.ger.corp.intel.com> From: "Nicolau, Radu" Message-ID: Date: Wed, 14 Oct 2020 09:32:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2020 8:11 PM, Jerin Jacob wrote: > On Wed, Oct 7, 2020 at 4:22 PM Ananyev, Konstantin > wrote: >>> On 10/6/2020 11:13 AM, Ananyev, Konstantin wrote: >>>>>> -----Original Message----- >>>>>> From: Jerin Jacob >>>>>> Sent: Monday, October 5, 2020 5:35 PM >>>>>> To: Nicolau, Radu >>>>>> Cc: Honnappa Nagarahalli ; Richardson, Bruce >>>>>> ; Ananyev, Konstantin >>>>>> ; Van Haaren, Harry >>>>>> ; dev@dpdk.org; jerinj@marvell.com; nd >>>>>> >>>>>> Subject: Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements >>>>>> >>>>>> On Tue, Sep 29, 2020 at 2:32 PM Nicolau, Radu wrote: > a concern that another library not uses public ring API, >>>> but instead accesses ring internals directly. Obviously such coding practice is not welcomed >>>> as it makes harder to maintain/extend ring library in future. >>>> About 2) - these new API can(/shoud) be marked an experimental anyway. >>>> As another thing - it is still unclear what a performance gain we are talking about here. >>>> Is it really worth it comparing to just using SP/SC? >>> The change itself came after I analyzed the memory bound sections of the >>> code, and I just did a quick test, I got about 3.5% improvement in >>> throughput, maybe not so much but significant for such a small change, >>> and depending on the usecase it may be more. >>> >>> As for the implementation itself, I would favour having a custom ring >>> like container in the PMD code, this will solve the issue of using >>> rte_ring internals while still allow for full optimisation. If this is >>> acceptable, I will follow up by tomorrow. >> Sounds ok to me. > Nicolau Radu, > > Could you supersede this patch, if the plan is to send it to a new > version based on a custom ring? The v3 (https://patchwork.dpdk.org/patch/79879/) sent last week implements the custom ring and does not use the rte_ring internals. v1 and v2 are superseded.