DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Montorsi, Francesco" <fmontorsi@empirix.com>
To: Olivier MATZ <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] "cannot use T= with gcov target" when doing "makefile clean" with DPDK-2.1.0
Date: Tue, 29 Sep 2015 16:06:52 +0000	[thread overview]
Message-ID: <ebf5b03476d8418dbc0417768af362a6@bilemail1.empirix.com> (raw)
In-Reply-To: <55ED4361.8050008@6wind.com>

Hi Olivier,
Sorry for the delay:

> -----Original Message-----
> From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> I had a look to your test case, I think the second command is not correct. The
> T= parameter is not allowed for the clean target. It should be something like
> this:
> 
>   # configure a workspace using template specified by T= in the
>   # directory specified by O=
>   make T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc config
> 
>   # clean the directory specified by O=
>   make O=x86_64-native-linuxapp-gcc clean
> 
> See "make help" for details.
> 
> 
> I think the proper patch would be to add the following lines on the top of
> rte.sdkbuild.mk:
> 
> 	ifdef T
> 	ifeq ("$(origin T)", "command line")
> 	$(error "Cannot use T= with a build/clean target")
> 	endif
> 	endif
> 
> 
> It would then display the proper error message.
> Can you have a try?

You're right. It was not clear to me that T= is coinceived as option of the "config" target only, but it makes absolutely sense.
I added the code you posted on ret.sdkbuild.mk and it works just fine, making this usage case more clear... I just submitted a patch for that.

Thanks,
Francesco

      reply	other threads:[~2015-09-29 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28  9:06 Montorsi, Francesco
2015-09-02 14:32 ` Mcnamara, John
2015-09-04  8:50   ` Montorsi, Francesco
2015-09-07  7:57 ` Olivier MATZ
2015-09-29 16:06   ` Montorsi, Francesco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebf5b03476d8418dbc0417768af362a6@bilemail1.empirix.com \
    --to=fmontorsi@empirix.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).