From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bilemail1.empirix.com (bilemail1.empirix.com [208.67.76.245]) by dpdk.org (Postfix) with ESMTP id D55DC5A44 for ; Tue, 29 Sep 2015 18:07:23 +0200 (CEST) Received: from BILEMAIL1.empirix.com (10.17.8.30) by bilemail1.empirix.com (10.17.8.30) with Microsoft SMTP Server (TLS) id 15.0.775.38; Tue, 29 Sep 2015 12:06:52 -0400 Received: from BILEMAIL1.empirix.com ([fe80::f9e0:9293:2523:f021]) by bilemail1.empirix.com ([fe80::f9e0:9293:2523:f021%22]) with mapi id 15.00.0775.031; Tue, 29 Sep 2015 12:06:52 -0400 From: "Montorsi, Francesco" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] "cannot use T= with gcov target" when doing "makefile clean" with DPDK-2.1.0 Thread-Index: AdDhbi380VYQE1bsROKmpNhj2Fpn4QH9iwKAA4qdKNA= Date: Tue, 29 Sep 2015 16:06:52 +0000 Message-ID: References: <55ED4361.8050008@6wind.com> In-Reply-To: <55ED4361.8050008@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.116.12] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] "cannot use T= with gcov target" when doing "makefile clean" with DPDK-2.1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 16:07:24 -0000 Hi Olivier, Sorry for the delay: > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > I had a look to your test case, I think the second command is not correct= . The > T=3D parameter is not allowed for the clean target. It should be somethin= g like > this: >=20 > # configure a workspace using template specified by T=3D in the > # directory specified by O=3D > make T=3Dx86_64-native-linuxapp-gcc O=3Dx86_64-native-linuxapp-gcc conf= ig >=20 > # clean the directory specified by O=3D > make O=3Dx86_64-native-linuxapp-gcc clean >=20 > See "make help" for details. >=20 >=20 > I think the proper patch would be to add the following lines on the top o= f > rte.sdkbuild.mk: >=20 > ifdef T > ifeq ("$(origin T)", "command line") > $(error "Cannot use T=3D with a build/clean target") > endif > endif >=20 >=20 > It would then display the proper error message. > Can you have a try? You're right. It was not clear to me that T=3D is coinceived as option of t= he "config" target only, but it makes absolutely sense. I added the code you posted on ret.sdkbuild.mk and it works just fine, maki= ng this usage case more clear... I just submitted a patch for that. Thanks, Francesco