From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C99F3A0096 for ; Wed, 5 Jun 2019 14:30:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC8C31B9E3; Wed, 5 Jun 2019 14:29:59 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B1FB21B9DF; Wed, 5 Jun 2019 14:29:58 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14BD634CF; Wed, 5 Jun 2019 12:29:53 +0000 (UTC) Received: from [10.36.112.53] (ovpn-112-53.ams2.redhat.com [10.36.112.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95A4A19C65; Wed, 5 Jun 2019 12:29:49 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Tiwei Bie , Zhihong Wang References: <1557389028-2462-1-git-send-email-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: Date: Wed, 5 Jun 2019 14:29:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1557389028-2462-1-git-send-email-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 05 Jun 2019 12:29:53 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove useless check on mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/9/19 10:03 AM, David Marchand wrote: > This .rx_queue_setup devop is called after ethdev already dereferenced > the mempool pointer. > No need to check and we can remove this rte_exit. > > Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper place") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/virtio/virtio_rxtx.c | 5 ----- > 1 file changed, 5 deletions(-) Applied to dpdk-next-virtio/master. Thanks, Maxime