From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31D2BA00C4; Fri, 30 Sep 2022 11:05:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8EFD40E5A; Fri, 30 Sep 2022 11:05:28 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 949A040684 for ; Fri, 30 Sep 2022 11:05:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664528727; x=1696064727; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=OaG23Vl+9YUWQsFtMkrpzY0m7mhaEhUmnQcvmiO76rw=; b=XEd2FlQjvz9IFBI0U4jgUYq0BMCLb8wyVyCUMcVKA79vwo0ybF5RM6Z2 Bj9xZpQe+qx1CKL8SYlNA+yfEXRHMIUz6q0uXuJuCC1aWZJTvIKtDfgPu jJc6dpNtGlG5ThVbLvaRbpn/2WDqb7S+yQ0IDYPWL2IiCkrvzflrr5xpB WJcWahfANYrZqWFyirc+tImEXmtwD5MCYccqnuM5BRhNObOJb0mIaZbka 3oxoDXff4/Xbej/bsWGtA5aY+5sPUfzLFFdJDSOqcsQozlx393JPjIGJY zg5hyf2x5P/c97kyZxzWnZA79hMfn/zApgQgWsKicA9rytVgGOc/wHzJs g==; X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="281858054" X-IronPort-AV: E=Sophos;i="5.93,357,1654585200"; d="scan'208";a="281858054" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2022 02:05:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="748169434" X-IronPort-AV: E=Sophos;i="5.93,357,1654585200"; d="scan'208";a="748169434" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 30 Sep 2022 02:05:25 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 30 Sep 2022 02:05:25 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 30 Sep 2022 02:05:25 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 30 Sep 2022 02:05:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+j0OTQM9LCZjcbXOvsJ5rEvO1brYLOpEphUEHotAZmTC8FLweb0pTXVvoI0thIEJDjD6j2QiiogKqpl5DP1vmKJFCrjEgEV/TLlgFCqQZqZdXFvidyyGC1FZPgzRhFO5gwXS5vvtcUe2Ct9NDO/GEPAOZtcfH1pJpbS/w6+eLmE0fEbpQ5Mmj51jC4owsvfoRpOH07yU/FRitQqRHaC7pIOEeRdOsJFnXXZmjNify82N9dA/Jw+Hi3ah8WrF8L/Vsc8CK4AgArIIsxfetGPCEX9G0sujX9yoKc3t2S9zRxPaSECW2nKx0UimMNZgffUEKhCIFutGR4Vwy/i+sY1SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OaG23Vl+9YUWQsFtMkrpzY0m7mhaEhUmnQcvmiO76rw=; b=aw0FLhAYebMYcGExsbBJS3EQMLRq8uWkFsKiyRr3GU0mcAth15iB/WEz0TCb/NztRXrDZK62lAiQeMYhxyCM3VuKXk09k/Rio0JGrdHHsQBi/stfRivenij8yNs8Q7yB8txp9/u/L1DzIp8dEj6UEcc4MN70sbbzzQ+ZkUhQyfQ/Nbj0qeVgdArd3aPcXTfHfy9v/Wy7XE9mh0YyjOcx3M7oBADzZefIsMrB0J8gAPkXxlyhlesWIy2hRlHcnFEIJt2K9MChVUoI7354oF97QHPcjwwIkR0jZviPak+4cLygvf6OIfxoCn4GFnwIf6pkCbEZVhgXijf4xcpl07mj6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by IA1PR11MB7173.namprd11.prod.outlook.com (2603:10b6:208:41b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Fri, 30 Sep 2022 09:05:23 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::38ce:5dd1:3d0:a7db]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::38ce:5dd1:3d0:a7db%4]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 09:05:23 +0000 Message-ID: Date: Fri, 30 Sep 2022 10:05:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.2.1 Subject: Re: [PATCH v4] net/iavf: fix TSO offload for tunnel case To: Zhichao Zeng , CC: , , , Jingjing Wu , Beilei Xing , Abhijit Sinha , Declan Doherty References: <20220927095634.448796-1-zhichaox.zeng@intel.com> <20220929052702.668519-1-zhichaox.zeng@intel.com> Content-Language: en-GB From: "Nicolau, Radu" In-Reply-To: <20220929052702.668519-1-zhichaox.zeng@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0320.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::19) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|IA1PR11MB7173:EE_ X-MS-Office365-Filtering-Correlation-Id: 525c5b50-d43e-4c1d-888e-08daa2c2e857 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8hx7N/maenJ3AKjdEdBmsfJXxTrOk08/j/CEVjIWAAnN8gEjnCQ2z2uFqfJL10w3ia8C5q2isZUwGy3APG4AHf2DJJ7HxCstPBwKYsTp3M4uCllT+YTRyXf6nHzxEZ+S2HKquQtQ6i6sQf9oZ3tZCWtI02bv2do/MuQcVILT1tB5Ibru4fdphFLfBdYuPsI3xmfFbQGfawMorersWpyqhU4ARhA2Dg3OAGXTPw1HPA4JFGid3Y95iNcbFjzLT6lZhC2iptLxqVzANoFwpjdpJyyOompP4uhS1grJvU3VwZ4b6njNGBB4tG+3QdLRiznYhb+gL8N4Q3BlkY6OtKGasj4CgCuNy6mRzOTEtMXaoIu25rMSdb2DAmGmiVpiW8tAv4p9Z2CkY5xd6KlPARndaixQ5l3oKufbSxVtcrhqrSoP0b+MxeGnB3Pg6SkTNUzI/vNR0vVhWAUl5793r2irFLlMz02QRQd7wNk39wAWwna/y8luV0AZkSgsDG2FENe9gd/241eanExH3c4kd0ixF/VlISC7Bzp7uUxUu6S+5MmzF3X97/zvMEH0aF+aEkQov6S6NmjIP7B7LQ/1o+6t3puW65upVzoH2ubLNhXUCsmL133p/U9n5WNFVhlD637VQVvw86AHnhdGK/sRdR2GwsG7acqr0gsIl3Qnkw+2lo/e+pBW4k3H8spLCJmj+6b3ja7kkRSGe+bh5vHz3kv5gCCk1IA1qQRf7b+0t7zNslxDBDIciv1172L5KQ9r8j+a/9iWHL8CsBSd+Mpf6np6uw2jBurAT3+Yr8eSM+tWJLQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199015)(31686004)(66476007)(6512007)(26005)(2616005)(186003)(316002)(6666004)(36756003)(6506007)(82960400001)(38100700002)(55236004)(53546011)(6486002)(83380400001)(2906002)(54906003)(107886003)(8936002)(41300700001)(5660300002)(8676002)(478600001)(4326008)(66946007)(66556008)(86362001)(4744005)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bktNb25xMlUwWHRrRlpKRHR5ZXU2bDZqclI4RTVGd2c5Z2dFN1NoUklaUjRX?= =?utf-8?B?a0JtdnVsMy9vQlJVN2h1K3VoY21rbUhJU3JVbFdDcVloTXdOOHE2ZXRBenlJ?= =?utf-8?B?TFU2NytxOHF4VndZckdUQXBWdERjSE5wL1ROMkFnbUQ4VzNmN0F0WHJ0N2FB?= =?utf-8?B?NGhRL1NDZFFoK2tXdUZQNkkrMXBmbHVpeDdqRXdqakViclNxL1RmZGZEcnQv?= =?utf-8?B?MkJrc0RqOFJoZ0REcU4zZW0za2lFeGlEMndTUVZBMXR2ayt3MTE0dElyU2JJ?= =?utf-8?B?RVp1Y1p5U2FtNmxxS0pXZTBZOVRLVlBBRUdJNVFZZnN4eFhtUkI2dllkSHNo?= =?utf-8?B?bzlaUzJJUTdjUXd0cjVPdHpMaHpOWGh6Y1dDNTR4czFoc2p3enRkNVVtZzUw?= =?utf-8?B?TlB6OXBGK0swWlk4cktrRk1zMmE4RWptMjlnS05wWHR3R0YraGVFa3diRnJR?= =?utf-8?B?SkZBQnhWc0tvcFE2dTcvOU5xTTIzVXJtT25HSDNVYUx5Y29IL3EvU2EzWVRR?= =?utf-8?B?TVNtZTFTbThBZFNjVmk2MVNram1iT2xMSjRWdGhIREl4WUdGQW1xUzhMbHhM?= =?utf-8?B?Wk1sNmlqOE5PSjlIVmF2T1YzUmZ0ckZhZ2hyemQ4UGRBT2REUlhpZzBLUEVk?= =?utf-8?B?VW84SVd3Q3JYQkVaOFQ0ZllDRWFGYnJHY1VEVCt6ZnRRMUFBcDFOZ094YXI5?= =?utf-8?B?b244aEk4dHg0MEdtTlFVSy9xUis1YVdYUlR5MGVHRTY2ZkNVYmdid0pOYmxZ?= =?utf-8?B?eUxYc3VNai9EMFVaSkpGbU5rQWl4WHJJZzdXdzYvQTZMakxDdWFMb0ZrZ09G?= =?utf-8?B?RndSMWlQZzRhQmJTc0RLbWpXaDdqRmVWOUUvaGV2eGJMR1ltZmo0YWZlRmlx?= =?utf-8?B?RlFHSGF4a2FNWENHWW54bGw0allwRjVEb3dIV3lxRitha3pNOFhnQ2FyNmhh?= =?utf-8?B?VEtSVkZ2c2xHdEhpUm1BMFZBNStmdHU0VStOa0lINTVrL0lSY2tkd2NKb210?= =?utf-8?B?MEtxUTBBWkJPRGxYSFVPeVF6Tnh1WnNKWk9TRnY3ekdYSzhjWDc1S0NqWjBv?= =?utf-8?B?dGQvVmUrSUZ6SFkvV1VRUTZoT1pXQ29CbXNNaHBjUW5aU2FtZlM5ckRGd3NN?= =?utf-8?B?OVFJM3B4QmkwQ1krSTAvM3FTRUpKK2tRcEtiM2dKamhYUitWRXlLRXg0L05O?= =?utf-8?B?NmlsbGsyQk55SUMvWEFDK042MTRCa3JoUEZsV0g2NEZjdk53ZWhUbm1NRHdU?= =?utf-8?B?U3RPMDVnMnV6UjhKeFh4ZlA2NTY5WHBPN3VHRDNGdFgxRnVqMFg1WXVXeTVa?= =?utf-8?B?elh1YzRidVkvck94anNrWFpQUXRrWkpjL2puZCtFeUl1NjV4Y21teWpvMGVi?= =?utf-8?B?QW9XdS8rZXErUE5nS25nUkorNXBqNWdYcGFTOGlKdjU5OWc5UGl3dnRoZUVr?= =?utf-8?B?V3lpMGRWUDJnWlhLMVF2eUtvaVpYWHdxQm5hSGR2YnFQakNiRk1PaGkwK0d6?= =?utf-8?B?OVZJVWx0WUpOT2VsaW9hSDh6VE9aV0Nxa0wxMjdVRVhhcTRldDJwMW5nVUdh?= =?utf-8?B?SHpicGs0N1pzMFF4bW9CUXIxR0VzTm0xYU1OUDlMVkN1emRFYnJ2ek0yTG56?= =?utf-8?B?Y0psdVNzV3U2NUZzdUlDOTZzelp1WDVWb0pWSnBqVGN3bEJPamo3Rzk2a1FV?= =?utf-8?B?a215cGFqSHFrTVMxRUtlK1c0SmNJdm5SMW9DK05DSnZWWlVFRGxUd1JERWpD?= =?utf-8?B?WjB3RjVCeTVWd1BVYXNZa3R4bGNRT0xKVk91aS96aytNZHUwbWhYVlpZMFE1?= =?utf-8?B?TmkwZVRKbExXTlNhNS9pdVJFc1JaT09mV3FoS0FJeU0zanMyMmNiTm9IRDhD?= =?utf-8?B?TFNPalpRVWczS09JUHdYeXF3LzFZRkZFZkZHNmV6b1U5U21iaTNpcXNiTmNs?= =?utf-8?B?V05JYVBGZWtVRXJoQ3o4RGZmUk9oM2Y1MG9wMEE2ZWRoSWdSUnF5MzVJN0Vy?= =?utf-8?B?bXM4V2VLaW5ERnEzdFBEa1BBTE51YzIrT1N5OWoxQkJiTHdiUWtuMXpQTmNL?= =?utf-8?B?aWNra29kMUhjTWZaOWRLK3NJVUtweThFZjFEZ0RxSnJBZzg4cVFmMkNoMHZI?= =?utf-8?B?SHpYZEhmUjhEQXoyK2ZDdU5QVm0wZzF3OXp1RlZNYytzZ3kzOHJFV0hmL2hx?= =?utf-8?B?REE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 525c5b50-d43e-4c1d-888e-08daa2c2e857 X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 09:05:23.4095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SqEsiz3bnltn+KhexVqrYuEjTgkZ6m5OHBPMzgQyjoVVvp8YZ1QHrVaESUaVltIKvqBJvUrxXX1mM9C5wrnaNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7173 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/29/2022 6:27 AM, Zhichao Zeng wrote: > This patch is to fix the tunnel TSO not enabling issue, simplify > the logic of calculating 'Tx Buffer Size' of data descriptor with IPSec, > and fix handling that the mbuf size exceeds the TX descriptor > hardware limit(1B-16KB) which causes malicious behavior to the NIC. > > Fixes: 1e728b01120c ("net/iavf: rework Tx path") > > Signed-off-by: Zhichao Zeng > > --- Acked-by: Radu Nicolau