DPDK patches and discussions
 help / color / mirror / Atom feed
From: oulijun <oulijun@huawei.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"linuxarm@openeuler.org" <linuxarm@openeuler.org>,
	nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
Date: Thu, 25 Mar 2021 15:56:13 +0800
Message-ID: <ec0abc7f-f4a0-d71a-1550-2c7314a6e829@huawei.com> (raw)
In-Reply-To: <VI1PR0802MB2480E091CF6F769578CFD5C39E629@VI1PR0802MB2480.eurprd08.prod.outlook.com>



在 2021/3/25 15:45, Ruifeng Wang 写道:
>> -----Original Message-----
>> From: oulijun <oulijun@huawei.com>
>> Sent: Thursday, March 25, 2021 3:22 PM
>> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
>> ferruh.yigit@intel.com
>> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
>> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
>> kunpeng920 implementer
>>
>>
>>
>> 在 2021/3/23 23:40, Ruifeng Wang 写道:
>>>> -----Original Message-----
>>>> From: oulijun <oulijun@huawei.com>
>>>> Sent: Tuesday, March 23, 2021 9:52 PM
>>>> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net;
>>>> ferruh.yigit@intel.com
>>>> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com>
>>>> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
>>>> kunpeng920 implementer
>>>>
>>>>
>>>>
>>>>      2021/3/23 16:07, Ruifeng Wang д  :
>>>>>> -----Original Message-----
>>>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
>>>>>> Sent: Wednesday, March 10, 2021 9:36 AM
>>>>>> To: thomas@monjalon.net; ferruh.yigit@intel.com
>>>>>> Cc: dev@dpdk.org; linuxarm@openeuler.org
>>>>>> Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon
>>>>>> kunpeng920 implementer
>>>>>>
>>>>>> Here addes Kunpeng920 config back which was deleted.
> 
> There was no Kunpeng920 specific config before change 91c730fd4e09.
> It would fall back to generic build because the behavior was to do generic build for unknown implementor / part number.
> 
What should we do with this patch? This is because we cannot compile on 
the Kunpeng 920 server without adding generic build.
>>>>>>
>>>>>> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous
>>>>>> variables")
>>>>>>
>>>>>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
>>>>>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>>>>>> ---
>>>>>> V1->V2:
>>>>>> - rewrite patch title.
>>>>>> - split the patch into two.
>>>>>> ---
>>>>>>     config/arm/meson.build | 20 ++++++++++++++++++++
>>>>>>     1 file changed, 20 insertions(+)
>>>>>>
>>>>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>>>>>> 00bc461..3826900 100644
>>>>>> --- a/config/arm/meson.build
>>>>>> +++ b/config/arm/meson.build
>>>>>> @@ -133,6 +133,25 @@ implementer_cavium = {
>>>>>>     	}
>>>>>>     }
>>>>>>
>>>>>> +implementer_hisilicon = {
>>>>>> +	'description': 'Hisilicon',
>>>>>> +	'flags': [
>>>>>> +		['RTE_USE_C11_MEM_MODEL', true],
>>>>>> +		['RTE_CACHE_LINE_SIZE', 128],
>>>>>
>>>>> Just want to double check.
>>>>> One Kunpeng920 box I can access have cache line size 64B.
>>>>>
>>>> I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For
>>>> kunpeng920, L1/L2 cache size is 64B  L3 is 128B
>>>
>>> Got it.
>>> I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache.
>>> Data can be prefetched into any level of cache by using different APIs.
>>>
>> So our current configuration should be fine.
> 
> Agree.
> 
>>>>> Thanks.
>>>>>> +		['RTE_MAX_NUMA_NODES', 4]
>>>>>> +	],
>>>>>> +	'part_number_config': {
>>>>>> +		'0xd01': {
>>>>>> +			'machine_args': ['-march=armv8.2-a+crypto',
>>>>>> +					 '-mtune=tsv110'],
>>>>>> +			'flag': [['RTE_MACHINE', '"kunpeng920"'],
>>>>>> +				 ['RTE_MAX_LCORE', 128],
>>>>>> +				 ['RTE_ARM_FEATURE_ATOMICS', true]
>>>>>> +			]
>>>>>> +		}
>>>>>> +	}
>>>>>> +}
>>>>>> +
>>>>>>     implementer_ampere = {
>>>>>>     	'description': 'Ampere Computing',
>>>>>>     	'flags': [
>>>>>> @@ -190,6 +209,7 @@ implementers = {
>>>>>>     	'generic': implementer_generic,
>>>>>>     	'0x41': implementer_arm,
>>>>>>     	'0x43': implementer_cavium,
>>>>>> +	'0x48': implementer_hisilicon,
>>>>>>     	'0x50': implementer_ampere,
>>>>>>     	'0x51': implementer_qualcomm,
>>>>>>     	'0x56': implementer_marvell,
>>>>>> --
>>>>>> 2.7.4
>>>>>
>>>>> .
>>>>>

  reply	other threads:[~2021-03-25  7:56 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 12:46 [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 Lijun Ou
2021-02-03 12:46 ` [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Lijun Ou
2021-02-10  9:41   ` Thomas Monjalon
2021-02-24  1:34     ` oulijun
2021-02-24  7:41       ` Thomas Monjalon
2021-02-24  9:17         ` oulijun
2021-02-24 10:24           ` Thomas Monjalon
2021-02-24 11:55         ` Juraj Linkeš
2021-02-24 12:09           ` Thomas Monjalon
2021-03-01 10:46             ` Juraj Linkeš
2021-03-05  1:36               ` oulijun
2021-03-22  1:01                 ` Min Hu (Connor)
2021-02-03 12:46 ` [dpdk-dev] [PATCH 2/2] config/arm: fix Hisilicon kunpeng930 Soc build Lijun Ou
2021-03-05  1:38 ` [dpdk-dev] [PATCH 0/2] meson build fixes for hns3 oulijun
2021-03-10  1:35 ` [dpdk-dev] [PATCH V2 0/4] add Hisilicon kunpeng CPU support Lijun Ou
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer Lijun Ou
2021-03-20  2:27     ` Min Hu (Connor)
2021-03-23  8:07     ` Ruifeng Wang
2021-03-23 13:51       ` oulijun
2021-03-23 15:40         ` Ruifeng Wang
2021-03-25  7:21           ` oulijun
2021-03-25  7:45             ` Ruifeng Wang
2021-03-25  7:56               ` oulijun [this message]
2021-03-25  8:10                 ` Ruifeng Wang
2021-03-26 12:40     ` Jerin Jacob
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 2/4] config/arm: add Hisilicon kunpeng930 implementer Lijun Ou
2021-03-26 12:42     ` Jerin Jacob
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target Lijun Ou
2021-03-25  7:48     ` Ruifeng Wang
2021-03-26 12:45       ` Jerin Jacob
2021-03-10  1:35   ` [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 " Lijun Ou
2021-03-25  7:49     ` Ruifeng Wang
2021-03-26 12:46     ` Jerin Jacob
2021-03-27  1:27   ` [dpdk-dev] [PATCH V3 0/3] add Hisilicon kunpeng CPU support Lijun Ou
2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 1/3] config/arm: add Hisilicon kunpeng implementer Lijun Ou
2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 2/3] config/arm: add kunpeng920 cross target Lijun Ou
2021-03-27  1:27     ` [dpdk-dev] [PATCH V3 3/3] config/arm: add kunpeng930 " Lijun Ou
2021-04-16  9:57     ` [dpdk-dev] [PATCH V4 0/3] add Hisilicon kunpeng CPU support Lijun Ou
2021-04-16  9:57       ` [dpdk-dev] [PATCH V4 1/3] config/arm: add Hisilicon kunpeng implementer Lijun Ou
2021-04-16  9:57       ` [dpdk-dev] [PATCH V4 2/3] config/arm: add kunpeng920 cross target Lijun Ou
2021-04-16  9:57       ` [dpdk-dev] [PATCH V4 3/3] config/arm: add kunpeng930 " Lijun Ou
2021-04-19  8:10       ` [dpdk-dev] [PATCH V4 0/3] add Hisilicon kunpeng CPU support Thomas Monjalon
     [not found] ` <6032863.io6GlxzLMq@thomas>
     [not found]   ` <f0e55cbc-3b61-8858-a5e7-aeee9dc613c2@huawei.com>
     [not found]     ` <6796692.TXxtQ3U2Ta@thomas>
2021-03-25 13:26       ` [dpdk-dev] [Linuxarm] [PATCH V2 0/4] " oulijun
2021-03-25 14:40         ` Thomas Monjalon
2021-03-26  0:41           ` oulijun
2021-04-05 19:50             ` Honnappa Nagarahalli
2021-04-06  1:00               ` oulijun
2021-04-07  2:19                 ` Honnappa Nagarahalli
2021-04-08  3:30                   ` oulijun
2021-04-08  8:01                     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec0abc7f-f4a0-d71a-1550-2c7314a6e829@huawei.com \
    --to=oulijun@huawei.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=linuxarm@openeuler.org \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git