* [PATCH] mem: fix infinite loop
@ 2025-04-02 12:42 Dengdui Huang
2025-04-02 21:16 ` Dmitry Kozlyuk
2025-04-03 2:57 ` [PATCH v2] " Dengdui Huang
0 siblings, 2 replies; 4+ messages in thread
From: Dengdui Huang @ 2025-04-02 12:42 UTC (permalink / raw)
To: dev
Cc: fengchengwen, lihuisong, haijie1, liuyonglong, roretzla,
anatoly.burakov, stephen, mb
When the process address space is insufficient,
mmap will fail, which will cause an infinite loop.
This pathc fix it.
Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
Cc: stable@dpdk.org
Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
---
lib/eal/common/eal_common_memory.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c
index a185e0b580..0c997201bd 100644
--- a/lib/eal/common/eal_common_memory.c
+++ b/lib/eal/common/eal_common_memory.c
@@ -101,8 +101,12 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
mapped_addr = eal_mem_reserve(
requested_addr, (size_t)map_sz, reserve_flags);
- if ((mapped_addr == NULL) && allow_shrink)
- *size -= page_sz;
+ if (mapped_addr == NULL) {
+ if (allow_shrink)
+ *size -= page_sz;
+ else
+ break;
+ }
if ((mapped_addr != NULL) && addr_is_hint &&
(mapped_addr != requested_addr)) {
--
2.33.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mem: fix infinite loop
2025-04-02 12:42 [PATCH] mem: fix infinite loop Dengdui Huang
@ 2025-04-02 21:16 ` Dmitry Kozlyuk
2025-04-03 1:25 ` huangdengdui
2025-04-03 2:57 ` [PATCH v2] " Dengdui Huang
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Kozlyuk @ 2025-04-02 21:16 UTC (permalink / raw)
To: Dengdui Huang, dev
Cc: fengchengwen, lihuisong, haijie1, liuyonglong, roretzla,
anatoly.burakov, stephen, mb
On 02.04.2025 15:42, Dengdui Huang wrote:
> When the process address space is insufficient,
> mmap will fail, which will cause an infinite loop.
> This pathc fix it.
>
> Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Typo: "pathc fix" -> "patch fixes", or, better:
"This patch stops attempting mmap if it fails and the requested size
cannot be reduced."
The bug is actually older, but it doesn't matter since both c4b89ecb64ea
and b7cc54187ea4 belong to all LTS:
Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory")
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mem: fix infinite loop
2025-04-02 21:16 ` Dmitry Kozlyuk
@ 2025-04-03 1:25 ` huangdengdui
0 siblings, 0 replies; 4+ messages in thread
From: huangdengdui @ 2025-04-03 1:25 UTC (permalink / raw)
To: Dmitry Kozlyuk, dev
Cc: fengchengwen, lihuisong, haijie1, liuyonglong, roretzla,
anatoly.burakov, stephen, mb
On 2025/4/3 5:16, Dmitry Kozlyuk wrote:
> On 02.04.2025 15:42, Dengdui Huang wrote:
>> When the process address space is insufficient,
>> mmap will fail, which will cause an infinite loop.
>> This pathc fix it.
>>
>> Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> Typo: "pathc fix" -> "patch fixes", or, better:
> "This patch stops attempting mmap if it fails and the requested size cannot be reduced."
>
> The bug is actually older, but it doesn't matter since both c4b89ecb64ea and b7cc54187ea4 belong to all LTS:
>
> Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory")
>
It would be better to write the commit log like this, and I'll modify it in v2.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] mem: fix infinite loop
2025-04-02 12:42 [PATCH] mem: fix infinite loop Dengdui Huang
2025-04-02 21:16 ` Dmitry Kozlyuk
@ 2025-04-03 2:57 ` Dengdui Huang
1 sibling, 0 replies; 4+ messages in thread
From: Dengdui Huang @ 2025-04-03 2:57 UTC (permalink / raw)
To: dev
Cc: fengchengwen, lihuisong, haijie1, liuyonglong, roretzla,
anatoly.burakov, stephen, mb, dmitry.kozliuk
When the process address space is insufficient,
mmap will fail, which will cause an infinite loop.
This patch stops attempting mmap if it fails and
the requested size cannot be reduced.
Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory")
Cc: stable@dpdk.org
Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
lib/eal/common/eal_common_memory.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c
index a185e0b580..0c997201bd 100644
--- a/lib/eal/common/eal_common_memory.c
+++ b/lib/eal/common/eal_common_memory.c
@@ -101,8 +101,12 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
mapped_addr = eal_mem_reserve(
requested_addr, (size_t)map_sz, reserve_flags);
- if ((mapped_addr == NULL) && allow_shrink)
- *size -= page_sz;
+ if (mapped_addr == NULL) {
+ if (allow_shrink)
+ *size -= page_sz;
+ else
+ break;
+ }
if ((mapped_addr != NULL) && addr_is_hint &&
(mapped_addr != requested_addr)) {
--
2.33.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-03 2:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-02 12:42 [PATCH] mem: fix infinite loop Dengdui Huang
2025-04-02 21:16 ` Dmitry Kozlyuk
2025-04-03 1:25 ` huangdengdui
2025-04-03 2:57 ` [PATCH v2] " Dengdui Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).