From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54A2BA00C5; Thu, 15 Sep 2022 12:19:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44F704021D; Thu, 15 Sep 2022 12:19:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id ABF3240156 for ; Thu, 15 Sep 2022 12:19:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663237152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RSBAkL7TSWH3ll2nss1lxGYx3ks3jgeemD+3x8+IZ/o=; b=LmmrUplH+6Q5O3Qhrj+XjAgCuS5HK6rTIt7Z01Wexm/Y25+2oHBhhzrqBHn6fpf2DrkEN9 c85U2SN/V/tu/y1+iIUEmaR7QrjZPf3t32Dv+o6coJhtenMc88MOJpcOv1Xjj+kTE5l9cS YQ1MMKuh+90NRbRPZTeN+IXP/Muwl3s= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-578-ncMptYsGP1SLAtHZh4ETvQ-1; Thu, 15 Sep 2022 06:19:11 -0400 X-MC-Unique: ncMptYsGP1SLAtHZh4ETvQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9F751381078B; Thu, 15 Sep 2022 10:19:10 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 672031121314; Thu, 15 Sep 2022 10:19:09 +0000 (UTC) Message-ID: Date: Thu, 15 Sep 2022 12:19:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 28/37] baseband/acc100: make desc optimization optional To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-29-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-29-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Add ACC100_DESC_OPTIMIZATION flag to enable muxing of encode operations > with common FCW. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 69de204293..7b23529ec3 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -4569,9 +4569,10 @@ acc100_enqueue_ldpc_dec_cb(struct rte_bbdev_queue_data *q_data, > break; > } > avail -= 1; > - > +#ifdef ACC100_DESC_OPTIMIZATION > if (i > 0) > same_op = cmp_ldpc_dec_op(&ops[i-1]); > +#endif Nack, don't put optimizations under #ifdefs as I explained on an earlier patch. > rte_bbdev_log(INFO, "Op %d %d %d %d %d %d %d %d %d %d %d %d\n", > i, ops[i]->ldpc_dec.op_flags, ops[i]->ldpc_dec.rv_index, > ops[i]->ldpc_dec.iter_max, ops[i]->ldpc_dec.iter_count,